[INFO] updating cached repository hexjelly/cryptopals-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hexjelly/cryptopals-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hexjelly/cryptopals-rust" "work/ex/clippy-test-run/sources/stable/gh/hexjelly/cryptopals-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hexjelly/cryptopals-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hexjelly/cryptopals-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hexjelly/cryptopals-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hexjelly/cryptopals-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6735da77c69ec72185e9f0ba31bb708f893b04cf [INFO] sha for GitHub repo hexjelly/cryptopals-rust: 6735da77c69ec72185e9f0ba31bb708f893b04cf [INFO] validating manifest of hexjelly/cryptopals-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hexjelly/cryptopals-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hexjelly/cryptopals-rust [INFO] finished frobbing hexjelly/cryptopals-rust [INFO] frobbed toml for hexjelly/cryptopals-rust written to work/ex/clippy-test-run/sources/stable/gh/hexjelly/cryptopals-rust/Cargo.toml [INFO] started frobbing hexjelly/cryptopals-rust [INFO] finished frobbing hexjelly/cryptopals-rust [INFO] frobbed toml for hexjelly/cryptopals-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hexjelly/cryptopals-rust/Cargo.toml [INFO] crate hexjelly/cryptopals-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hexjelly/cryptopals-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hexjelly/cryptopals-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d4f375cc51a76e2a258f7465753f73504e10ee5499c01203d15d87acdf08671b [INFO] running `"docker" "start" "-a" "d4f375cc51a76e2a258f7465753f73504e10ee5499c01203d15d87acdf08671b"` [INFO] [stderr] Checking data-encoding v1.1.2 [INFO] [stderr] Checking cryptopals v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:49:67 [INFO] [stderr] | [INFO] [stderr] 49 | else if *byte == 9_u8 || *byte == 10_u8 || *byte == 13_u8 { ignored += 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:48:51 [INFO] [stderr] | [INFO] [stderr] 48 | else if *byte >= 33_u8 && *byte <= 126_u8 { ignored += 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | for n in min_key_len..max_key_len+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `min_key_len..=max_key_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cryptopals`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:49:67 [INFO] [stderr] | [INFO] [stderr] 49 | else if *byte == 9_u8 || *byte == 10_u8 || *byte == 13_u8 { ignored += 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:48:51 [INFO] [stderr] | [INFO] [stderr] 48 | else if *byte >= 33_u8 && *byte <= 126_u8 { ignored += 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | for n in min_key_len..max_key_len+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `min_key_len..=max_key_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cryptopals`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d4f375cc51a76e2a258f7465753f73504e10ee5499c01203d15d87acdf08671b"` [INFO] running `"docker" "rm" "-f" "d4f375cc51a76e2a258f7465753f73504e10ee5499c01203d15d87acdf08671b"` [INFO] [stdout] d4f375cc51a76e2a258f7465753f73504e10ee5499c01203d15d87acdf08671b