[INFO] updating cached repository henryroyal/cli-binary-search [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/henryroyal/cli-binary-search [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/henryroyal/cli-binary-search" "work/ex/clippy-test-run/sources/stable/gh/henryroyal/cli-binary-search"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/henryroyal/cli-binary-search'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/henryroyal/cli-binary-search" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henryroyal/cli-binary-search"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henryroyal/cli-binary-search'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a2fc3d7a0657071152ab8c219d13e18a94aa6942 [INFO] sha for GitHub repo henryroyal/cli-binary-search: a2fc3d7a0657071152ab8c219d13e18a94aa6942 [INFO] validating manifest of henryroyal/cli-binary-search on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of henryroyal/cli-binary-search on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing henryroyal/cli-binary-search [INFO] finished frobbing henryroyal/cli-binary-search [INFO] frobbed toml for henryroyal/cli-binary-search written to work/ex/clippy-test-run/sources/stable/gh/henryroyal/cli-binary-search/Cargo.toml [INFO] started frobbing henryroyal/cli-binary-search [INFO] finished frobbing henryroyal/cli-binary-search [INFO] frobbed toml for henryroyal/cli-binary-search written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henryroyal/cli-binary-search/Cargo.toml [INFO] crate henryroyal/cli-binary-search has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting henryroyal/cli-binary-search against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/henryroyal/cli-binary-search:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb6b906bb1eb598fcc3a2d8f307411e94c1e1b50cae5247061e85fe141b4f7b0 [INFO] running `"docker" "start" "-a" "eb6b906bb1eb598fcc3a2d8f307411e94c1e1b50cae5247061e85fe141b4f7b0"` [INFO] [stderr] Checking binary_search v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | return line; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | return line; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len_one` [INFO] [stderr] --> src/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | let len_one = one.remove(0); [INFO] [stderr] | ^^^^^^^ help: consider using `_len_one` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len_two` [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let len_two = two.remove(0); [INFO] [stderr] | ^^^^^^^ help: consider using `_len_two` instead [INFO] [stderr] [INFO] [stderr] warning: variable `DEBUG` should have a snake case name such as `debug` [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let DEBUG: bool = false; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | stdin.read_line(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len_one` [INFO] [stderr] --> src/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | let len_one = one.remove(0); [INFO] [stderr] | ^^^^^^^ help: consider using `_len_one` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len_two` [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let len_two = two.remove(0); [INFO] [stderr] | ^^^^^^^ help: consider using `_len_two` instead [INFO] [stderr] [INFO] [stderr] warning: variable `DEBUG` should have a snake case name such as `debug` [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let DEBUG: bool = false; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | stdin.read_line(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.42s [INFO] running `"docker" "inspect" "eb6b906bb1eb598fcc3a2d8f307411e94c1e1b50cae5247061e85fe141b4f7b0"` [INFO] running `"docker" "rm" "-f" "eb6b906bb1eb598fcc3a2d8f307411e94c1e1b50cae5247061e85fe141b4f7b0"` [INFO] [stdout] eb6b906bb1eb598fcc3a2d8f307411e94c1e1b50cae5247061e85fe141b4f7b0