[INFO] updating cached repository henrikvik/wasm_pong [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/henrikvik/wasm_pong [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/henrikvik/wasm_pong" "work/ex/clippy-test-run/sources/stable/gh/henrikvik/wasm_pong"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/henrikvik/wasm_pong'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/henrikvik/wasm_pong" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henrikvik/wasm_pong"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henrikvik/wasm_pong'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 132d2da78dbeb3ed0516be12aaa7f77202131c54 [INFO] sha for GitHub repo henrikvik/wasm_pong: 132d2da78dbeb3ed0516be12aaa7f77202131c54 [INFO] validating manifest of henrikvik/wasm_pong on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of henrikvik/wasm_pong on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing henrikvik/wasm_pong [INFO] finished frobbing henrikvik/wasm_pong [INFO] frobbed toml for henrikvik/wasm_pong written to work/ex/clippy-test-run/sources/stable/gh/henrikvik/wasm_pong/Cargo.toml [INFO] started frobbing henrikvik/wasm_pong [INFO] finished frobbing henrikvik/wasm_pong [INFO] frobbed toml for henrikvik/wasm_pong written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henrikvik/wasm_pong/Cargo.toml [INFO] crate henrikvik/wasm_pong has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting henrikvik/wasm_pong against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/henrikvik/wasm_pong:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34b434476a5a086a6c25187438c05454f3a8048395cfb16dbb55555833923569 [INFO] running `"docker" "start" "-a" "34b434476a5a086a6c25187438c05454f3a8048395cfb16dbb55555833923569"` [INFO] [stderr] Compiling regex-syntax v0.6.3 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Compiling nom v4.1.1 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.28 [INFO] [stderr] Compiling failure v0.1.3 [INFO] [stderr] Compiling weedle v0.8.0 [INFO] [stderr] Checking nalgebra v0.16.10 [INFO] [stderr] Compiling regex v1.0.6 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.28 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.28 [INFO] [stderr] Compiling env_logger v0.6.0 [INFO] [stderr] Checking wasm-bindgen v0.2.28 [INFO] [stderr] Compiling wasm-bindgen-webidl v0.2.22 [INFO] [stderr] Checking js-sys v0.3.5 [INFO] [stderr] Checking console_error_panic_hook v0.1.5 [INFO] [stderr] Compiling web-sys v0.3.5 [INFO] [stderr] Checking wasm_pong v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: field is never used: `buffers` [INFO] [stderr] --> src/gfx/renderer.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | buffers: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `camera` [INFO] [stderr] --> src/gfx/renderer.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | camera: Camera, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `window` [INFO] [stderr] --> src/lib.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | window: Window, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `document` [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | document: Document, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `canvas` [INFO] [stderr] --> src/lib.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | canvas: HtmlCanvasElement, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/gfx/renderer.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | 400.0 / 400.0, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/gfx/shader_program.rs:67:20 [INFO] [stderr] | [INFO] [stderr] 67 | panic!("attribute '{}' does not exist"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/gfx/shader_program.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | .expect(&format!("uniform '{}' does not exist", name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("uniform '{}' does not exist", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/gfx/shader_program.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / self.attributes [INFO] [stderr] 81 | | .get(name) [INFO] [stderr] 82 | | .expect(&format!("attribute '{}' not registered", name)) [INFO] [stderr] 83 | | .clone() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 80 | *self.attributes [INFO] [stderr] 81 | .get(name) [INFO] [stderr] 82 | .expect(&format!("attribute '{}' not registered", name)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/gfx/shader_program.rs:82:14 [INFO] [stderr] | [INFO] [stderr] 82 | .expect(&format!("attribute '{}' not registered", name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("attribute '{}' not registered", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: field is never used: `buffers` [INFO] [stderr] --> src/gfx/renderer.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | buffers: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `camera` [INFO] [stderr] --> src/gfx/renderer.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | camera: Camera, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `window` [INFO] [stderr] --> src/lib.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | window: Window, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `document` [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | document: Document, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `canvas` [INFO] [stderr] --> src/lib.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | canvas: HtmlCanvasElement, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/gfx/shader_program.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | .expect(&format!("attribute '{}' not registered", name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("attribute '{}' not registered", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/gfx/shader_program.rs:115:14 [INFO] [stderr] | [INFO] [stderr] 115 | .unwrap_or(String::from("unknow error")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("unknow error"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/gfx/shader_program.rs:141:14 [INFO] [stderr] | [INFO] [stderr] 141 | .unwrap_or(String::from("unknow error")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("unknow error"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/gfx/renderer.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | 400.0 / 400.0, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/gfx/buffer.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | &js_array_wrapper(data.as_ref()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `App` [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> App { [INFO] [stderr] 36 | | console_error_panic_hook::set_once(); [INFO] [stderr] 37 | | [INFO] [stderr] 38 | | let width = 400; [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for App { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/gfx/shader_program.rs:67:20 [INFO] [stderr] | [INFO] [stderr] 67 | panic!("attribute '{}' does not exist"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/gfx/shader_program.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | .expect(&format!("uniform '{}' does not exist", name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("uniform '{}' does not exist", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/gfx/shader_program.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / self.attributes [INFO] [stderr] 81 | | .get(name) [INFO] [stderr] 82 | | .expect(&format!("attribute '{}' not registered", name)) [INFO] [stderr] 83 | | .clone() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 80 | *self.attributes [INFO] [stderr] 81 | .get(name) [INFO] [stderr] 82 | .expect(&format!("attribute '{}' not registered", name)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/gfx/shader_program.rs:82:14 [INFO] [stderr] | [INFO] [stderr] 82 | .expect(&format!("attribute '{}' not registered", name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("attribute '{}' not registered", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm_pong`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/gfx/shader_program.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | .expect(&format!("attribute '{}' not registered", name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("attribute '{}' not registered", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/gfx/shader_program.rs:115:14 [INFO] [stderr] | [INFO] [stderr] 115 | .unwrap_or(String::from("unknow error")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("unknow error"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/gfx/shader_program.rs:141:14 [INFO] [stderr] | [INFO] [stderr] 141 | .unwrap_or(String::from("unknow error")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("unknow error"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/gfx/buffer.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | &js_array_wrapper(data.as_ref()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `App` [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> App { [INFO] [stderr] 36 | | console_error_panic_hook::set_once(); [INFO] [stderr] 37 | | [INFO] [stderr] 38 | | let width = 400; [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for App { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm_pong`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "34b434476a5a086a6c25187438c05454f3a8048395cfb16dbb55555833923569"` [INFO] running `"docker" "rm" "-f" "34b434476a5a086a6c25187438c05454f3a8048395cfb16dbb55555833923569"` [INFO] [stdout] 34b434476a5a086a6c25187438c05454f3a8048395cfb16dbb55555833923569