[INFO] updating cached repository henninglive/boids-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/henninglive/boids-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/henninglive/boids-rs" "work/ex/clippy-test-run/sources/stable/gh/henninglive/boids-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/henninglive/boids-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/henninglive/boids-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henninglive/boids-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henninglive/boids-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b9a59fab7e0d98cf54ece54aa95a11198029cd59 [INFO] sha for GitHub repo henninglive/boids-rs: b9a59fab7e0d98cf54ece54aa95a11198029cd59 [INFO] validating manifest of henninglive/boids-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of henninglive/boids-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing henninglive/boids-rs [INFO] finished frobbing henninglive/boids-rs [INFO] frobbed toml for henninglive/boids-rs written to work/ex/clippy-test-run/sources/stable/gh/henninglive/boids-rs/Cargo.toml [INFO] started frobbing henninglive/boids-rs [INFO] finished frobbing henninglive/boids-rs [INFO] frobbed toml for henninglive/boids-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/henninglive/boids-rs/Cargo.toml [INFO] crate henninglive/boids-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting henninglive/boids-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/henninglive/boids-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83024350a7dd9cc2128082b9423d7f8be9b5eb1acf093975c31f92bbb44db01e [INFO] running `"docker" "start" "-a" "83024350a7dd9cc2128082b9423d7f8be9b5eb1acf093975c31f92bbb44db01e"` [INFO] [stderr] Compiling libc v0.2.24 [INFO] [stderr] Compiling num-traits v0.1.39 [INFO] [stderr] Checking dds-rs v0.4.0 [INFO] [stderr] Checking wavefront_obj v5.0.0 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking num_cpus v1.5.1 [INFO] [stderr] Compiling miniz-sys v0.1.9 [INFO] [stderr] Checking ticketed_lock v0.1.0 [INFO] [stderr] Checking num-complex v0.1.38 [INFO] [stderr] Checking amethyst_config v0.2.2 [INFO] [stderr] Checking cgmath v0.14.1 [INFO] [stderr] Checking cgmath v0.12.0 [INFO] [stderr] Checking pulse v0.5.3 [INFO] [stderr] Checking gfx_core v0.6.1 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling glutin v0.7.4 [INFO] [stderr] Checking x11-dl v2.14.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking specs v0.8.1 [INFO] [stderr] Checking tempfile v2.1.5 [INFO] [stderr] Checking alga v0.5.1 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking genmesh v0.4.3 [INFO] [stderr] Checking flate2 v0.2.19 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking nalgebra v0.12.3 [INFO] [stderr] Checking imagefmt v4.0.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking gfx_device_gl v0.13.1 [INFO] [stderr] Checking gfx v0.14.1 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking gfx_window_glutin v0.14.0 [INFO] [stderr] Checking amethyst_renderer v0.4.3 [INFO] [stderr] Checking amethyst v0.4.3 [INFO] [stderr] Checking boids v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:142:66 [INFO] [stderr] | [INFO] [stderr] 142 | let delta_time = time.delta_time.subsec_nanos() as f32 / 1000000000.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:225:64 [INFO] [stderr] | [INFO] [stderr] 225 | let pos_range_x = range::Range::new(-(screen.w / 2.0), (screen.w / 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:226:64 [INFO] [stderr] | [INFO] [stderr] 226 | let pos_range_y = range::Range::new(-(screen.h / 2.0), (screen.h / 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:142:66 [INFO] [stderr] | [INFO] [stderr] 142 | let delta_time = time.delta_time.subsec_nanos() as f32 / 1000000000.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:225:64 [INFO] [stderr] | [INFO] [stderr] 225 | let pos_range_x = range::Range::new(-(screen.w / 2.0), (screen.w / 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:226:64 [INFO] [stderr] | [INFO] [stderr] 226 | let pos_range_y = range::Range::new(-(screen.h / 2.0), (screen.h / 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | fn forces(pos_a: &Vector2, pos_b: &Vector2, vel_b: &Vector2) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:66:40 [INFO] [stderr] | [INFO] [stderr] 66 | fn forces(pos_a: &Vector2, pos_b: &Vector2, vel_b: &Vector2) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:66:62 [INFO] [stderr] | [INFO] [stderr] 66 | fn forces(pos_a: &Vector2, pos_b: &Vector2, vel_b: &Vector2) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:125:26 [INFO] [stderr] | [INFO] [stderr] 125 | .or(forces(&pos.0, &(pos2.0 - height), &vel2.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| forces(&pos.0, &(pos2.0 - height), &vel2.0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:124:26 [INFO] [stderr] | [INFO] [stderr] 124 | .or(forces(&pos.0, &(pos2.0 + height), &vel2.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| forces(&pos.0, &(pos2.0 + height), &vel2.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:123:26 [INFO] [stderr] | [INFO] [stderr] 123 | .or(forces(&pos.0, &(pos2.0 - width), &vel2.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| forces(&pos.0, &(pos2.0 - width), &vel2.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:122:26 [INFO] [stderr] | [INFO] [stderr] 122 | .or(forces(&pos.0, &(pos2.0 + width), &vel2.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| forces(&pos.0, &(pos2.0 + width), &vel2.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | fn forces(pos_a: &Vector2, pos_b: &Vector2, vel_b: &Vector2) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:66:40 [INFO] [stderr] | [INFO] [stderr] 66 | fn forces(pos_a: &Vector2, pos_b: &Vector2, vel_b: &Vector2) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:66:62 [INFO] [stderr] | [INFO] [stderr] 66 | fn forces(pos_a: &Vector2, pos_b: &Vector2, vel_b: &Vector2) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:125:26 [INFO] [stderr] | [INFO] [stderr] 125 | .or(forces(&pos.0, &(pos2.0 - height), &vel2.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| forces(&pos.0, &(pos2.0 - height), &vel2.0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:124:26 [INFO] [stderr] | [INFO] [stderr] 124 | .or(forces(&pos.0, &(pos2.0 + height), &vel2.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| forces(&pos.0, &(pos2.0 + height), &vel2.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:123:26 [INFO] [stderr] | [INFO] [stderr] 123 | .or(forces(&pos.0, &(pos2.0 - width), &vel2.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| forces(&pos.0, &(pos2.0 - width), &vel2.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:122:26 [INFO] [stderr] | [INFO] [stderr] 122 | .or(forces(&pos.0, &(pos2.0 + width), &vel2.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| forces(&pos.0, &(pos2.0 + width), &vel2.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 35s [INFO] running `"docker" "inspect" "83024350a7dd9cc2128082b9423d7f8be9b5eb1acf093975c31f92bbb44db01e"` [INFO] running `"docker" "rm" "-f" "83024350a7dd9cc2128082b9423d7f8be9b5eb1acf093975c31f92bbb44db01e"` [INFO] [stdout] 83024350a7dd9cc2128082b9423d7f8be9b5eb1acf093975c31f92bbb44db01e