[INFO] updating cached repository hemnet/http-hello-world [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hemnet/http-hello-world [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hemnet/http-hello-world" "work/ex/clippy-test-run/sources/stable/gh/hemnet/http-hello-world"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hemnet/http-hello-world'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hemnet/http-hello-world" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hemnet/http-hello-world"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hemnet/http-hello-world'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c18d4563b771c173636602022c6ab03a327a929e [INFO] sha for GitHub repo hemnet/http-hello-world: c18d4563b771c173636602022c6ab03a327a929e [INFO] validating manifest of hemnet/http-hello-world on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hemnet/http-hello-world on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hemnet/http-hello-world [INFO] finished frobbing hemnet/http-hello-world [INFO] frobbed toml for hemnet/http-hello-world written to work/ex/clippy-test-run/sources/stable/gh/hemnet/http-hello-world/Cargo.toml [INFO] started frobbing hemnet/http-hello-world [INFO] finished frobbing hemnet/http-hello-world [INFO] frobbed toml for hemnet/http-hello-world written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hemnet/http-hello-world/Cargo.toml [INFO] crate hemnet/http-hello-world has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hemnet/http-hello-world against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hemnet/http-hello-world:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7ec0fa380334427701cab03c880a8df038be7c9f32e9923a3ea28bb153b43fec [INFO] running `"docker" "start" "-a" "7ec0fa380334427701cab03c880a8df038be7c9f32e9923a3ea28bb153b43fec"` [INFO] [stderr] Checking chan v0.1.19 [INFO] [stderr] Checking hyper v0.10.5 [INFO] [stderr] Checking chan-signal v0.2.0 [INFO] [stderr] Checking http-hello-world v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:8:46 [INFO] [stderr] | [INFO] [stderr] 8 | let receiver = std::env::var("RECEIVER").unwrap_or(String::from("World")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("World"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:14:38 [INFO] [stderr] | [INFO] [stderr] 14 | let port = std::env::var("PORT").unwrap_or(String::from("80")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("80"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:8:46 [INFO] [stderr] | [INFO] [stderr] 8 | let receiver = std::env::var("RECEIVER").unwrap_or(String::from("World")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("World"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:14:38 [INFO] [stderr] | [INFO] [stderr] 14 | let port = std::env::var("PORT").unwrap_or(String::from("80")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("80"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.63s [INFO] running `"docker" "inspect" "7ec0fa380334427701cab03c880a8df038be7c9f32e9923a3ea28bb153b43fec"` [INFO] running `"docker" "rm" "-f" "7ec0fa380334427701cab03c880a8df038be7c9f32e9923a3ea28bb153b43fec"` [INFO] [stdout] 7ec0fa380334427701cab03c880a8df038be7c9f32e9923a3ea28bb153b43fec