[INFO] updating cached repository hemangandhi/ascii-cam [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hemangandhi/ascii-cam [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hemangandhi/ascii-cam" "work/ex/clippy-test-run/sources/stable/gh/hemangandhi/ascii-cam"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hemangandhi/ascii-cam'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hemangandhi/ascii-cam" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hemangandhi/ascii-cam"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hemangandhi/ascii-cam'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 25b998ed9f1c0573b08f3e43da6fb06eb4a6699f [INFO] sha for GitHub repo hemangandhi/ascii-cam: 25b998ed9f1c0573b08f3e43da6fb06eb4a6699f [INFO] validating manifest of hemangandhi/ascii-cam on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hemangandhi/ascii-cam on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hemangandhi/ascii-cam [INFO] finished frobbing hemangandhi/ascii-cam [INFO] frobbed toml for hemangandhi/ascii-cam written to work/ex/clippy-test-run/sources/stable/gh/hemangandhi/ascii-cam/Cargo.toml [INFO] started frobbing hemangandhi/ascii-cam [INFO] finished frobbing hemangandhi/ascii-cam [INFO] frobbed toml for hemangandhi/ascii-cam written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hemangandhi/ascii-cam/Cargo.toml [INFO] crate hemangandhi/ascii-cam has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hemangandhi/ascii-cam against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hemangandhi/ascii-cam:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30fc315ef94e7a2a5caec03d75af3c7cad1a0c7ea4c9399723a82018bd2b8489 [INFO] running `"docker" "start" "-a" "30fc315ef94e7a2a5caec03d75af3c7cad1a0c7ea4c9399723a82018bd2b8489"` [INFO] [stderr] Checking ascii-cam v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::fs` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::fs; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::fs; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return x - y; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `x - y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return y - x; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `y - x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return (d_x * d_x + d_y * d_y + d_z * d_z).sqrt() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(d_x * d_x + d_y * d_y + d_z * d_z).sqrt() as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return Box::new(rv); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(rv)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return dist.exp() / (sigma * sigma * 2.0 * PI); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dist.exp() / (sigma * sigma * 2.0 * PI)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return image::ImageBuffer::from_fn(ib.width(), ib.height(), inner); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `image::ImageBuffer::from_fn(ib.width(), ib.height(), inner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / return image::Rgb{ [INFO] [stderr] 47 | | data: [pix[0] as u8, pix[1] as u8, pix[2] as u8] [INFO] [stderr] 48 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 46 | image::Rgb{ [INFO] [stderr] 47 | data: [pix[0] as u8, pix[1] as u8, pix[2] as u8] [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / return Box::new(move |ib| { [INFO] [stderr] 57 | | return image::ImageBuffer::from_fn(ib.width(), ib.height(), |x, y| { [INFO] [stderr] 58 | | for i in (x as i32) - 1 .. (x as i32) + 1 { [INFO] [stderr] 59 | | for j in (y as i32) - 1 .. (y as i32) + 1 { [INFO] [stderr] ... | [INFO] [stderr] 75 | | }); [INFO] [stderr] 76 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | Box::new(move |ib| { [INFO] [stderr] 57 | return image::ImageBuffer::from_fn(ib.width(), ib.height(), |x, y| { [INFO] [stderr] 58 | for i in (x as i32) - 1 .. (x as i32) + 1 { [INFO] [stderr] 59 | for j in (y as i32) - 1 .. (y as i32) + 1 { [INFO] [stderr] 60 | if i < 0 || i >= (ib.width() as i32) || j < 0 || j >= (ib.height() as i32) { [INFO] [stderr] 61 | continue; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / return image::ImageBuffer::from_fn(ib.width(), ib.height(), |x, y| { [INFO] [stderr] 58 | | for i in (x as i32) - 1 .. (x as i32) + 1 { [INFO] [stderr] 59 | | for j in (y as i32) - 1 .. (y as i32) + 1 { [INFO] [stderr] 60 | | if i < 0 || i >= (ib.width() as i32) || j < 0 || j >= (ib.height() as i32) { [INFO] [stderr] ... | [INFO] [stderr] 74 | | }; [INFO] [stderr] 75 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | image::ImageBuffer::from_fn(ib.width(), ib.height(), |x, y| { [INFO] [stderr] 58 | for i in (x as i32) - 1 .. (x as i32) + 1 { [INFO] [stderr] 59 | for j in (y as i32) - 1 .. (y as i32) + 1 { [INFO] [stderr] 60 | if i < 0 || i >= (ib.width() as i32) || j < 0 || j >= (ib.height() as i32) { [INFO] [stderr] 61 | continue; [INFO] [stderr] 62 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | / return image::Rgb{ [INFO] [stderr] 73 | | data: [255, 255, 255] [INFO] [stderr] 74 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | image::Rgb{ [INFO] [stderr] 73 | data: [255, 255, 255] [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / return Box::new(move |ib| { [INFO] [stderr] 81 | | return image::ImageBuffer::from_fn(ib.width() / wscale, ib.height() / hscale, |x, y| { [INFO] [stderr] 82 | | let top_left_x = wscale * x; [INFO] [stderr] 83 | | let top_left_y = hscale * y; [INFO] [stderr] ... | [INFO] [stderr] 101 | | }); [INFO] [stderr] 102 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 80 | Box::new(move |ib| { [INFO] [stderr] 81 | return image::ImageBuffer::from_fn(ib.width() / wscale, ib.height() / hscale, |x, y| { [INFO] [stderr] 82 | let top_left_x = wscale * x; [INFO] [stderr] 83 | let top_left_y = hscale * y; [INFO] [stderr] 84 | let bottom_right_x = wscale * (x + 1) - 1; [INFO] [stderr] 85 | let bottom_right_y = hscale * (y + 1) - 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / return image::ImageBuffer::from_fn(ib.width() / wscale, ib.height() / hscale, |x, y| { [INFO] [stderr] 82 | | let top_left_x = wscale * x; [INFO] [stderr] 83 | | let top_left_y = hscale * y; [INFO] [stderr] 84 | | let bottom_right_x = wscale * (x + 1) - 1; [INFO] [stderr] ... | [INFO] [stderr] 100 | | }; [INFO] [stderr] 101 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 81 | image::ImageBuffer::from_fn(ib.width() / wscale, ib.height() / hscale, |x, y| { [INFO] [stderr] 82 | let top_left_x = wscale * x; [INFO] [stderr] 83 | let top_left_y = hscale * y; [INFO] [stderr] 84 | let bottom_right_x = wscale * (x + 1) - 1; [INFO] [stderr] 85 | let bottom_right_y = hscale * (y + 1) - 1; [INFO] [stderr] 86 | let area = ((bottom_right_x - top_left_x) * (bottom_right_y - top_left_y)) as f64; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | / return image::Rgb{ [INFO] [stderr] 99 | | data: [pix[0] as u8, pix[1] as u8, pix[2] as u8] [INFO] [stderr] 100 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 98 | image::Rgb{ [INFO] [stderr] 99 | data: [pix[0] as u8, pix[1] as u8, pix[2] as u8] [INFO] [stderr] 100 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return x - y; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `x - y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return y - x; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `y - x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return (d_x * d_x + d_y * d_y + d_z * d_z).sqrt() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(d_x * d_x + d_y * d_y + d_z * d_z).sqrt() as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return Box::new(rv); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(rv)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return dist.exp() / (sigma * sigma * 2.0 * PI); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dist.exp() / (sigma * sigma * 2.0 * PI)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return image::ImageBuffer::from_fn(ib.width(), ib.height(), inner); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `image::ImageBuffer::from_fn(ib.width(), ib.height(), inner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / return image::Rgb{ [INFO] [stderr] 47 | | data: [pix[0] as u8, pix[1] as u8, pix[2] as u8] [INFO] [stderr] 48 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 46 | image::Rgb{ [INFO] [stderr] 47 | data: [pix[0] as u8, pix[1] as u8, pix[2] as u8] [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / return Box::new(move |ib| { [INFO] [stderr] 57 | | return image::ImageBuffer::from_fn(ib.width(), ib.height(), |x, y| { [INFO] [stderr] 58 | | for i in (x as i32) - 1 .. (x as i32) + 1 { [INFO] [stderr] 59 | | for j in (y as i32) - 1 .. (y as i32) + 1 { [INFO] [stderr] ... | [INFO] [stderr] 75 | | }); [INFO] [stderr] 76 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | Box::new(move |ib| { [INFO] [stderr] 57 | return image::ImageBuffer::from_fn(ib.width(), ib.height(), |x, y| { [INFO] [stderr] 58 | for i in (x as i32) - 1 .. (x as i32) + 1 { [INFO] [stderr] 59 | for j in (y as i32) - 1 .. (y as i32) + 1 { [INFO] [stderr] 60 | if i < 0 || i >= (ib.width() as i32) || j < 0 || j >= (ib.height() as i32) { [INFO] [stderr] 61 | continue; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / return image::ImageBuffer::from_fn(ib.width(), ib.height(), |x, y| { [INFO] [stderr] 58 | | for i in (x as i32) - 1 .. (x as i32) + 1 { [INFO] [stderr] 59 | | for j in (y as i32) - 1 .. (y as i32) + 1 { [INFO] [stderr] 60 | | if i < 0 || i >= (ib.width() as i32) || j < 0 || j >= (ib.height() as i32) { [INFO] [stderr] ... | [INFO] [stderr] 74 | | }; [INFO] [stderr] 75 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | image::ImageBuffer::from_fn(ib.width(), ib.height(), |x, y| { [INFO] [stderr] 58 | for i in (x as i32) - 1 .. (x as i32) + 1 { [INFO] [stderr] 59 | for j in (y as i32) - 1 .. (y as i32) + 1 { [INFO] [stderr] 60 | if i < 0 || i >= (ib.width() as i32) || j < 0 || j >= (ib.height() as i32) { [INFO] [stderr] 61 | continue; [INFO] [stderr] 62 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | / return image::Rgb{ [INFO] [stderr] 73 | | data: [255, 255, 255] [INFO] [stderr] 74 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | image::Rgb{ [INFO] [stderr] 73 | data: [255, 255, 255] [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / return Box::new(move |ib| { [INFO] [stderr] 81 | | return image::ImageBuffer::from_fn(ib.width() / wscale, ib.height() / hscale, |x, y| { [INFO] [stderr] 82 | | let top_left_x = wscale * x; [INFO] [stderr] 83 | | let top_left_y = hscale * y; [INFO] [stderr] ... | [INFO] [stderr] 101 | | }); [INFO] [stderr] 102 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 80 | Box::new(move |ib| { [INFO] [stderr] 81 | return image::ImageBuffer::from_fn(ib.width() / wscale, ib.height() / hscale, |x, y| { [INFO] [stderr] 82 | let top_left_x = wscale * x; [INFO] [stderr] 83 | let top_left_y = hscale * y; [INFO] [stderr] 84 | let bottom_right_x = wscale * (x + 1) - 1; [INFO] [stderr] 85 | let bottom_right_y = hscale * (y + 1) - 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / return image::ImageBuffer::from_fn(ib.width() / wscale, ib.height() / hscale, |x, y| { [INFO] [stderr] 82 | | let top_left_x = wscale * x; [INFO] [stderr] 83 | | let top_left_y = hscale * y; [INFO] [stderr] 84 | | let bottom_right_x = wscale * (x + 1) - 1; [INFO] [stderr] ... | [INFO] [stderr] 100 | | }; [INFO] [stderr] 101 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 81 | image::ImageBuffer::from_fn(ib.width() / wscale, ib.height() / hscale, |x, y| { [INFO] [stderr] 82 | let top_left_x = wscale * x; [INFO] [stderr] 83 | let top_left_y = hscale * y; [INFO] [stderr] 84 | let bottom_right_x = wscale * (x + 1) - 1; [INFO] [stderr] 85 | let bottom_right_y = hscale * (y + 1) - 1; [INFO] [stderr] 86 | let area = ((bottom_right_x - top_left_x) * (bottom_right_y - top_left_y)) as f64; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filters.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | / return image::Rgb{ [INFO] [stderr] 99 | | data: [pix[0] as u8, pix[1] as u8, pix[2] as u8] [INFO] [stderr] 100 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 98 | image::Rgb{ [INFO] [stderr] 99 | data: [pix[0] as u8, pix[1] as u8, pix[2] as u8] [INFO] [stderr] 100 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `carl2` [INFO] [stderr] --> src/main.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | let carl2 = & *(filters::gaussian_blur(7.0)); [INFO] [stderr] | ^^^^^ help: consider using `_carl2` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `carl2` [INFO] [stderr] --> src/main.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | let carl2 = & *(filters::gaussian_blur(7.0)); [INFO] [stderr] | ^^^^^ help: consider using `_carl2` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/filters.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | fn color_dist(this: &image::Rgb, other: &image::Rgb) -> u32{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `image::Rgb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/filters.rs:14:45 [INFO] [stderr] | [INFO] [stderr] 14 | fn color_dist(this: &image::Rgb, other: &image::Rgb) -> u32{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `image::Rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/filters.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | fn color_dist(this: &image::Rgb, other: &image::Rgb) -> u32{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `image::Rgb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/filters.rs:14:45 [INFO] [stderr] | [INFO] [stderr] 14 | fn color_dist(this: &image::Rgb, other: &image::Rgb) -> u32{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `image::Rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | let d_x = super_safe_sub(this.data[0], other.data[0]) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(super_safe_sub(this.data[0], other.data[0]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | let d_y = super_safe_sub(this.data[1], other.data[1]) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(super_safe_sub(this.data[1], other.data[1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | let d_x = super_safe_sub(this.data[0], other.data[0]) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(super_safe_sub(this.data[0], other.data[0]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | let d_y = super_safe_sub(this.data[1], other.data[1]) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(super_safe_sub(this.data[1], other.data[1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | let d_z = super_safe_sub(this.data[2], other.data[2]) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(super_safe_sub(this.data[2], other.data[2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/filters.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | pub type ImageFilter = Fn(image::ImageBuffer>) -> image::ImageBuffer>; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/filters.rs:21:70 [INFO] [stderr] | [INFO] [stderr] 21 | pub type ImageFilter = Fn(image::ImageBuffer>) -> image::ImageBuffer>; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/filters.rs:21:114 [INFO] [stderr] | [INFO] [stderr] 21 | pub type ImageFilter = Fn(image::ImageBuffer>) -> image::ImageBuffer>; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | let d_z = super_safe_sub(this.data[2], other.data[2]) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(super_safe_sub(this.data[2], other.data[2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | let dist = - (((cx - x) * (cx - x) + (cy - y) * (cy - y)) as f64 / (2.0 * sigma * sigma)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((cx - x) * (cx - x) + (cy - y) * (cy - y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/filters.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | pub type ImageFilter = Fn(image::ImageBuffer>) -> image::ImageBuffer>; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/filters.rs:21:70 [INFO] [stderr] | [INFO] [stderr] 21 | pub type ImageFilter = Fn(image::ImageBuffer>) -> image::ImageBuffer>; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/filters.rs:21:114 [INFO] [stderr] | [INFO] [stderr] 21 | pub type ImageFilter = Fn(image::ImageBuffer>) -> image::ImageBuffer>; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | let dist = - (((cx - x) * (cx - x) + (cy - y) * (cy - y)) as f64 / (2.0 * sigma * sigma)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((cx - x) * (cx - x) + (cy - y) * (cy - y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/filters.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | pix[0] = (p.data[0] as f64) * gauss + pix[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pix[0] += (p.data[0] as f64) * gauss` [INFO] [stderr] | [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/filters.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | pix[0] = (p.data[0] as f64) * gauss + pix[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pix[0] += (p.data[0] as f64) * gauss` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | pix[0] = (p.data[0] as f64) * gauss + pix[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | pix[0] = (p.data[0] as f64) * gauss + pix[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/filters.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | pix[1] = (p.data[1] as f64) * gauss + pix[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pix[1] += (p.data[1] as f64) * gauss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/filters.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | pix[1] = (p.data[1] as f64) * gauss + pix[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pix[1] += (p.data[1] as f64) * gauss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:42:30 [INFO] [stderr] | [INFO] [stderr] 42 | pix[1] = (p.data[1] as f64) * gauss + pix[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.data[1])` [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:42:30 [INFO] [stderr] | [INFO] [stderr] 42 | pix[1] = (p.data[1] as f64) * gauss + pix[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/filters.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | pix[2] = (p.data[2] as f64) * gauss + pix[2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pix[2] += (p.data[2] as f64) * gauss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:43:30 [INFO] [stderr] | [INFO] [stderr] 43 | pix[2] = (p.data[2] as f64) * gauss + pix[2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/filters.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | pix[2] = (p.data[2] as f64) * gauss + pix[2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pix[2] += (p.data[2] as f64) * gauss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:43:30 [INFO] [stderr] | [INFO] [stderr] 43 | pix[2] = (p.data[2] as f64) * gauss + pix[2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/filters.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | for i in (x as i32) - 1 .. (x as i32) + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(x as i32) - 1..=(x as i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/filters.rs:59:26 [INFO] [stderr] | [INFO] [stderr] 59 | for j in (y as i32) - 1 .. (y as i32) + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(y as i32) - 1..=(y as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/filters.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | for i in (x as i32) - 1 .. (x as i32) + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(x as i32) - 1..=(x as i32)` [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | let area = ((bottom_right_x - top_left_x) * (bottom_right_y - top_left_y)) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((bottom_right_x - top_left_x) * (bottom_right_y - top_left_y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:92:31 [INFO] [stderr] | [INFO] [stderr] 92 | pix[0] += (p[0] as f64)/area; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(p[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:93:31 [INFO] [stderr] | [INFO] [stderr] 93 | pix[1] += (p[1] as f64)/area; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(p[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:94:31 [INFO] [stderr] | [INFO] [stderr] 94 | pix[2] += (p[2] as f64)/area; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(p[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/filters.rs:59:26 [INFO] [stderr] | [INFO] [stderr] 59 | for j in (y as i32) - 1 .. (y as i32) + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(y as i32) - 1..=(y as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | let area = ((bottom_right_x - top_left_x) * (bottom_right_y - top_left_y)) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((bottom_right_x - top_left_x) * (bottom_right_y - top_left_y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:92:31 [INFO] [stderr] | [INFO] [stderr] 92 | pix[0] += (p[0] as f64)/area; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(p[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:93:31 [INFO] [stderr] | [INFO] [stderr] 93 | pix[1] += (p[1] as f64)/area; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(p[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters.rs:94:31 [INFO] [stderr] | [INFO] [stderr] 94 | pix[2] += (p[2] as f64)/area; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(p[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.54s [INFO] running `"docker" "inspect" "30fc315ef94e7a2a5caec03d75af3c7cad1a0c7ea4c9399723a82018bd2b8489"` [INFO] running `"docker" "rm" "-f" "30fc315ef94e7a2a5caec03d75af3c7cad1a0c7ea4c9399723a82018bd2b8489"` [INFO] [stdout] 30fc315ef94e7a2a5caec03d75af3c7cad1a0c7ea4c9399723a82018bd2b8489