[INFO] updating cached repository hellertime/opr-mandelbrot-server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hellertime/opr-mandelbrot-server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hellertime/opr-mandelbrot-server" "work/ex/clippy-test-run/sources/stable/gh/hellertime/opr-mandelbrot-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hellertime/opr-mandelbrot-server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hellertime/opr-mandelbrot-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hellertime/opr-mandelbrot-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hellertime/opr-mandelbrot-server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7177af0cf9db0c1f6aca7d75dc74a22f0a624c71 [INFO] sha for GitHub repo hellertime/opr-mandelbrot-server: 7177af0cf9db0c1f6aca7d75dc74a22f0a624c71 [INFO] validating manifest of hellertime/opr-mandelbrot-server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hellertime/opr-mandelbrot-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hellertime/opr-mandelbrot-server [INFO] finished frobbing hellertime/opr-mandelbrot-server [INFO] frobbed toml for hellertime/opr-mandelbrot-server written to work/ex/clippy-test-run/sources/stable/gh/hellertime/opr-mandelbrot-server/Cargo.toml [INFO] started frobbing hellertime/opr-mandelbrot-server [INFO] finished frobbing hellertime/opr-mandelbrot-server [INFO] frobbed toml for hellertime/opr-mandelbrot-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hellertime/opr-mandelbrot-server/Cargo.toml [INFO] crate hellertime/opr-mandelbrot-server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hellertime/opr-mandelbrot-server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hellertime/opr-mandelbrot-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf837224186fb4aee81d9704eb881f381ce96fef72fb9dbb21a7a24ef09d0299 [INFO] running `"docker" "start" "-a" "cf837224186fb4aee81d9704eb881f381ce96fef72fb9dbb21a7a24ef09d0299"` [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking serde_json v0.8.6 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking png v0.7.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking persistent v0.3.0 [INFO] [stderr] Checking logger v0.4.0 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking bodyparser v0.5.0 [INFO] [stderr] Checking urlencoded v0.5.0 [INFO] [stderr] Checking mandelbrot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:156:30 [INFO] [stderr] | [INFO] [stderr] 156 | response.set_mut(format!("missing the 'b' parameter\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"missing the 'b' parameter\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:162:34 [INFO] [stderr] | [INFO] [stderr] 162 | response.set_mut(format!("misformatted bounds\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"misformatted bounds\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:172:30 [INFO] [stderr] | [INFO] [stderr] 172 | response.set_mut(format!("missing the 'l' parameter\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"missing the 'l' parameter\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:178:34 [INFO] [stderr] | [INFO] [stderr] 178 | response.set_mut(format!("misformatted lower right\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"misformatted lower right\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:188:30 [INFO] [stderr] | [INFO] [stderr] 188 | response.set_mut(format!("missing the 'u' parameter\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"missing the 'u' parameter\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:194:34 [INFO] [stderr] | [INFO] [stderr] 194 | response.set_mut(format!("misformatted upper left\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"misformatted upper left\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | / match encoder.encode(&pixels, bounds.0 as u32, bounds.1 as u32, ColorType::Gray(8)) { [INFO] [stderr] 233 | | Err(e) => { [INFO] [stderr] 234 | | response.set_mut(status::InternalServerError); [INFO] [stderr] 235 | | response.set_mut(format!("failed to encode png: {:?}\n", e)); [INFO] [stderr] ... | [INFO] [stderr] 238 | | Ok(_) => () [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 232 | if let Err(e) = encoder.encode(&pixels, bounds.0 as u32, bounds.1 as u32, ColorType::Gray(8)) { [INFO] [stderr] 233 | response.set_mut(status::InternalServerError); [INFO] [stderr] 234 | response.set_mut(format!("failed to encode png: {:?}\n", e)); [INFO] [stderr] 235 | return Ok(response); [INFO] [stderr] 236 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:156:30 [INFO] [stderr] | [INFO] [stderr] 156 | response.set_mut(format!("missing the 'b' parameter\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"missing the 'b' parameter\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:162:34 [INFO] [stderr] | [INFO] [stderr] 162 | response.set_mut(format!("misformatted bounds\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"misformatted bounds\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:172:30 [INFO] [stderr] | [INFO] [stderr] 172 | response.set_mut(format!("missing the 'l' parameter\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"missing the 'l' parameter\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:178:34 [INFO] [stderr] | [INFO] [stderr] 178 | response.set_mut(format!("misformatted lower right\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"misformatted lower right\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:188:30 [INFO] [stderr] | [INFO] [stderr] 188 | response.set_mut(format!("missing the 'u' parameter\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"missing the 'u' parameter\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:194:34 [INFO] [stderr] | [INFO] [stderr] 194 | response.set_mut(format!("misformatted upper left\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"misformatted upper left\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | / match encoder.encode(&pixels, bounds.0 as u32, bounds.1 as u32, ColorType::Gray(8)) { [INFO] [stderr] 233 | | Err(e) => { [INFO] [stderr] 234 | | response.set_mut(status::InternalServerError); [INFO] [stderr] 235 | | response.set_mut(format!("failed to encode png: {:?}\n", e)); [INFO] [stderr] ... | [INFO] [stderr] 238 | | Ok(_) => () [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 232 | if let Err(e) = encoder.encode(&pixels, bounds.0 as u32, bounds.1 as u32, ColorType::Gray(8)) { [INFO] [stderr] 233 | response.set_mut(status::InternalServerError); [INFO] [stderr] 234 | response.set_mut(format!("failed to encode png: {:?}\n", e)); [INFO] [stderr] 235 | return Ok(response); [INFO] [stderr] 236 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.98s [INFO] running `"docker" "inspect" "cf837224186fb4aee81d9704eb881f381ce96fef72fb9dbb21a7a24ef09d0299"` [INFO] running `"docker" "rm" "-f" "cf837224186fb4aee81d9704eb881f381ce96fef72fb9dbb21a7a24ef09d0299"` [INFO] [stdout] cf837224186fb4aee81d9704eb881f381ce96fef72fb9dbb21a7a24ef09d0299