[INFO] updating cached repository hellblade/ray_tracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hellblade/ray_tracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hellblade/ray_tracer" "work/ex/clippy-test-run/sources/stable/gh/hellblade/ray_tracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hellblade/ray_tracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hellblade/ray_tracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hellblade/ray_tracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hellblade/ray_tracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b23e92848f066d61decbc543d8e514677512cf1d [INFO] sha for GitHub repo hellblade/ray_tracer: b23e92848f066d61decbc543d8e514677512cf1d [INFO] validating manifest of hellblade/ray_tracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hellblade/ray_tracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hellblade/ray_tracer [INFO] finished frobbing hellblade/ray_tracer [INFO] frobbed toml for hellblade/ray_tracer written to work/ex/clippy-test-run/sources/stable/gh/hellblade/ray_tracer/Cargo.toml [INFO] started frobbing hellblade/ray_tracer [INFO] finished frobbing hellblade/ray_tracer [INFO] frobbed toml for hellblade/ray_tracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hellblade/ray_tracer/Cargo.toml [INFO] crate hellblade/ray_tracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hellblade/ray_tracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hellblade/ray_tracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e7f2992873eb23ed39587493371830a66a147efc3c981a5407d9ba343b1ca84 [INFO] running `"docker" "start" "-a" "5e7f2992873eb23ed39587493371830a66a147efc3c981a5407d9ba343b1ca84"` [INFO] [stderr] Compiling syn v0.14.8 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking ray_tracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `math::sphere::float_cmp::ApproxEqUlps` [INFO] [stderr] --> src/math/sphere.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use math::sphere::float_cmp::ApproxEqUlps; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::float_cmp::ApproxEqUlps` [INFO] [stderr] --> src/math/vector.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use self::float_cmp::ApproxEqUlps; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `math::sphere::float_cmp::ApproxEqUlps` [INFO] [stderr] --> src/math/sphere.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use math::sphere::float_cmp::ApproxEqUlps; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::float_cmp::ApproxEqUlps` [INFO] [stderr] --> src/math/vector.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use self::float_cmp::ApproxEqUlps; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `zero` [INFO] [stderr] --> src/math/vector.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn zero() -> Vector3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `unit_y` [INFO] [stderr] --> src/math/vector.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn unit_y() -> Vector3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `unit_z` [INFO] [stderr] --> src/math/vector.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn unit_z() -> Vector3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math/vector.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | assert_eq!(vec.length(), 1_f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math/vector.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | assert_eq!(vec.length(), 1_f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math/vector.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | assert_eq!(vec.dot(vec), vec.length_squared()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math/vector.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | assert_eq!(vec.dot(vec), vec.length_squared()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | fn get_nearest(spheres: &Vec, ray: &Ray) -> (bool, f32, Sphere) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Sphere]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | fn is_occluded(spheres: &Vec, ray: &Ray, distance_to_light: f32, exclude: &Sphere) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Sphere]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:101:23 [INFO] [stderr] | [INFO] [stderr] 101 | + ambient_light as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(ambient_light)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ray_tracer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `normalise` [INFO] [stderr] --> src/math/vector.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn normalise(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `zero` [INFO] [stderr] --> src/math/vector.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn zero() -> Vector3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `unit_x` [INFO] [stderr] --> src/math/vector.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | pub fn unit_x() -> Vector3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `unit_y` [INFO] [stderr] --> src/math/vector.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn unit_y() -> Vector3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `unit_z` [INFO] [stderr] --> src/math/vector.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn unit_z() -> Vector3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | fn get_nearest(spheres: &Vec, ray: &Ray) -> (bool, f32, Sphere) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Sphere]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | fn is_occluded(spheres: &Vec, ray: &Ray, distance_to_light: f32, exclude: &Sphere) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Sphere]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:101:23 [INFO] [stderr] | [INFO] [stderr] 101 | + ambient_light as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(ambient_light)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "5e7f2992873eb23ed39587493371830a66a147efc3c981a5407d9ba343b1ca84"` [INFO] running `"docker" "rm" "-f" "5e7f2992873eb23ed39587493371830a66a147efc3c981a5407d9ba343b1ca84"` [INFO] [stdout] 5e7f2992873eb23ed39587493371830a66a147efc3c981a5407d9ba343b1ca84