[INFO] updating cached repository heliocentrist/k6-histogram [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/heliocentrist/k6-histogram [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/heliocentrist/k6-histogram" "work/ex/clippy-test-run/sources/stable/gh/heliocentrist/k6-histogram"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/heliocentrist/k6-histogram'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/heliocentrist/k6-histogram" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/heliocentrist/k6-histogram"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/heliocentrist/k6-histogram'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 502d2196188a817660fc8f751316a497dbbb7f74 [INFO] sha for GitHub repo heliocentrist/k6-histogram: 502d2196188a817660fc8f751316a497dbbb7f74 [INFO] validating manifest of heliocentrist/k6-histogram on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of heliocentrist/k6-histogram on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing heliocentrist/k6-histogram [INFO] finished frobbing heliocentrist/k6-histogram [INFO] frobbed toml for heliocentrist/k6-histogram written to work/ex/clippy-test-run/sources/stable/gh/heliocentrist/k6-histogram/Cargo.toml [INFO] started frobbing heliocentrist/k6-histogram [INFO] finished frobbing heliocentrist/k6-histogram [INFO] frobbed toml for heliocentrist/k6-histogram written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/heliocentrist/k6-histogram/Cargo.toml [INFO] crate heliocentrist/k6-histogram has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting heliocentrist/k6-histogram against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/heliocentrist/k6-histogram:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a2cb5a55d47d2194120c8ee8ede2c373b32fd797bbc749645c7aa9cf1d4b660e [INFO] running `"docker" "start" "-a" "a2cb5a55d47d2194120c8ee8ede2c373b32fd797bbc749645c7aa9cf1d4b660e"` [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking csv_play v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:52:68 [INFO] [stderr] | [INFO] [stderr] 52 | fn put_in_histo(histo: &mut [i32], thresholds: &[f64], value: f64) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | let duration = 314.131923; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `314.131_923` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:52:68 [INFO] [stderr] | [INFO] [stderr] 52 | fn put_in_histo(histo: &mut [i32], thresholds: &[f64], value: f64) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | histo[i] = histo[i] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `histo[i] += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | let bar_length = (max_width as f64 * (histo_value as f64 / *max_histo as f64)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(max_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:47 [INFO] [stderr] | [INFO] [stderr] 119 | let bar_length = (max_width as f64 * (histo_value as f64 / *max_histo as f64)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(histo_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:68 [INFO] [stderr] | [INFO] [stderr] 119 | let bar_length = (max_width as f64 * (histo_value as f64 / *max_histo as f64)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(*max_histo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | histo[i] = histo[i] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `histo[i] += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | let bar_length = (max_width as f64 * (histo_value as f64 / *max_histo as f64)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(max_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:47 [INFO] [stderr] | [INFO] [stderr] 119 | let bar_length = (max_width as f64 * (histo_value as f64 / *max_histo as f64)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(histo_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:68 [INFO] [stderr] | [INFO] [stderr] 119 | let bar_length = (max_width as f64 * (histo_value as f64 / *max_histo as f64)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(*max_histo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.40s [INFO] running `"docker" "inspect" "a2cb5a55d47d2194120c8ee8ede2c373b32fd797bbc749645c7aa9cf1d4b660e"` [INFO] running `"docker" "rm" "-f" "a2cb5a55d47d2194120c8ee8ede2c373b32fd797bbc749645c7aa9cf1d4b660e"` [INFO] [stdout] a2cb5a55d47d2194120c8ee8ede2c373b32fd797bbc749645c7aa9cf1d4b660e