[INFO] updating cached repository hekrause/garmin_translate [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hekrause/garmin_translate [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hekrause/garmin_translate" "work/ex/clippy-test-run/sources/stable/gh/hekrause/garmin_translate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hekrause/garmin_translate'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hekrause/garmin_translate" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hekrause/garmin_translate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hekrause/garmin_translate'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 12d99abf7f49f930aa19e6e42ca7d04cbd3b18ed [INFO] sha for GitHub repo hekrause/garmin_translate: 12d99abf7f49f930aa19e6e42ca7d04cbd3b18ed [INFO] validating manifest of hekrause/garmin_translate on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hekrause/garmin_translate on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hekrause/garmin_translate [INFO] finished frobbing hekrause/garmin_translate [INFO] frobbed toml for hekrause/garmin_translate written to work/ex/clippy-test-run/sources/stable/gh/hekrause/garmin_translate/Cargo.toml [INFO] started frobbing hekrause/garmin_translate [INFO] finished frobbing hekrause/garmin_translate [INFO] frobbed toml for hekrause/garmin_translate written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hekrause/garmin_translate/Cargo.toml [INFO] crate hekrause/garmin_translate has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hekrause/garmin_translate against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hekrause/garmin_translate:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14c5fecafad2649d1e560a4fd970b8466cea6c645c479faa04f943e94a4a967a [INFO] running `"docker" "start" "-a" "14c5fecafad2649d1e560a4fd970b8466cea6c645c479faa04f943e94a4a967a"` [INFO] [stderr] Compiling libsqlite3-sys v0.8.1 [INFO] [stderr] Checking nix v0.8.1 [INFO] [stderr] Checking rusqlite v0.11.0 [INFO] [stderr] Checking garmin_translator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/db_interface/mod.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn insert_values(timestamp: String, position_lat: String, position_long: String, distance: String, altitude: String, [INFO] [stderr] 25 | | speed: String, heart_rate: String, enhanced_altitude: String, enhanced_speed: String, dst_filename: &str) { [INFO] [stderr] 26 | | let conn = Connection::open("/home/henning/rust-programs/garmin_translator/src/db_interface/data_db.db").unwrap(); [INFO] [stderr] 27 | | [INFO] [stderr] ... | [INFO] [stderr] 31 | | conn.execute(&command, &[×tamp, &position_lat, &position_long, &distance, &altitude, &speed, &heart_rate, &enhanced_altitude, &enhanced_speed]).unwrap(); [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/file_parser/mod.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let split_newline = text.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `line` is only used to index `vec_newline`. [INFO] [stderr] --> src/file_parser/mod.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | for line in 1..vec_newline.len() - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 18 | for in vec_newline.iter().take(vec_newline.len() - 1).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/file_parser/mod.rs:20:55 [INFO] [stderr] | [INFO] [stderr] 20 | let split_comma = vec_newline[line].split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/db_interface/mod.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn insert_values(timestamp: String, position_lat: String, position_long: String, distance: String, altitude: String, [INFO] [stderr] 25 | | speed: String, heart_rate: String, enhanced_altitude: String, enhanced_speed: String, dst_filename: &str) { [INFO] [stderr] 26 | | let conn = Connection::open("/home/henning/rust-programs/garmin_translator/src/db_interface/data_db.db").unwrap(); [INFO] [stderr] 27 | | [INFO] [stderr] ... | [INFO] [stderr] 31 | | conn.execute(&command, &[×tamp, &position_lat, &position_long, &distance, &altitude, &speed, &heart_rate, &enhanced_altitude, &enhanced_speed]).unwrap(); [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/file_parser/mod.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/file_parser/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/file_parser/mod.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let split_newline = text.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `line` is only used to index `vec_newline`. [INFO] [stderr] --> src/file_parser/mod.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | for line in 1..vec_newline.len() - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 18 | for in vec_newline.iter().take(vec_newline.len() - 1).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/file_parser/mod.rs:20:55 [INFO] [stderr] | [INFO] [stderr] 20 | let split_comma = vec_newline[line].split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/file_parser/mod.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/file_parser/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.36s [INFO] running `"docker" "inspect" "14c5fecafad2649d1e560a4fd970b8466cea6c645c479faa04f943e94a4a967a"` [INFO] running `"docker" "rm" "-f" "14c5fecafad2649d1e560a4fd970b8466cea6c645c479faa04f943e94a4a967a"` [INFO] [stdout] 14c5fecafad2649d1e560a4fd970b8466cea6c645c479faa04f943e94a4a967a