[INFO] updating cached repository hegza/piston-playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hegza/piston-playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hegza/piston-playground" "work/ex/clippy-test-run/sources/stable/gh/hegza/piston-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hegza/piston-playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hegza/piston-playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hegza/piston-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hegza/piston-playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 085e7790bd3e2eba09e38b0c3fc22ece99667a4f [INFO] sha for GitHub repo hegza/piston-playground: 085e7790bd3e2eba09e38b0c3fc22ece99667a4f [INFO] validating manifest of hegza/piston-playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hegza/piston-playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hegza/piston-playground [INFO] finished frobbing hegza/piston-playground [INFO] frobbed toml for hegza/piston-playground written to work/ex/clippy-test-run/sources/stable/gh/hegza/piston-playground/Cargo.toml [INFO] started frobbing hegza/piston-playground [INFO] finished frobbing hegza/piston-playground [INFO] frobbed toml for hegza/piston-playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hegza/piston-playground/Cargo.toml [INFO] crate hegza/piston-playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hegza/piston-playground against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hegza/piston-playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 42f8e46e99ef8b0ff73e291999dedebb068f28dff8e469f9576f374f8965018d [INFO] running `"docker" "start" "-a" "42f8e46e99ef8b0ff73e291999dedebb068f28dff8e469f9576f374f8965018d"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `spinning-square`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Compiling siphasher v0.2.0 [INFO] [stderr] Compiling serde v0.8.23 [INFO] [stderr] Checking deflate v0.7.2 [INFO] [stderr] Compiling wayland-scanner v0.7.6 [INFO] [stderr] Checking pulse v0.5.3 [INFO] [stderr] Checking pistoncore-input v0.15.0 [INFO] [stderr] Compiling gl v0.6.1 [INFO] [stderr] Compiling glutin v0.7.2 [INFO] [stderr] Checking x11-dl v2.12.0 [INFO] [stderr] Compiling phf_shared v0.7.21 [INFO] [stderr] Checking specs v0.7.1 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf v0.7.21 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Compiling wayland-client v0.7.6 [INFO] [stderr] Checking pistoncore-window v0.24.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking pistoncore-event_loop v0.27.0 [INFO] [stderr] Checking image v0.12.1 [INFO] [stderr] Checking piston v0.27.0 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Compiling serde_json v0.8.6 [INFO] [stderr] Checking piston2d-opengl_graphics v0.37.0 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.6 [INFO] [stderr] Checking wayland-window v0.4.3 [INFO] [stderr] Checking wayland-kbd v0.6.2 [INFO] [stderr] Checking winit v0.5.8 [INFO] [stderr] Checking pistoncore-glutin_window v0.33.0 [INFO] [stderr] Checking piston_playground v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | planner: planner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `planner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | planner: planner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `planner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::window::WindowSettings` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use piston::window::WindowSettings; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::event_loop::*` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use piston::event_loop::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::input::*` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use piston::input::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::window::AdvancedWindow` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use piston::window::AdvancedWindow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `glutin_window::GlutinWindow as Window` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use glutin_window::GlutinWindow as Window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/app.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | let mut window: GlutinWindow = WindowSettings::new( [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/component/transform.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new() -> Transform { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | x: (width/2) as f64, y: (height/2) as f64, scale_x: 1.0, scale_y: 0.5, rotation: 0.0, pivot_x: 25.0, pivot_y: 25.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(width/2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:39:41 [INFO] [stderr] | [INFO] [stderr] 39 | x: (width/2) as f64, y: (height/2) as f64, scale_x: 1.0, scale_y: 0.5, rotation: 0.0, pivot_x: 25.0, pivot_y: 25.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(height/2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:118:36 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::window::WindowSettings` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use piston::window::WindowSettings; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::event_loop::*` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use piston::event_loop::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::input::*` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use piston::input::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::window::AdvancedWindow` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use piston::window::AdvancedWindow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `glutin_window::GlutinWindow as Window` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use glutin_window::GlutinWindow as Window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/app.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | let mut window: GlutinWindow = WindowSettings::new( [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/component/transform.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new() -> Transform { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | x: (width/2) as f64, y: (height/2) as f64, scale_x: 1.0, scale_y: 0.5, rotation: 0.0, pivot_x: 25.0, pivot_y: 25.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(width/2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:39:41 [INFO] [stderr] | [INFO] [stderr] 39 | x: (width/2) as f64, y: (height/2) as f64, scale_x: 1.0, scale_y: 0.5, rotation: 0.0, pivot_x: 25.0, pivot_y: 25.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(height/2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:118:36 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 41.93s [INFO] running `"docker" "inspect" "42f8e46e99ef8b0ff73e291999dedebb068f28dff8e469f9576f374f8965018d"` [INFO] running `"docker" "rm" "-f" "42f8e46e99ef8b0ff73e291999dedebb068f28dff8e469f9576f374f8965018d"` [INFO] [stdout] 42f8e46e99ef8b0ff73e291999dedebb068f28dff8e469f9576f374f8965018d