[INFO] updating cached repository hcpl/coreutils-date [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hcpl/coreutils-date [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hcpl/coreutils-date" "work/ex/clippy-test-run/sources/stable/gh/hcpl/coreutils-date"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hcpl/coreutils-date'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hcpl/coreutils-date" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hcpl/coreutils-date"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hcpl/coreutils-date'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 719fc1b298bf5ad635af0304bb8f94d4afde67fb [INFO] sha for GitHub repo hcpl/coreutils-date: 719fc1b298bf5ad635af0304bb8f94d4afde67fb [INFO] validating manifest of hcpl/coreutils-date on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hcpl/coreutils-date on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hcpl/coreutils-date [INFO] finished frobbing hcpl/coreutils-date [INFO] frobbed toml for hcpl/coreutils-date written to work/ex/clippy-test-run/sources/stable/gh/hcpl/coreutils-date/Cargo.toml [INFO] started frobbing hcpl/coreutils-date [INFO] finished frobbing hcpl/coreutils-date [INFO] frobbed toml for hcpl/coreutils-date written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hcpl/coreutils-date/Cargo.toml [INFO] crate hcpl/coreutils-date has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hcpl/coreutils-date against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hcpl/coreutils-date:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 454c251f762e583e2153a5616ae6ae089e1ba465b87f2d9c9d616abd77fb435f [INFO] running `"docker" "start" "-a" "454c251f762e583e2153a5616ae6ae089e1ba465b87f2d9c9d616abd77fb435f"` [INFO] [stderr] Compiling gcc v0.3.49 [INFO] [stderr] Checking nom v3.0.0 [INFO] [stderr] Checking errno v0.2.3 [INFO] [stderr] Compiling backtrace-sys v0.1.11 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking date v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> date.rs:334:9 [INFO] [stderr] | [INFO] [stderr] 334 | utc: utc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `utc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> date.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> date.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | date_source: date_source, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `date_source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> date.rs:337:9 [INFO] [stderr] | [INFO] [stderr] 337 | set_to: set_to, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `set_to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> date.rs:334:9 [INFO] [stderr] | [INFO] [stderr] 334 | utc: utc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `utc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> date.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> date.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | date_source: date_source, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `date_source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> date.rs:337:9 [INFO] [stderr] | [INFO] [stderr] 337 | set_to: set_to, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `set_to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> date.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | const DATE: &'static str = "date"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> date.rs:38:15 [INFO] [stderr] | [INFO] [stderr] 38 | const HOURS: &'static str = "hours"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> date.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | const MINUTES: &'static str = "minutes"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> date.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | const SECONDS: &'static str = "seconds"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> date.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | const NS: &'static str = "ns"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> date.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | const DATE: &'static str = "date"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> date.rs:38:15 [INFO] [stderr] | [INFO] [stderr] 38 | const HOURS: &'static str = "hours"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> date.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | const MINUTES: &'static str = "minutes"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> date.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | const SECONDS: &'static str = "seconds"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> date.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | const NS: &'static str = "ns"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> date.rs:283:35 [INFO] [stderr] | [INFO] [stderr] 283 | .validator(|fmt| match fmt.starts_with('+') { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 284 | | true => Ok(()), [INFO] [stderr] 285 | | false => Err("Date formats must start with a '+' character".to_owned()), [INFO] [stderr] 286 | | })) [INFO] [stderr] | |__________________^ help: consider using an if/else expression: `if fmt.starts_with('+') { Ok(()) } else { Err("Date formats must start with a '+' character".to_owned()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> date.rs:376:38 [INFO] [stderr] | [INFO] [stderr] 376 | .with_second(second).ok_or(errors::ErrorKind::ParseSecond(second))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| errors::ErrorKind::ParseSecond(second))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> date.rs:375:34 [INFO] [stderr] | [INFO] [stderr] 375 | .with_year(year).ok_or(errors::ErrorKind::ParseYear(year))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| errors::ErrorKind::ParseYear(year))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> date.rs:374:38 [INFO] [stderr] | [INFO] [stderr] 374 | .with_minute(minute).ok_or(errors::ErrorKind::ParseMinute(minute))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| errors::ErrorKind::ParseMinute(minute))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> date.rs:373:34 [INFO] [stderr] | [INFO] [stderr] 373 | .with_hour(hour).ok_or(errors::ErrorKind::ParseHour(hour))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| errors::ErrorKind::ParseHour(hour))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> date.rs:372:32 [INFO] [stderr] | [INFO] [stderr] 372 | .with_day(day).ok_or(errors::ErrorKind::ParseDay(day))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| errors::ErrorKind::ParseDay(day))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> date.rs:371:36 [INFO] [stderr] | [INFO] [stderr] 371 | .with_month(month).ok_or(errors::ErrorKind::ParseMonth(month))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| errors::ErrorKind::ParseMonth(month))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> date.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | tv_nsec: date_time.timestamp_subsec_nanos() as c_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(date_time.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> date.rs:466:5 [INFO] [stderr] | [INFO] [stderr] 466 | / match format { [INFO] [stderr] 467 | | &Format::Iso8601(ref fmt) => { [INFO] [stderr] 468 | | match fmt { [INFO] [stderr] 469 | | &Iso8601Format::Date => "%F", [INFO] [stderr] ... | [INFO] [stderr] 485 | | &Format::Default => "%a %b %e %T %Z %Y", [INFO] [stderr] 486 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 466 | match *format { [INFO] [stderr] 467 | Format::Iso8601(ref fmt) => { [INFO] [stderr] 468 | match fmt { [INFO] [stderr] 469 | &Iso8601Format::Date => "%F", [INFO] [stderr] 470 | &Iso8601Format::Hours => "%FT%H%:z", [INFO] [stderr] 471 | &Iso8601Format::Minutes => "%FT%H:%M%:z", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> date.rs:468:13 [INFO] [stderr] | [INFO] [stderr] 468 | / match fmt { [INFO] [stderr] 469 | | &Iso8601Format::Date => "%F", [INFO] [stderr] 470 | | &Iso8601Format::Hours => "%FT%H%:z", [INFO] [stderr] 471 | | &Iso8601Format::Minutes => "%FT%H:%M%:z", [INFO] [stderr] 472 | | &Iso8601Format::Seconds => "%FT%T%:z", [INFO] [stderr] 473 | | &Iso8601Format::Ns => "%FT%T,%f%:z", [INFO] [stderr] 474 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 468 | match *fmt { [INFO] [stderr] 469 | Iso8601Format::Date => "%F", [INFO] [stderr] 470 | Iso8601Format::Hours => "%FT%H%:z", [INFO] [stderr] 471 | Iso8601Format::Minutes => "%FT%H:%M%:z", [INFO] [stderr] 472 | Iso8601Format::Seconds => "%FT%T%:z", [INFO] [stderr] 473 | Iso8601Format::Ns => "%FT%T,%f%:z", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> date.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | / match fmt { [INFO] [stderr] 479 | | &Rfc3339Format::Date => "%F", [INFO] [stderr] 480 | | &Rfc3339Format::Seconds => "%F %T%:z", [INFO] [stderr] 481 | | &Rfc3339Format::Ns => "%F %T.%f%:z", [INFO] [stderr] 482 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 478 | match *fmt { [INFO] [stderr] 479 | Rfc3339Format::Date => "%F", [INFO] [stderr] 480 | Rfc3339Format::Seconds => "%F %T%:z", [INFO] [stderr] 481 | Rfc3339Format::Ns => "%F %T.%f%:z", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> date.rs:283:35 [INFO] [stderr] | [INFO] [stderr] 283 | .validator(|fmt| match fmt.starts_with('+') { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 284 | | true => Ok(()), [INFO] [stderr] 285 | | false => Err("Date formats must start with a '+' character".to_owned()), [INFO] [stderr] 286 | | })) [INFO] [stderr] | |__________________^ help: consider using an if/else expression: `if fmt.starts_with('+') { Ok(()) } else { Err("Date formats must start with a '+' character".to_owned()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> date.rs:376:38 [INFO] [stderr] | [INFO] [stderr] 376 | .with_second(second).ok_or(errors::ErrorKind::ParseSecond(second))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| errors::ErrorKind::ParseSecond(second))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> date.rs:375:34 [INFO] [stderr] | [INFO] [stderr] 375 | .with_year(year).ok_or(errors::ErrorKind::ParseYear(year))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| errors::ErrorKind::ParseYear(year))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> date.rs:374:38 [INFO] [stderr] | [INFO] [stderr] 374 | .with_minute(minute).ok_or(errors::ErrorKind::ParseMinute(minute))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| errors::ErrorKind::ParseMinute(minute))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> date.rs:373:34 [INFO] [stderr] | [INFO] [stderr] 373 | .with_hour(hour).ok_or(errors::ErrorKind::ParseHour(hour))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| errors::ErrorKind::ParseHour(hour))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> date.rs:372:32 [INFO] [stderr] | [INFO] [stderr] 372 | .with_day(day).ok_or(errors::ErrorKind::ParseDay(day))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| errors::ErrorKind::ParseDay(day))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> date.rs:371:36 [INFO] [stderr] | [INFO] [stderr] 371 | .with_month(month).ok_or(errors::ErrorKind::ParseMonth(month))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| errors::ErrorKind::ParseMonth(month))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> date.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | tv_nsec: date_time.timestamp_subsec_nanos() as c_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(date_time.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> date.rs:466:5 [INFO] [stderr] | [INFO] [stderr] 466 | / match format { [INFO] [stderr] 467 | | &Format::Iso8601(ref fmt) => { [INFO] [stderr] 468 | | match fmt { [INFO] [stderr] 469 | | &Iso8601Format::Date => "%F", [INFO] [stderr] ... | [INFO] [stderr] 485 | | &Format::Default => "%a %b %e %T %Z %Y", [INFO] [stderr] 486 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 466 | match *format { [INFO] [stderr] 467 | Format::Iso8601(ref fmt) => { [INFO] [stderr] 468 | match fmt { [INFO] [stderr] 469 | &Iso8601Format::Date => "%F", [INFO] [stderr] 470 | &Iso8601Format::Hours => "%FT%H%:z", [INFO] [stderr] 471 | &Iso8601Format::Minutes => "%FT%H:%M%:z", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> date.rs:468:13 [INFO] [stderr] | [INFO] [stderr] 468 | / match fmt { [INFO] [stderr] 469 | | &Iso8601Format::Date => "%F", [INFO] [stderr] 470 | | &Iso8601Format::Hours => "%FT%H%:z", [INFO] [stderr] 471 | | &Iso8601Format::Minutes => "%FT%H:%M%:z", [INFO] [stderr] 472 | | &Iso8601Format::Seconds => "%FT%T%:z", [INFO] [stderr] 473 | | &Iso8601Format::Ns => "%FT%T,%f%:z", [INFO] [stderr] 474 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 468 | match *fmt { [INFO] [stderr] 469 | Iso8601Format::Date => "%F", [INFO] [stderr] 470 | Iso8601Format::Hours => "%FT%H%:z", [INFO] [stderr] 471 | Iso8601Format::Minutes => "%FT%H:%M%:z", [INFO] [stderr] 472 | Iso8601Format::Seconds => "%FT%T%:z", [INFO] [stderr] 473 | Iso8601Format::Ns => "%FT%T,%f%:z", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> date.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | / match fmt { [INFO] [stderr] 479 | | &Rfc3339Format::Date => "%F", [INFO] [stderr] 480 | | &Rfc3339Format::Seconds => "%F %T%:z", [INFO] [stderr] 481 | | &Rfc3339Format::Ns => "%F %T.%f%:z", [INFO] [stderr] 482 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 478 | match *fmt { [INFO] [stderr] 479 | Rfc3339Format::Date => "%F", [INFO] [stderr] 480 | Rfc3339Format::Seconds => "%F %T%:z", [INFO] [stderr] 481 | Rfc3339Format::Ns => "%F %T.%f%:z", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.58s [INFO] running `"docker" "inspect" "454c251f762e583e2153a5616ae6ae089e1ba465b87f2d9c9d616abd77fb435f"` [INFO] running `"docker" "rm" "-f" "454c251f762e583e2153a5616ae6ae089e1ba465b87f2d9c9d616abd77fb435f"` [INFO] [stdout] 454c251f762e583e2153a5616ae6ae089e1ba465b87f2d9c9d616abd77fb435f