[INFO] updating cached repository hayatoito/icfp2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hayatoito/icfp2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hayatoito/icfp2018" "work/ex/clippy-test-run/sources/stable/gh/hayatoito/icfp2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hayatoito/icfp2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hayatoito/icfp2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hayatoito/icfp2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hayatoito/icfp2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 41868fd3290bd7f7bebfd2ff65688152f7aafb1d [INFO] sha for GitHub repo hayatoito/icfp2018: 41868fd3290bd7f7bebfd2ff65688152f7aafb1d [INFO] validating manifest of hayatoito/icfp2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hayatoito/icfp2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hayatoito/icfp2018 [INFO] finished frobbing hayatoito/icfp2018 [INFO] frobbed toml for hayatoito/icfp2018 written to work/ex/clippy-test-run/sources/stable/gh/hayatoito/icfp2018/Cargo.toml [INFO] started frobbing hayatoito/icfp2018 [INFO] finished frobbing hayatoito/icfp2018 [INFO] frobbed toml for hayatoito/icfp2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hayatoito/icfp2018/Cargo.toml [INFO] crate hayatoito/icfp2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hayatoito/icfp2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hayatoito/icfp2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 760530186f021af2f10ca97bcfc5663def5daca5c0e82cc5e1c9fb6cdaeab1a5 [INFO] running `"docker" "start" "-a" "760530186f021af2f10ca97bcfc5663def5daca5c0e82cc5e1c9fb6cdaeab1a5"` [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking loggerv v0.7.1 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking icfp2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:193:18 [INFO] [stderr] | [INFO] [stderr] 193 | vec![0b_00010100, 0b_00011011] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_digit_groups)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:193:31 [INFO] [stderr] | [INFO] [stderr] 193 | vec![0b_00010100, 0b_00011011] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0001_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:197:18 [INFO] [stderr] | [INFO] [stderr] 197 | vec![0b_00110100, 0b_00001011] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0011_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:197:31 [INFO] [stderr] | [INFO] [stderr] 197 | vec![0b_00110100, 0b_00001011] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0000_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | vec![0b_10011100, 0b_00001000] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:205:31 [INFO] [stderr] | [INFO] [stderr] 205 | vec![0b_10011100, 0b_00001000] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:212:18 [INFO] [stderr] | [INFO] [stderr] 212 | vec![0b_11101100, 0b_01110011] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:212:31 [INFO] [stderr] | [INFO] [stderr] 212 | vec![0b_11101100, 0b_01110011] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0111_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:217:18 [INFO] [stderr] | [INFO] [stderr] 217 | vec![0b_01110101, 0b_00000101] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0111_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:217:31 [INFO] [stderr] | [INFO] [stderr] 217 | vec![0b_01110101, 0b_00000101] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0000_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:222:18 [INFO] [stderr] | [INFO] [stderr] 222 | vec![0b_00111111] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:227:18 [INFO] [stderr] | [INFO] [stderr] 227 | vec![0b_10011110] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1001_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:232:18 [INFO] [stderr] | [INFO] [stderr] 232 | vec![0b_01010011] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0101_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/nanobot/bot.rs:237:18 [INFO] [stderr] | [INFO] [stderr] 237 | vec![0b_10111010] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1011_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nanobot/run.rs:201:41 [INFO] [stderr] | [INFO] [stderr] 201 | let expected_energy = [(1, 955, 11522830)]; [INFO] [stderr] | ^^^^^^^^ help: consider: `11_522_830` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nanobot/run.rs:212:41 [INFO] [stderr] | [INFO] [stderr] 212 | let expected_energy = [(1, 913, 11029332)]; [INFO] [stderr] | ^^^^^^^^ help: consider: `11_029_332` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/nanobot/bot.rs:152:24 [INFO] [stderr] | [INFO] [stderr] 152 | self.seeds[1..(m + 1)].to_vec(), [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/nanobot/prelude.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / self.dx != 0 && self.dy == 0 && self.dz == 0 [INFO] [stderr] 90 | | || self.dx == 0 && self.dy != 0 && self.dz == 0 [INFO] [stderr] 91 | | || self.dx == 0 && self.dy == 0 && self.dz != 0 [INFO] [stderr] | |___________________________________________________________^ help: try: `self.dx != 0 && self.dy == 0 && self.dz == 0 || self.dx == 0 && self.dy != 0 && self.dz == 0 || self.dx == 0 && self.dy == 0 && self.dz != 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/nanobot/bot.rs:152:24 [INFO] [stderr] | [INFO] [stderr] 152 | self.seeds[1..(m + 1)].to_vec(), [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/nanobot/prelude.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / self.dx != 0 && self.dy == 0 && self.dz == 0 [INFO] [stderr] 90 | | || self.dx == 0 && self.dy != 0 && self.dz == 0 [INFO] [stderr] 91 | | || self.dx == 0 && self.dy == 0 && self.dz != 0 [INFO] [stderr] | |___________________________________________________________^ help: try: `self.dx != 0 && self.dy == 0 && self.dz == 0 || self.dx == 0 && self.dy != 0 && self.dz == 0 || self.dx == 0 && self.dy == 0 && self.dz != 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/nanobot/system.rs:130:30 [INFO] [stderr] | [INFO] [stderr] 130 | for cmd in cmds[1..].into_iter().cloned() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/nanobot/system.rs:162:30 [INFO] [stderr] | [INFO] [stderr] 162 | for cmd in cmds[1..].into_iter().cloned() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/nanobot/system.rs:130:30 [INFO] [stderr] | [INFO] [stderr] 130 | for cmd in cmds[1..].into_iter().cloned() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/nanobot/system.rs:162:30 [INFO] [stderr] | [INFO] [stderr] 162 | for cmd in cmds[1..].into_iter().cloned() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.57s [INFO] running `"docker" "inspect" "760530186f021af2f10ca97bcfc5663def5daca5c0e82cc5e1c9fb6cdaeab1a5"` [INFO] running `"docker" "rm" "-f" "760530186f021af2f10ca97bcfc5663def5daca5c0e82cc5e1c9fb6cdaeab1a5"` [INFO] [stdout] 760530186f021af2f10ca97bcfc5663def5daca5c0e82cc5e1c9fb6cdaeab1a5