[INFO] updating cached repository hawkBaby/rustyGlyph [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hawkBaby/rustyGlyph [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hawkBaby/rustyGlyph" "work/ex/clippy-test-run/sources/stable/gh/hawkBaby/rustyGlyph"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hawkBaby/rustyGlyph'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hawkBaby/rustyGlyph" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hawkBaby/rustyGlyph"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hawkBaby/rustyGlyph'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a4312ae0aa23526d852617ffd21858514a3ba9ba [INFO] sha for GitHub repo hawkBaby/rustyGlyph: a4312ae0aa23526d852617ffd21858514a3ba9ba [INFO] validating manifest of hawkBaby/rustyGlyph on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hawkBaby/rustyGlyph on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hawkBaby/rustyGlyph [INFO] finished frobbing hawkBaby/rustyGlyph [INFO] frobbed toml for hawkBaby/rustyGlyph written to work/ex/clippy-test-run/sources/stable/gh/hawkBaby/rustyGlyph/Cargo.toml [INFO] started frobbing hawkBaby/rustyGlyph [INFO] finished frobbing hawkBaby/rustyGlyph [INFO] frobbed toml for hawkBaby/rustyGlyph written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hawkBaby/rustyGlyph/Cargo.toml [INFO] crate hawkBaby/rustyGlyph has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hawkBaby/rustyGlyph against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hawkBaby/rustyGlyph:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a01189079ced2f50325420b13e7ecb5bcc925bfbe4805e96ddc54f65139e781 [INFO] running `"docker" "start" "-a" "9a01189079ced2f50325420b13e7ecb5bcc925bfbe4805e96ddc54f65139e781"` [INFO] [stderr] Compiling syn v0.15.12 [INFO] [stderr] Checking nalgebra v0.16.5 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking rustglyph v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `rustGlyph::rust_glyph::*` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use rustGlyph::rust_glyph::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/main.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | let matches = App::from_yaml(config_yaml).get_matches(); [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `rustGlyph::rust_glyph::*` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use rustGlyph::rust_glyph::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `opt_anaglyph_gen` [INFO] [stderr] --> src/rustGlyph.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn opt_anaglyph_gen(li_p:&image::Rgb, ri_p:&image::Rgb) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `rust_loop` [INFO] [stderr] --> src/rustGlyph.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn rust_loop() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module `rustGlyph` should have a snake case name such as `rust_glyph` [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod rustGlyph; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rustGlyph.rs:16:34 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn opt_anaglyph_gen(li_p:&image::Rgb, ri_p:&image::Rgb) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `image::Rgb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rustGlyph.rs:16:56 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn opt_anaglyph_gen(li_p:&image::Rgb, ri_p:&image::Rgb) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `image::Rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rustGlyph.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | let _l_vec = li_p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*li_p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rustGlyph.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | let _r_vec = ri_p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*ri_p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustGlyph.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | let vec_lef = Matrix3x1::new(_l_vec[0] as f32,_l_vec[1] as f32 ,_l_vec[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(_l_vec[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustGlyph.rs:20:55 [INFO] [stderr] | [INFO] [stderr] 20 | let vec_lef = Matrix3x1::new(_l_vec[0] as f32,_l_vec[1] as f32 ,_l_vec[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(_l_vec[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustGlyph.rs:20:73 [INFO] [stderr] | [INFO] [stderr] 20 | let vec_lef = Matrix3x1::new(_l_vec[0] as f32,_l_vec[1] as f32 ,_l_vec[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(_l_vec[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustGlyph.rs:21:38 [INFO] [stderr] | [INFO] [stderr] 21 | let vec_rig = Matrix3x1::new(_r_vec[0] as f32,_r_vec[1] as f32 ,_r_vec[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(_r_vec[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustGlyph.rs:21:55 [INFO] [stderr] | [INFO] [stderr] 21 | let vec_rig = Matrix3x1::new(_r_vec[0] as f32,_r_vec[1] as f32 ,_r_vec[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(_r_vec[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustGlyph.rs:21:73 [INFO] [stderr] | [INFO] [stderr] 21 | let vec_rig = Matrix3x1::new(_r_vec[0] as f32,_r_vec[1] as f32 ,_r_vec[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(_r_vec[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rustGlyph.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | let _h_ = height.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/main.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | let matches = App::from_yaml(config_yaml).get_matches(); [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `opt_anaglyph_gen` [INFO] [stderr] --> src/rustGlyph.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn opt_anaglyph_gen(li_p:&image::Rgb, ri_p:&image::Rgb) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `rust_loop` [INFO] [stderr] --> src/rustGlyph.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn rust_loop() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module `rustGlyph` should have a snake case name such as `rust_glyph` [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod rustGlyph; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rustGlyph.rs:16:34 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn opt_anaglyph_gen(li_p:&image::Rgb, ri_p:&image::Rgb) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `image::Rgb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rustGlyph.rs:16:56 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn opt_anaglyph_gen(li_p:&image::Rgb, ri_p:&image::Rgb) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `image::Rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rustGlyph.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | let _l_vec = li_p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*li_p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rustGlyph.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | let _r_vec = ri_p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*ri_p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustGlyph.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | let vec_lef = Matrix3x1::new(_l_vec[0] as f32,_l_vec[1] as f32 ,_l_vec[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(_l_vec[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustGlyph.rs:20:55 [INFO] [stderr] | [INFO] [stderr] 20 | let vec_lef = Matrix3x1::new(_l_vec[0] as f32,_l_vec[1] as f32 ,_l_vec[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(_l_vec[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustGlyph.rs:20:73 [INFO] [stderr] | [INFO] [stderr] 20 | let vec_lef = Matrix3x1::new(_l_vec[0] as f32,_l_vec[1] as f32 ,_l_vec[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(_l_vec[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustGlyph.rs:21:38 [INFO] [stderr] | [INFO] [stderr] 21 | let vec_rig = Matrix3x1::new(_r_vec[0] as f32,_r_vec[1] as f32 ,_r_vec[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(_r_vec[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustGlyph.rs:21:55 [INFO] [stderr] | [INFO] [stderr] 21 | let vec_rig = Matrix3x1::new(_r_vec[0] as f32,_r_vec[1] as f32 ,_r_vec[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(_r_vec[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustGlyph.rs:21:73 [INFO] [stderr] | [INFO] [stderr] 21 | let vec_rig = Matrix3x1::new(_r_vec[0] as f32,_r_vec[1] as f32 ,_r_vec[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(_r_vec[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rustGlyph.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | let _h_ = height.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.24s [INFO] running `"docker" "inspect" "9a01189079ced2f50325420b13e7ecb5bcc925bfbe4805e96ddc54f65139e781"` [INFO] running `"docker" "rm" "-f" "9a01189079ced2f50325420b13e7ecb5bcc925bfbe4805e96ddc54f65139e781"` [INFO] [stdout] 9a01189079ced2f50325420b13e7ecb5bcc925bfbe4805e96ddc54f65139e781