[INFO] updating cached repository haumea-lang/haumea-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/haumea-lang/haumea-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/haumea-lang/haumea-rs" "work/ex/clippy-test-run/sources/stable/gh/haumea-lang/haumea-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/haumea-lang/haumea-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/haumea-lang/haumea-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/haumea-lang/haumea-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/haumea-lang/haumea-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b50ebe11ad0ec2e2b702016790b48c09c3950761 [INFO] sha for GitHub repo haumea-lang/haumea-rs: b50ebe11ad0ec2e2b702016790b48c09c3950761 [INFO] validating manifest of haumea-lang/haumea-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of haumea-lang/haumea-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing haumea-lang/haumea-rs [INFO] finished frobbing haumea-lang/haumea-rs [INFO] frobbed toml for haumea-lang/haumea-rs written to work/ex/clippy-test-run/sources/stable/gh/haumea-lang/haumea-rs/Cargo.toml [INFO] started frobbing haumea-lang/haumea-rs [INFO] finished frobbing haumea-lang/haumea-rs [INFO] frobbed toml for haumea-lang/haumea-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/haumea-lang/haumea-rs/Cargo.toml [INFO] crate haumea-lang/haumea-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting haumea-lang/haumea-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/haumea-lang/haumea-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0adad5a4bc5caec410a1887be0debd6aee9d232adff02c3721ab5b755384b20e [INFO] running `"docker" "start" "-a" "0adad5a4bc5caec410a1887be0debd6aee9d232adff02c3721ab5b755384b20e"` [INFO] [stderr] Checking haumea v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | ScanState { line: line, column: column } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | ScanState { line: line, column: column } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | peek: peek, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `peek` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:208:16 [INFO] [stderr] | [INFO] [stderr] 208 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:209:16 [INFO] [stderr] | [INFO] [stderr] 209 | signature: signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:210:16 [INFO] [stderr] | [INFO] [stderr] 210 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:328:9 [INFO] [stderr] | [INFO] [stderr] 328 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | by: by, [INFO] [stderr] | ^^^^^^ help: replace it with: `by` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | cond: cond, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cond` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:372:9 [INFO] [stderr] | [INFO] [stderr] 372 | if_clause: if_clause, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `if_clause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | else_clause: else_clause, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `else_clause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen/c.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | ast: ast, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | ScanState { line: line, column: column } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | ScanState { line: line, column: column } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | peek: peek, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `peek` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:208:16 [INFO] [stderr] | [INFO] [stderr] 208 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:209:16 [INFO] [stderr] | [INFO] [stderr] 209 | signature: signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:210:16 [INFO] [stderr] | [INFO] [stderr] 210 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:328:9 [INFO] [stderr] | [INFO] [stderr] 328 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | by: by, [INFO] [stderr] | ^^^^^^ help: replace it with: `by` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | cond: cond, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cond` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:372:9 [INFO] [stderr] | [INFO] [stderr] 372 | if_clause: if_clause, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `if_clause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | else_clause: else_clause, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `else_clause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen/c.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | ast: ast, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:179:16 [INFO] [stderr] | [INFO] [stderr] 179 | fn match_token(mut token_stream: &mut Vec, expected: &Token) -> Result { [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:339:18 [INFO] [stderr] | [INFO] [stderr] 339 | fn parse_declare(mut token_stream: &mut Vec) -> Statement { [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:179:16 [INFO] [stderr] | [INFO] [stderr] 179 | fn match_token(mut token_stream: &mut Vec, expected: &Token) -> Result { [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:339:18 [INFO] [stderr] | [INFO] [stderr] 339 | fn parse_declare(mut token_stream: &mut Vec) -> Statement { [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/parser.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / ForEach { [INFO] [stderr] 96 | | ident: Ident, [INFO] [stderr] 97 | | start: Expression, [INFO] [stderr] 98 | | end: Expression, [INFO] [stderr] ... | [INFO] [stderr] 101 | | body: Rc, [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/parser.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / ForEach { [INFO] [stderr] 96 | | ident: Ident, [INFO] [stderr] 97 | | start: Expression, [INFO] [stderr] 98 | | end: Expression, [INFO] [stderr] ... | [INFO] [stderr] 101 | | body: Rc, [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/parser.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / ForEach { [INFO] [stderr] 96 | | ident: Ident, [INFO] [stderr] 97 | | start: Expression, [INFO] [stderr] 98 | | end: Expression, [INFO] [stderr] ... | [INFO] [stderr] 101 | | body: Rc, [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/parser.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / ForEach { [INFO] [stderr] 96 | | ident: Ident, [INFO] [stderr] 97 | | start: Expression, [INFO] [stderr] 98 | | end: Expression, [INFO] [stderr] ... | [INFO] [stderr] 101 | | body: Rc, [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parser.rs:316:38 [INFO] [stderr] | [INFO] [stderr] 316 | Token::Keyword(ref kw, _) => kw == &"by", [INFO] [stderr] | ^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"by"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parser.rs:316:38 [INFO] [stderr] | [INFO] [stderr] 316 | Token::Keyword(ref kw, _) => kw == &"by", [INFO] [stderr] | ^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"by"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.68s [INFO] running `"docker" "inspect" "0adad5a4bc5caec410a1887be0debd6aee9d232adff02c3721ab5b755384b20e"` [INFO] running `"docker" "rm" "-f" "0adad5a4bc5caec410a1887be0debd6aee9d232adff02c3721ab5b755384b20e"` [INFO] [stdout] 0adad5a4bc5caec410a1887be0debd6aee9d232adff02c3721ab5b755384b20e