[INFO] updating cached repository hato-project/hato [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hato-project/hato [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hato-project/hato" "work/ex/clippy-test-run/sources/stable/gh/hato-project/hato"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hato-project/hato'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hato-project/hato" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hato-project/hato"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hato-project/hato'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 06d20a5ba12b8173aeb00e16b844aa42bb0ff28a [INFO] sha for GitHub repo hato-project/hato: 06d20a5ba12b8173aeb00e16b844aa42bb0ff28a [INFO] validating manifest of hato-project/hato on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hato-project/hato on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hato-project/hato [INFO] finished frobbing hato-project/hato [INFO] frobbed toml for hato-project/hato written to work/ex/clippy-test-run/sources/stable/gh/hato-project/hato/Cargo.toml [INFO] started frobbing hato-project/hato [INFO] finished frobbing hato-project/hato [INFO] frobbed toml for hato-project/hato written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hato-project/hato/Cargo.toml [INFO] crate hato-project/hato has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hato-project/hato against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hato-project/hato:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2fb7f0b28fdefa459c2bba5dc70b1f6d48ec2f186baa5e97e6bb9c753484e8d7 [INFO] running `"docker" "start" "-a" "2fb7f0b28fdefa459c2bba5dc70b1f6d48ec2f186baa5e97e6bb9c753484e8d7"` [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking listenfd v0.3.3 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Checking rand v0.6.1 [INFO] [stderr] Checking jsonwebtoken v5.0.1 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking diesel v1.3.3 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking trust-dns-resolver v0.10.0 [INFO] [stderr] Checking actix v0.7.7 [INFO] [stderr] Checking actix-net v0.2.4 [INFO] [stderr] Checking actix-web v0.7.14 [INFO] [stderr] Checking hato v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/agent/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/agent/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: cannot find type `NaiveDateTime` in this scope [INFO] [stderr] --> src/server/model/mod.rs:4:59 [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Queryable)] [INFO] [stderr] | ^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = note: #[warn(proc_macro_derive_resolution_fallback)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `NaiveDateTime` in this scope [INFO] [stderr] --> src/server/model/mod.rs:4:59 [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Queryable)] [INFO] [stderr] | ^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `Repo` in this scope [INFO] [stderr] --> src/server/model/mod.rs:4:59 [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Queryable)] [INFO] [stderr] | ^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `NaiveDateTime` in this scope [INFO] [stderr] --> src/server/model/mod.rs:4:59 [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Queryable)] [INFO] [stderr] | ^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = note: #[warn(proc_macro_derive_resolution_fallback)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `NaiveDateTime` in this scope [INFO] [stderr] --> src/server/model/mod.rs:4:59 [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Queryable)] [INFO] [stderr] | ^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `Repo` in this scope [INFO] [stderr] --> src/server/model/mod.rs:4:59 [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Queryable)] [INFO] [stderr] | ^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run_command` [INFO] [stderr] --> src/server/builder/docker.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn run_command() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_image` [INFO] [stderr] --> src/server/builder/docker.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn build_image(image_tagname: &String, _work_dir: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `push_image` [INFO] [stderr] --> src/server/builder/docker.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn push_image(image_tagname: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `APIError` [INFO] [stderr] --> src/server/errors.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | enum APIError { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server/api/webhook.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | create_dir(&work_dir); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/builder/common.rs:4:29 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn create_dir(dir_path: &String) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/builder/docker.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn build_image(image_tagname: &String, _work_dir: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/builder/docker.rs:19:55 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn build_image(image_tagname: &String, _work_dir: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/builder/docker.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn push_image(image_tagname: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/builder/git.rs:3:29 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn clone_repo(repo_url: &String, work_dir: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/builder/git.rs:3:48 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn clone_repo(repo_url: &String, work_dir: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run_command` [INFO] [stderr] --> src/server/builder/docker.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn run_command() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_image` [INFO] [stderr] --> src/server/builder/docker.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn build_image(image_tagname: &String, _work_dir: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `push_image` [INFO] [stderr] --> src/server/builder/docker.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn push_image(image_tagname: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `APIError` [INFO] [stderr] --> src/server/errors.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | enum APIError { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server/api/webhook.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | create_dir(&work_dir); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/builder/common.rs:4:29 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn create_dir(dir_path: &String) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/builder/docker.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn build_image(image_tagname: &String, _work_dir: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/builder/docker.rs:19:55 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn build_image(image_tagname: &String, _work_dir: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/builder/docker.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn push_image(image_tagname: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/builder/git.rs:3:29 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn clone_repo(repo_url: &String, work_dir: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/builder/git.rs:3:48 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn clone_repo(repo_url: &String, work_dir: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `"docker" "inspect" "2fb7f0b28fdefa459c2bba5dc70b1f6d48ec2f186baa5e97e6bb9c753484e8d7"` [INFO] running `"docker" "rm" "-f" "2fb7f0b28fdefa459c2bba5dc70b1f6d48ec2f186baa5e97e6bb9c753484e8d7"` [INFO] [stdout] 2fb7f0b28fdefa459c2bba5dc70b1f6d48ec2f186baa5e97e6bb9c753484e8d7