[INFO] updating cached repository haskelladdict/st
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/haskelladdict/st
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/haskelladdict/st" "work/ex/clippy-test-run/sources/stable/gh/haskelladdict/st"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/haskelladdict/st'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/haskelladdict/st" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/haskelladdict/st"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/haskelladdict/st'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 42e6c34145354a7ee38495784d94978564cdbb90
[INFO] sha for GitHub repo haskelladdict/st: 42e6c34145354a7ee38495784d94978564cdbb90
[INFO] validating manifest of haskelladdict/st on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of haskelladdict/st on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing haskelladdict/st
[INFO] finished frobbing haskelladdict/st
[INFO] frobbed toml for haskelladdict/st written to work/ex/clippy-test-run/sources/stable/gh/haskelladdict/st/Cargo.toml
[INFO] started frobbing haskelladdict/st
[INFO] finished frobbing haskelladdict/st
[INFO] frobbed toml for haskelladdict/st written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/haskelladdict/st/Cargo.toml
[INFO] crate haskelladdict/st has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting haskelladdict/st against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/haskelladdict/st:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7370a4c62c0101660ee44db8f9452ddc5ff3b4c13cc4b35e003a72c0d01d230e
[INFO] running `"docker" "start" "-a" "7370a4c62c0101660ee44db8f9452ddc5ff3b4c13cc4b35e003a72c0d01d230e"`
[INFO] [stderr]     Checking st v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/stats.rs:85:12
[INFO] [stderr]    |
[INFO] [stderr] 85 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 86 | |       if item > self.med {
[INFO] [stderr] 87 | |         self.lg.push(item.neg());
[INFO] [stderr] 88 | |       } else if item < self.med {
[INFO] [stderr] ...  |
[INFO] [stderr] 96 | |       }
[INFO] [stderr] 97 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 85 |     } else if item > self.med {
[INFO] [stderr] 86 |   self.lg.push(item.neg());
[INFO] [stderr] 87 | } else if item < self.med {
[INFO] [stderr] 88 |   self.sm.push(item);
[INFO] [stderr] 89 | } else {
[INFO] [stderr] 90 |   if self.sm.len() <= self.lg.len() {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/stats.rs:90:14
[INFO] [stderr]    |
[INFO] [stderr] 90 |         } else {
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 91 | |         if self.sm.len() <= self.lg.len() {
[INFO] [stderr] 92 | |           self.sm.push(item);
[INFO] [stderr] 93 | |         } else {
[INFO] [stderr] 94 | |           self.lg.push(item.neg());
[INFO] [stderr] 95 | |         }
[INFO] [stderr] 96 | |       }
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 90 |       } else if self.sm.len() <= self.lg.len() {
[INFO] [stderr] 91 |   self.sm.push(item);
[INFO] [stderr] 92 | } else {
[INFO] [stderr] 93 |   self.lg.push(item.neg());
[INFO] [stderr] 94 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/stats.rs:85:12
[INFO] [stderr]    |
[INFO] [stderr] 85 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 86 | |       if item > self.med {
[INFO] [stderr] 87 | |         self.lg.push(item.neg());
[INFO] [stderr] 88 | |       } else if item < self.med {
[INFO] [stderr] ...  |
[INFO] [stderr] 96 | |       }
[INFO] [stderr] 97 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 85 |     } else if item > self.med {
[INFO] [stderr] 86 |   self.lg.push(item.neg());
[INFO] [stderr] 87 | } else if item < self.med {
[INFO] [stderr] 88 |   self.sm.push(item);
[INFO] [stderr] 89 | } else {
[INFO] [stderr] 90 |   if self.sm.len() <= self.lg.len() {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/stats.rs:90:14
[INFO] [stderr]    |
[INFO] [stderr] 90 |         } else {
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 91 | |         if self.sm.len() <= self.lg.len() {
[INFO] [stderr] 92 | |           self.sm.push(item);
[INFO] [stderr] 93 | |         } else {
[INFO] [stderr] 94 | |           self.lg.push(item.neg());
[INFO] [stderr] 95 | |         }
[INFO] [stderr] 96 | |       }
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 90 |       } else if self.sm.len() <= self.lg.len() {
[INFO] [stderr] 91 |   self.sm.push(item);
[INFO] [stderr] 92 | } else {
[INFO] [stderr] 93 |   self.lg.push(item.neg());
[INFO] [stderr] 94 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/stats.rs:24:10
[INFO] [stderr]    |
[INFO] [stderr] 24 |   fn neg(&self) -> FloatVal {
[INFO] [stderr]    |          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/stats.rs:65:8
[INFO] [stderr]    |
[INFO] [stderr] 65 |     if self.sm.len() == 0 && self.lg.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.sm.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/stats.rs:65:30
[INFO] [stderr]    |
[INFO] [stderr] 65 |     if self.sm.len() == 0 && self.lg.len() == 0 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.lg.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/stats.rs:68:15
[INFO] [stderr]    |
[INFO] [stderr] 68 |     } else if self.sm.len() == 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.sm.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/stats.rs:69:10
[INFO] [stderr]    |
[INFO] [stderr] 69 |       if &item.neg() < self.lg.peek().unwrap() {
[INFO] [stderr]    |          -----------^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |          |
[INFO] [stderr]    |          help: use the left value directly: `item.neg()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/stats.rs:76:15
[INFO] [stderr]    |
[INFO] [stderr] 76 |     } else if self.lg.len() == 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.lg.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/stats.rs:77:10
[INFO] [stderr]    |
[INFO] [stderr] 77 |       if &item < self.sm.peek().unwrap() {
[INFO] [stderr]    |          -----^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |          |
[INFO] [stderr]    |          help: use the left value directly: `item`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in out.enumerate()` or similar iterators
[INFO] [stderr]   --> src/main.rs:34:12
[INFO] [stderr]    |
[INFO] [stderr] 34 |   for o in out {
[INFO] [stderr]    |            ^^^
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/stats.rs:24:10
[INFO] [stderr]    |
[INFO] [stderr] 24 |   fn neg(&self) -> FloatVal {
[INFO] [stderr]    |          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/stats.rs:65:8
[INFO] [stderr]    |
[INFO] [stderr] 65 |     if self.sm.len() == 0 && self.lg.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.sm.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/stats.rs:65:30
[INFO] [stderr]    |
[INFO] [stderr] 65 |     if self.sm.len() == 0 && self.lg.len() == 0 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.lg.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/stats.rs:68:15
[INFO] [stderr]    |
[INFO] [stderr] 68 |     } else if self.sm.len() == 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.sm.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/stats.rs:69:10
[INFO] [stderr]    |
[INFO] [stderr] 69 |       if &item.neg() < self.lg.peek().unwrap() {
[INFO] [stderr]    |          -----------^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |          |
[INFO] [stderr]    |          help: use the left value directly: `item.neg()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/stats.rs:76:15
[INFO] [stderr]    |
[INFO] [stderr] 76 |     } else if self.lg.len() == 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.lg.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/stats.rs:77:10
[INFO] [stderr]    |
[INFO] [stderr] 77 |       if &item < self.sm.peek().unwrap() {
[INFO] [stderr]    |          -----^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |          |
[INFO] [stderr]    |          help: use the left value directly: `item`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:60:36
[INFO] [stderr]    |
[INFO] [stderr] 60 |   let tokens : Vec<&str> = s.split(" ").collect();
[INFO] [stderr]    |                                    ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:74:41
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let tokens : Vec<&str> = line.split(" ").collect();
[INFO] [stderr]    |                                         ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in out.enumerate()` or similar iterators
[INFO] [stderr]   --> src/main.rs:34:12
[INFO] [stderr]    |
[INFO] [stderr] 34 |   for o in out {
[INFO] [stderr]    |            ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:60:36
[INFO] [stderr]    |
[INFO] [stderr] 60 |   let tokens : Vec<&str> = s.split(" ").collect();
[INFO] [stderr]    |                                    ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:74:41
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let tokens : Vec<&str> = line.split(" ").collect();
[INFO] [stderr]    |                                         ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.89s
[INFO] running `"docker" "inspect" "7370a4c62c0101660ee44db8f9452ddc5ff3b4c13cc4b35e003a72c0d01d230e"`
[INFO] running `"docker" "rm" "-f" "7370a4c62c0101660ee44db8f9452ddc5ff3b4c13cc4b35e003a72c0d01d230e"`
[INFO] [stdout] 7370a4c62c0101660ee44db8f9452ddc5ff3b4c13cc4b35e003a72c0d01d230e