[INFO] updating cached repository hashedhyphen/rust-twitter-cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hashedhyphen/rust-twitter-cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hashedhyphen/rust-twitter-cli" "work/ex/clippy-test-run/sources/stable/gh/hashedhyphen/rust-twitter-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hashedhyphen/rust-twitter-cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hashedhyphen/rust-twitter-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hashedhyphen/rust-twitter-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hashedhyphen/rust-twitter-cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2dd3cbbcffc665bd39356c616392c733654ce77d [INFO] sha for GitHub repo hashedhyphen/rust-twitter-cli: 2dd3cbbcffc665bd39356c616392c733654ce77d [INFO] validating manifest of hashedhyphen/rust-twitter-cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hashedhyphen/rust-twitter-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hashedhyphen/rust-twitter-cli [INFO] finished frobbing hashedhyphen/rust-twitter-cli [INFO] frobbed toml for hashedhyphen/rust-twitter-cli written to work/ex/clippy-test-run/sources/stable/gh/hashedhyphen/rust-twitter-cli/Cargo.toml [INFO] started frobbing hashedhyphen/rust-twitter-cli [INFO] finished frobbing hashedhyphen/rust-twitter-cli [INFO] frobbed toml for hashedhyphen/rust-twitter-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hashedhyphen/rust-twitter-cli/Cargo.toml [INFO] crate hashedhyphen/rust-twitter-cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hashedhyphen/rust-twitter-cli against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hashedhyphen/rust-twitter-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6f841c787b3a886d97b321a12a7642fa83fe6abd9c21d006349f9f4071f6c2ca [INFO] running `"docker" "start" "-a" "6f841c787b3a886d97b321a12a7642fa83fe6abd9c21d006349f9f4071f6c2ca"` [INFO] [stderr] Compiling openssl v0.9.16 [INFO] [stderr] Compiling openssl-sys v0.9.16 [INFO] [stderr] Checking futures-cpupool v0.1.5 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.2 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking twitter-cli v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/lib.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Write`, `self` [INFO] [stderr] --> src/lib.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | use std::io::{self, Write}; [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/lib.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Write`, `self` [INFO] [stderr] --> src/lib.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | use std::io::{self, Write}; [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Stream` [INFO] [stderr] --> src/lib.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | use futures::{Future, Stream}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v1` [INFO] [stderr] --> src/sign.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | params.sort_by(|&(k1, v1), &(k2, v2)| k1.cmp(k2)); [INFO] [stderr] | ^^ help: consider using `_v1` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v2` [INFO] [stderr] --> src/sign.rs:32:38 [INFO] [stderr] | [INFO] [stderr] 32 | params.sort_by(|&(k1, v1), &(k2, v2)| k1.cmp(k2)); [INFO] [stderr] | ^^ help: consider using `_v2` instead [INFO] [stderr] [INFO] [stderr] warning: unused import: `Stream` [INFO] [stderr] --> src/lib.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | use futures::{Future, Stream}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | let mut headers = request.headers_mut(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v1` [INFO] [stderr] --> src/sign.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | params.sort_by(|&(k1, v1), &(k2, v2)| k1.cmp(k2)); [INFO] [stderr] | ^^ help: consider using `_v1` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v2` [INFO] [stderr] --> src/sign.rs:32:38 [INFO] [stderr] | [INFO] [stderr] 32 | params.sort_by(|&(k1, v1), &(k2, v2)| k1.cmp(k2)); [INFO] [stderr] | ^^ help: consider using `_v2` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `query_encode` [INFO] [stderr] --> src/util.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | fn query_encode(input: &str) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sign.rs:11:51 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn build_signature(config: &Config, base_url: &String, params: &Params) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | let mut headers = request.headers_mut(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `query_encode` [INFO] [stderr] --> src/util.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | fn query_encode(input: &str) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sign.rs:11:51 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn build_signature(config: &Config, base_url: &String, params: &Params) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.10s [INFO] running `"docker" "inspect" "6f841c787b3a886d97b321a12a7642fa83fe6abd9c21d006349f9f4071f6c2ca"` [INFO] running `"docker" "rm" "-f" "6f841c787b3a886d97b321a12a7642fa83fe6abd9c21d006349f9f4071f6c2ca"` [INFO] [stdout] 6f841c787b3a886d97b321a12a7642fa83fe6abd9c21d006349f9f4071f6c2ca