[INFO] updating cached repository harshasrisri/dedup [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/harshasrisri/dedup [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/harshasrisri/dedup" "work/ex/clippy-test-run/sources/stable/gh/harshasrisri/dedup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/harshasrisri/dedup'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/harshasrisri/dedup" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/harshasrisri/dedup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/harshasrisri/dedup'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dafd1be73f8393d50df073f17537685a78bd49e1 [INFO] sha for GitHub repo harshasrisri/dedup: dafd1be73f8393d50df073f17537685a78bd49e1 [INFO] validating manifest of harshasrisri/dedup on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of harshasrisri/dedup on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing harshasrisri/dedup [INFO] finished frobbing harshasrisri/dedup [INFO] frobbed toml for harshasrisri/dedup written to work/ex/clippy-test-run/sources/stable/gh/harshasrisri/dedup/Cargo.toml [INFO] started frobbing harshasrisri/dedup [INFO] finished frobbing harshasrisri/dedup [INFO] frobbed toml for harshasrisri/dedup written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/harshasrisri/dedup/Cargo.toml [INFO] crate harshasrisri/dedup has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting harshasrisri/dedup against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/harshasrisri/dedup:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 340c84d8885fd0b8d82581f702836eb0be0ed96e937c8a6eca65813d532ecb17 [INFO] running `"docker" "start" "-a" "340c84d8885fd0b8d82581f702836eb0be0ed96e937c8a6eca65813d532ecb17"` [INFO] [stderr] Checking crossbeam-utils v0.6.1 [INFO] [stderr] Checking block-buffer v0.7.0 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking md-5 v0.8.0 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking ignore v0.4.4 [INFO] [stderr] Checking dedup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:48:8 [INFO] [stderr] | [INFO] [stderr] 48 | if filepath.is_dir() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `filepath.is_dir()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:52:33 [INFO] [stderr] | [INFO] [stderr] 52 | let chksum = md5(&filepath).expect(&format!("Error calculating MD5Sum of {}", &filepath.to_str().unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error calculating MD5Sum of {}", &filepath.to_str().unwrap()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:74:8 [INFO] [stderr] | [INFO] [stderr] 74 | if local.exists() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!local.exists()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:48:8 [INFO] [stderr] | [INFO] [stderr] 48 | if filepath.is_dir() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `filepath.is_dir()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:52:33 [INFO] [stderr] | [INFO] [stderr] 52 | let chksum = md5(&filepath).expect(&format!("Error calculating MD5Sum of {}", &filepath.to_str().unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error calculating MD5Sum of {}", &filepath.to_str().unwrap()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:74:8 [INFO] [stderr] | [INFO] [stderr] 74 | if local.exists() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!local.exists()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.77s [INFO] running `"docker" "inspect" "340c84d8885fd0b8d82581f702836eb0be0ed96e937c8a6eca65813d532ecb17"` [INFO] running `"docker" "rm" "-f" "340c84d8885fd0b8d82581f702836eb0be0ed96e937c8a6eca65813d532ecb17"` [INFO] [stdout] 340c84d8885fd0b8d82581f702836eb0be0ed96e937c8a6eca65813d532ecb17