[INFO] updating cached repository harikesh-kolekar/rust-execute-command [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/harikesh-kolekar/rust-execute-command [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/harikesh-kolekar/rust-execute-command" "work/ex/clippy-test-run/sources/stable/gh/harikesh-kolekar/rust-execute-command"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/harikesh-kolekar/rust-execute-command'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/harikesh-kolekar/rust-execute-command" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/harikesh-kolekar/rust-execute-command"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/harikesh-kolekar/rust-execute-command'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b0ed65b60450a8799f3813b172cfae98442c4d2e [INFO] sha for GitHub repo harikesh-kolekar/rust-execute-command: b0ed65b60450a8799f3813b172cfae98442c4d2e [INFO] validating manifest of harikesh-kolekar/rust-execute-command on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of harikesh-kolekar/rust-execute-command on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing harikesh-kolekar/rust-execute-command [INFO] finished frobbing harikesh-kolekar/rust-execute-command [INFO] frobbed toml for harikesh-kolekar/rust-execute-command written to work/ex/clippy-test-run/sources/stable/gh/harikesh-kolekar/rust-execute-command/Cargo.toml [INFO] started frobbing harikesh-kolekar/rust-execute-command [INFO] finished frobbing harikesh-kolekar/rust-execute-command [INFO] frobbed toml for harikesh-kolekar/rust-execute-command written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/harikesh-kolekar/rust-execute-command/Cargo.toml [INFO] crate harikesh-kolekar/rust-execute-command has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting harikesh-kolekar/rust-execute-command against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/harikesh-kolekar/rust-execute-command:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ff8d331f018a9da0516f2b1c1d744b9c5c089c97f852131277f8106d2c71a23e [INFO] running `"docker" "start" "-a" "ff8d331f018a9da0516f2b1c1d744b9c5c089c97f852131277f8106d2c71a23e"` [INFO] [stderr] Checking toml v0.4.2 [INFO] [stderr] Checking term-painter v0.2.3 [INFO] [stderr] Checking run v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:45:38 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(config) => println!("{}", ""), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:45:38 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(config) => println!("{}", ""), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/main.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(config) => println!("{}", ""), [INFO] [stderr] | ^^^^^^ help: consider using `_config` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:24:111 [INFO] [stderr] | [INFO] [stderr] 24 | let parts: Vec<&str> = "git clone ssh://hkolekar@chef@automate.chef.co:8989/chef/products/automate".split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | .ok_or("Command not found".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Command not found".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/main.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(config) => println!("{}", ""), [INFO] [stderr] | ^^^^^^ help: consider using `_config` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:24:111 [INFO] [stderr] | [INFO] [stderr] 24 | let parts: Vec<&str> = "git clone ssh://hkolekar@chef@automate.chef.co:8989/chef/products/automate".split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | .ok_or("Command not found".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Command not found".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.45s [INFO] running `"docker" "inspect" "ff8d331f018a9da0516f2b1c1d744b9c5c089c97f852131277f8106d2c71a23e"` [INFO] running `"docker" "rm" "-f" "ff8d331f018a9da0516f2b1c1d744b9c5c089c97f852131277f8106d2c71a23e"` [INFO] [stdout] ff8d331f018a9da0516f2b1c1d744b9c5c089c97f852131277f8106d2c71a23e