[INFO] updating cached repository harikb/aerate [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/harikb/aerate [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/harikb/aerate" "work/ex/clippy-test-run/sources/stable/gh/harikb/aerate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/harikb/aerate'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/harikb/aerate" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/harikb/aerate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/harikb/aerate'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0c0810f3cce6886e17c6ffcd60f6c4c342eb17ff [INFO] sha for GitHub repo harikb/aerate: 0c0810f3cce6886e17c6ffcd60f6c4c342eb17ff [INFO] validating manifest of harikb/aerate on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of harikb/aerate on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing harikb/aerate [INFO] finished frobbing harikb/aerate [INFO] frobbed toml for harikb/aerate written to work/ex/clippy-test-run/sources/stable/gh/harikb/aerate/Cargo.toml [INFO] started frobbing harikb/aerate [INFO] finished frobbing harikb/aerate [INFO] frobbed toml for harikb/aerate written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/harikb/aerate/Cargo.toml [INFO] crate harikb/aerate has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting harikb/aerate against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/harikb/aerate:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1783cc016b77fed164dc241ea5849dc84dd46c08cfee939953bf0dc1e169688e [INFO] running `"docker" "start" "-a" "1783cc016b77fed164dc241ea5849dc84dd46c08cfee939953bf0dc1e169688e"` [INFO] [stderr] Checking args v2.1.0 [INFO] [stderr] Checking clap v2.29.2 [INFO] [stderr] Checking aerate v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/checksum/common.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return Ok(file_checksums); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(file_checksums)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/checksum/common.rs:62:32 [INFO] [stderr] | [INFO] [stderr] 62 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 63 | | if ignore_errors { [INFO] [stderr] 64 | | break; [INFO] [stderr] 65 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 62 | } else if ignore_errors { [INFO] [stderr] 63 | break; [INFO] [stderr] 64 | } else { [INFO] [stderr] 65 | return Err(Error::new( [INFO] [stderr] 66 | ErrorKind::Interrupted, [INFO] [stderr] 67 | "Incomplete line in checksum file", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / return App::new("aerate") [INFO] [stderr] 9 | | .arg( [INFO] [stderr] 10 | | Arg::with_name("v") [INFO] [stderr] 11 | | .short("v") [INFO] [stderr] ... | [INFO] [stderr] 18 | | .setting(AppSettings::SubcommandRequired) [INFO] [stderr] 19 | | .get_matches(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 8 | App::new("aerate") [INFO] [stderr] 9 | .arg( [INFO] [stderr] 10 | Arg::with_name("v") [INFO] [stderr] 11 | .short("v") [INFO] [stderr] 12 | .multiple(true) [INFO] [stderr] 13 | .help("Sets the level of verbosity"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/checksum/common.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return Ok(file_checksums); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(file_checksums)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/checksum/common.rs:62:32 [INFO] [stderr] | [INFO] [stderr] 62 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 63 | | if ignore_errors { [INFO] [stderr] 64 | | break; [INFO] [stderr] 65 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 62 | } else if ignore_errors { [INFO] [stderr] 63 | break; [INFO] [stderr] 64 | } else { [INFO] [stderr] 65 | return Err(Error::new( [INFO] [stderr] 66 | ErrorKind::Interrupted, [INFO] [stderr] 67 | "Incomplete line in checksum file", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / return App::new("aerate") [INFO] [stderr] 9 | | .arg( [INFO] [stderr] 10 | | Arg::with_name("v") [INFO] [stderr] 11 | | .short("v") [INFO] [stderr] ... | [INFO] [stderr] 18 | | .setting(AppSettings::SubcommandRequired) [INFO] [stderr] 19 | | .get_matches(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 8 | App::new("aerate") [INFO] [stderr] 9 | .arg( [INFO] [stderr] 10 | Arg::with_name("v") [INFO] [stderr] 11 | .short("v") [INFO] [stderr] 12 | .multiple(true) [INFO] [stderr] 13 | .help("Sets the level of verbosity"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/checksum/check.rs:24:47 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn check_hashes(dir: &str, checksum_file: &String) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/checksum/common.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | checksum_file: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/checksum/common.rs:38:55 [INFO] [stderr] | [INFO] [stderr] 38 | let v: Vec<&str> = line.split("\t").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/checksum/check.rs:24:47 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn check_hashes(dir: &str, checksum_file: &String) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/checksum/common.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | checksum_file: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/checksum/common.rs:38:55 [INFO] [stderr] | [INFO] [stderr] 38 | let v: Vec<&str> = line.split("\t").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.87s [INFO] running `"docker" "inspect" "1783cc016b77fed164dc241ea5849dc84dd46c08cfee939953bf0dc1e169688e"` [INFO] running `"docker" "rm" "-f" "1783cc016b77fed164dc241ea5849dc84dd46c08cfee939953bf0dc1e169688e"` [INFO] [stdout] 1783cc016b77fed164dc241ea5849dc84dd46c08cfee939953bf0dc1e169688e