[INFO] updating cached repository harababurel/rtow [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/harababurel/rtow [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/harababurel/rtow" "work/ex/clippy-test-run/sources/stable/gh/harababurel/rtow"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/harababurel/rtow'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/harababurel/rtow" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/harababurel/rtow"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/harababurel/rtow'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] daea89e46d177686c450cc314b33c5ed09d7b4c5 [INFO] sha for GitHub repo harababurel/rtow: daea89e46d177686c450cc314b33c5ed09d7b4c5 [INFO] validating manifest of harababurel/rtow on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of harababurel/rtow on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing harababurel/rtow [INFO] finished frobbing harababurel/rtow [INFO] frobbed toml for harababurel/rtow written to work/ex/clippy-test-run/sources/stable/gh/harababurel/rtow/Cargo.toml [INFO] started frobbing harababurel/rtow [INFO] finished frobbing harababurel/rtow [INFO] frobbed toml for harababurel/rtow written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/harababurel/rtow/Cargo.toml [INFO] crate harababurel/rtow has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting harababurel/rtow against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/harababurel/rtow:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 460fc65ee041b2f85099f9e7edb4305c3d8aee5bcb05462d3fdb84df661c5c66 [INFO] running `"docker" "start" "-a" "460fc65ee041b2f85099f9e7edb4305c3d8aee5bcb05462d3fdb84df661c5c66"` [INFO] [stderr] Checking pbr v1.0.1 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking chan v0.1.21 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking nalgebra v0.14.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking pretty_env_logger v0.2.3 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking rtow v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: field is never used: `w` [INFO] [stderr] --> src/camera.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | w: Unit>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/camera.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | Ray::new(self.origin.clone() + offset, direction) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.origin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/material.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | Box::new(|| Material::random_metal()) as Box Material>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Material::random_metal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/material.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | Box::new(|| Material::random_lambertian()) as Box Material>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Material::random_lambertian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/material.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | Box::new(|| Material::random_dielectric()) as Box Material>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Material::random_dielectric` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/material.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match self { [INFO] [stderr] 98 | | &Material::Lambertian { attenuation } => { [INFO] [stderr] 99 | | let direction = hitpoint.normal.unwrap() + Sphere::random_point_in_unit_sphere(); [INFO] [stderr] 100 | | let scattered_ray = Ray::new(hitpoint.p, direction); [INFO] [stderr] ... | [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | match *self { [INFO] [stderr] 98 | Material::Lambertian { attenuation } => { [INFO] [stderr] 99 | let direction = hitpoint.normal.unwrap() + Sphere::random_point_in_unit_sphere(); [INFO] [stderr] 100 | let scattered_ray = Ray::new(hitpoint.p, direction); [INFO] [stderr] 101 | Some((scattered_ray, attenuation.clone())) [INFO] [stderr] 102 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material.rs:101:38 [INFO] [stderr] | [INFO] [stderr] 101 | Some((scattered_ray, attenuation.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `attenuation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material.rs:117:69 [INFO] [stderr] | [INFO] [stderr] 117 | Some(Ordering::Greater) => Some((scattered_ray, attenuation.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `attenuation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/material.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | / let mut cosine = [INFO] [stderr] 129 | | -ray.direction().dot(&hitpoint.normal) / util::length(ray.direction()); [INFO] [stderr] 130 | | [INFO] [stderr] 131 | | if ray.direction().dot(&hitpoint.normal) > 0. { [INFO] [stderr] ... | [INFO] [stderr] 135 | | / util::length(ray.direction()); [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 128 | let cosine = if ray.direction().dot(&hitpoint.normal) > 0. { ..; refractive_index * ray.direction().dot(&hitpoint.normal) [INFO] [stderr] 129 | / util::length(ray.direction()) } else { -ray.direction().dot(&hitpoint.normal) / util::length(ray.direction()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/ray.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | &self.origin + t * &self.direction [INFO] [stderr] | ------------^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `self.origin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/ray.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | &self.origin + t * &self.direction [INFO] [stderr] | ^^^^--------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sphere.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / (0..) [INFO] [stderr] 53 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sphere.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / (0..) [INFO] [stderr] 70 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/sphere.rs:98:26 [INFO] [stderr] | [INFO] [stderr] 98 | for t in vec![(-b - delta.sqrt()) / a, (-b + delta.sqrt()) / a] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[(-b - delta.sqrt()) / a, (-b + delta.sqrt()) / a]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | let ref mut fout = File::create(&cfg.output_filename).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^----------------------------------------------- help: try: `let fout = &mut File::create(&cfg.output_filename).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | aspect_ratio: cfg.resolution.width as f64 / cfg.resolution.height as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cfg.resolution.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:105:53 [INFO] [stderr] | [INFO] [stderr] 105 | aspect_ratio: cfg.resolution.width as f64 / cfg.resolution.height as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cfg.resolution.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | / image::DynamicImage::new_rgb8(cfg.resolution.width, cfg.resolution.height) [INFO] [stderr] 117 | | .pixels() [INFO] [stderr] 118 | | .into_iter() [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 116 | image::DynamicImage::new_rgb8(cfg.resolution.width, cfg.resolution.height) [INFO] [stderr] 117 | .pixels() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:144:47 [INFO] [stderr] | [INFO] [stderr] 144 | let mut color: Vector3 = (0..cfg.n_samples) [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 145 | | .into_iter() [INFO] [stderr] | |________________________________^ help: consider removing `.into_iter()`: `(0..cfg.n_samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:148:34 [INFO] [stderr] | [INFO] [stderr] 148 | let u = (pixel.0 as f64 + rng.gen::()) / cfg.resolution.width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(pixel.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:148:71 [INFO] [stderr] | [INFO] [stderr] 148 | let u = (pixel.0 as f64 + rng.gen::()) / cfg.resolution.width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cfg.resolution.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:149:34 [INFO] [stderr] | [INFO] [stderr] 149 | let v = (pixel.1 as f64 + rng.gen::()) / cfg.resolution.height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(pixel.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:149:71 [INFO] [stderr] | [INFO] [stderr] 149 | let v = (pixel.1 as f64 + rng.gen::()) / cfg.resolution.height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cfg.resolution.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:155:26 [INFO] [stderr] | [INFO] [stderr] 155 | color /= cfg.n_samples as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cfg.n_samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: field is never used: `w` [INFO] [stderr] --> src/camera.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | w: Unit>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/camera.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | Ray::new(self.origin.clone() + offset, direction) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.origin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/material.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | Box::new(|| Material::random_metal()) as Box Material>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Material::random_metal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/material.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | Box::new(|| Material::random_lambertian()) as Box Material>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Material::random_lambertian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/material.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | Box::new(|| Material::random_dielectric()) as Box Material>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Material::random_dielectric` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/material.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match self { [INFO] [stderr] 98 | | &Material::Lambertian { attenuation } => { [INFO] [stderr] 99 | | let direction = hitpoint.normal.unwrap() + Sphere::random_point_in_unit_sphere(); [INFO] [stderr] 100 | | let scattered_ray = Ray::new(hitpoint.p, direction); [INFO] [stderr] ... | [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | match *self { [INFO] [stderr] 98 | Material::Lambertian { attenuation } => { [INFO] [stderr] 99 | let direction = hitpoint.normal.unwrap() + Sphere::random_point_in_unit_sphere(); [INFO] [stderr] 100 | let scattered_ray = Ray::new(hitpoint.p, direction); [INFO] [stderr] 101 | Some((scattered_ray, attenuation.clone())) [INFO] [stderr] 102 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material.rs:101:38 [INFO] [stderr] | [INFO] [stderr] 101 | Some((scattered_ray, attenuation.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `attenuation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material.rs:117:69 [INFO] [stderr] | [INFO] [stderr] 117 | Some(Ordering::Greater) => Some((scattered_ray, attenuation.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `attenuation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/material.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | / let mut cosine = [INFO] [stderr] 129 | | -ray.direction().dot(&hitpoint.normal) / util::length(ray.direction()); [INFO] [stderr] 130 | | [INFO] [stderr] 131 | | if ray.direction().dot(&hitpoint.normal) > 0. { [INFO] [stderr] ... | [INFO] [stderr] 135 | | / util::length(ray.direction()); [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 128 | let cosine = if ray.direction().dot(&hitpoint.normal) > 0. { ..; refractive_index * ray.direction().dot(&hitpoint.normal) [INFO] [stderr] 129 | / util::length(ray.direction()) } else { -ray.direction().dot(&hitpoint.normal) / util::length(ray.direction()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/ray.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | &self.origin + t * &self.direction [INFO] [stderr] | ------------^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `self.origin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/ray.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | &self.origin + t * &self.direction [INFO] [stderr] | ^^^^--------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sphere.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / (0..) [INFO] [stderr] 53 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sphere.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / (0..) [INFO] [stderr] 70 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/sphere.rs:98:26 [INFO] [stderr] | [INFO] [stderr] 98 | for t in vec![(-b - delta.sqrt()) / a, (-b + delta.sqrt()) / a] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[(-b - delta.sqrt()) / a, (-b + delta.sqrt()) / a]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | let ref mut fout = File::create(&cfg.output_filename).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^----------------------------------------------- help: try: `let fout = &mut File::create(&cfg.output_filename).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | aspect_ratio: cfg.resolution.width as f64 / cfg.resolution.height as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cfg.resolution.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:105:53 [INFO] [stderr] | [INFO] [stderr] 105 | aspect_ratio: cfg.resolution.width as f64 / cfg.resolution.height as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cfg.resolution.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | / image::DynamicImage::new_rgb8(cfg.resolution.width, cfg.resolution.height) [INFO] [stderr] 117 | | .pixels() [INFO] [stderr] 118 | | .into_iter() [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 116 | image::DynamicImage::new_rgb8(cfg.resolution.width, cfg.resolution.height) [INFO] [stderr] 117 | .pixels() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:144:47 [INFO] [stderr] | [INFO] [stderr] 144 | let mut color: Vector3 = (0..cfg.n_samples) [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 145 | | .into_iter() [INFO] [stderr] | |________________________________^ help: consider removing `.into_iter()`: `(0..cfg.n_samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:148:34 [INFO] [stderr] | [INFO] [stderr] 148 | let u = (pixel.0 as f64 + rng.gen::()) / cfg.resolution.width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(pixel.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:148:71 [INFO] [stderr] | [INFO] [stderr] 148 | let u = (pixel.0 as f64 + rng.gen::()) / cfg.resolution.width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cfg.resolution.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:149:34 [INFO] [stderr] | [INFO] [stderr] 149 | let v = (pixel.1 as f64 + rng.gen::()) / cfg.resolution.height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(pixel.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:149:71 [INFO] [stderr] | [INFO] [stderr] 149 | let v = (pixel.1 as f64 + rng.gen::()) / cfg.resolution.height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cfg.resolution.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:155:26 [INFO] [stderr] | [INFO] [stderr] 155 | color /= cfg.n_samples as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cfg.n_samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.38s [INFO] running `"docker" "inspect" "460fc65ee041b2f85099f9e7edb4305c3d8aee5bcb05462d3fdb84df661c5c66"` [INFO] running `"docker" "rm" "-f" "460fc65ee041b2f85099f9e7edb4305c3d8aee5bcb05462d3fdb84df661c5c66"` [INFO] [stdout] 460fc65ee041b2f85099f9e7edb4305c3d8aee5bcb05462d3fdb84df661c5c66