[INFO] updating cached repository happenslol/n3 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/happenslol/n3 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/happenslol/n3" "work/ex/clippy-test-run/sources/stable/gh/happenslol/n3"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/happenslol/n3'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/happenslol/n3" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/happenslol/n3"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/happenslol/n3'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 26a3afe6868a9060ef8c311f4179b997f6ec30be [INFO] sha for GitHub repo happenslol/n3: 26a3afe6868a9060ef8c311f4179b997f6ec30be [INFO] validating manifest of happenslol/n3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of happenslol/n3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing happenslol/n3 [INFO] finished frobbing happenslol/n3 [INFO] frobbed toml for happenslol/n3 written to work/ex/clippy-test-run/sources/stable/gh/happenslol/n3/Cargo.toml [INFO] started frobbing happenslol/n3 [INFO] finished frobbing happenslol/n3 [INFO] frobbed toml for happenslol/n3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/happenslol/n3/Cargo.toml [INFO] crate happenslol/n3 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting happenslol/n3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/happenslol/n3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9e13e50b0ca150eab14bff5674b4ec180247946ba529e0e7627ac9ee101a8bd0 [INFO] running `"docker" "start" "-a" "9e13e50b0ca150eab14bff5674b4ec180247946ba529e0e7627ac9ee101a8bd0"` [INFO] [stderr] Checking gfx_core v0.6.0 [INFO] [stderr] Compiling gl v0.6.1 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Checking libloading v0.3.2 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.1 [INFO] [stderr] Checking gfx v0.14.0 [INFO] [stderr] Checking gfx_device_gl v0.13.0 [INFO] [stderr] Checking piston-gfx_texture v0.22.1 [INFO] [stderr] Checking piston2d-gfx_graphics v0.38.0 [INFO] [stderr] Checking piston_window v0.64.0 [INFO] [stderr] Checking n3 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/game.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | vel[1] *= 0.707106781; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.707_106_781` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/game.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | vel[0] *= 0.707106781; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.707_106_781` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:69:33 [INFO] [stderr] | [INFO] [stderr] 69 | let diag_mult = 0.707106781; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.707_106_781` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/game.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | vel[1] *= 0.707106781; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.707_106_781` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/game.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | vel[0] *= 0.707106781; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.707_106_781` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:69:33 [INFO] [stderr] | [INFO] [stderr] 69 | let diag_mult = 0.707106781; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.707_106_781` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dt` [INFO] [stderr] --> src/camera.rs:20:30 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn update(&mut self, dt: f64) { [INFO] [stderr] | ^^ help: consider using `_dt` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_tile_offset` [INFO] [stderr] --> src/world.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn add_tile_offset(pos: [f64; 2], offset: [i32; 2]) -> [f64; 2] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> src/game.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | vel[1] *= 0.707106781; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> src/game.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | vel[0] *= 0.707106781; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/world.rs:38:30 [INFO] [stderr] | [INFO] [stderr] 38 | row.push(solid_field.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `solid_field` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/world.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | row.push(ground_field.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ground_field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:54:42 [INFO] [stderr] | [INFO] [stderr] 54 | let field_x = x as f64 * TILE_WIDTH as f64 - cam.pos[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | let field_y = y as f64 * TILE_HEIGHT as f64 - cam.pos[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | TILE_WIDTH as f64, TILE_HEIGHT as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:60:47 [INFO] [stderr] | [INFO] [stderr] 60 | TILE_WIDTH as f64, TILE_HEIGHT as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | TILE_WIDTH as f64 - 2.0, TILE_HEIGHT as f64 - 2.0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:64:53 [INFO] [stderr] | [INFO] [stderr] 64 | TILE_WIDTH as f64 - 2.0, TILE_HEIGHT as f64 - 2.0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/world.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn to_tile_pos(pos: [f64; 2]) -> [u32; 2] { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:71:32 [INFO] [stderr] | [INFO] [stderr] 71 | let tile_x = (pos[0] / TILE_WIDTH as f64).floor() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:72:32 [INFO] [stderr] | [INFO] [stderr] 72 | let tile_y = (pos[1] / TILE_HEIGHT as f64).floor() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:78:36 [INFO] [stderr] | [INFO] [stderr] 78 | let pos_x = (tile_pos[0] * TILE_WIDTH as u32) + (TILE_WIDTH / 2) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(TILE_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:78:57 [INFO] [stderr] | [INFO] [stderr] 78 | let pos_x = (tile_pos[0] * TILE_WIDTH as u32) + (TILE_WIDTH / 2) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(TILE_WIDTH / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:79:36 [INFO] [stderr] | [INFO] [stderr] 79 | let pos_y = (tile_pos[1] * TILE_HEIGHT as u32) + (TILE_HEIGHT / 2) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(TILE_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:79:58 [INFO] [stderr] | [INFO] [stderr] 79 | let pos_y = (tile_pos[1] * TILE_HEIGHT as u32) + (TILE_HEIGHT / 2) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(TILE_HEIGHT / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:81:10 [INFO] [stderr] | [INFO] [stderr] 81 | [pos_x as f64, pos_y as f64] [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(pos_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | [pos_x as f64, pos_y as f64] [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(pos_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | [pos[0] + (offset[0] as f64 * TILE_WIDTH as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(offset[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:85:39 [INFO] [stderr] | [INFO] [stderr] 85 | [pos[0] + (offset[0] as f64 * TILE_WIDTH as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | pos[1] + (offset[1] as f64 * TILE_HEIGHT as f64)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(offset[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:86:39 [INFO] [stderr] | [INFO] [stderr] 86 | pos[1] + (offset[1] as f64 * TILE_HEIGHT as f64)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:21:50 [INFO] [stderr] | [INFO] [stderr] 21 | let target_pos = [self.target[0] - 0.5 * super::SCREEN_WIDTH as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(super::SCREEN_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:22:50 [INFO] [stderr] | [INFO] [stderr] 22 | self.target[1] - 0.5 * super::SCREEN_HEIGHT as f64]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(super::SCREEN_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | held_keys.push(key.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | / match key { [INFO] [stderr] 52 | | &Key::W => { [INFO] [stderr] 53 | | move_intention[1] -= 1.0; [INFO] [stderr] 54 | | } [INFO] [stderr] ... | [INFO] [stderr] 64 | | _ => () [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *key { [INFO] [stderr] 52 | Key::W => { [INFO] [stderr] 53 | move_intention[1] -= 1.0; [INFO] [stderr] 54 | } [INFO] [stderr] 55 | Key::S => { [INFO] [stderr] 56 | move_intention[1] += 1.0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> src/main.rs:69:33 [INFO] [stderr] | [INFO] [stderr] 69 | let diag_mult = 0.707106781; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:78:16 [INFO] [stderr] | [INFO] [stderr] 78 | if let Some(_) = e.render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 79 | | window.draw_2d(&e, |c, g| { [INFO] [stderr] 80 | | clear([1.0; 4], g); [INFO] [stderr] 81 | | game.draw(&c, g); [INFO] [stderr] 82 | | }); [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `n3`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `dt` [INFO] [stderr] --> src/camera.rs:20:30 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn update(&mut self, dt: f64) { [INFO] [stderr] | ^^ help: consider using `_dt` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_tile_offset` [INFO] [stderr] --> src/world.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn add_tile_offset(pos: [f64; 2], offset: [i32; 2]) -> [f64; 2] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> src/game.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | vel[1] *= 0.707106781; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> src/game.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | vel[0] *= 0.707106781; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/world.rs:38:30 [INFO] [stderr] | [INFO] [stderr] 38 | row.push(solid_field.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `solid_field` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/world.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | row.push(ground_field.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ground_field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:54:42 [INFO] [stderr] | [INFO] [stderr] 54 | let field_x = x as f64 * TILE_WIDTH as f64 - cam.pos[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | let field_y = y as f64 * TILE_HEIGHT as f64 - cam.pos[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | TILE_WIDTH as f64, TILE_HEIGHT as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:60:47 [INFO] [stderr] | [INFO] [stderr] 60 | TILE_WIDTH as f64, TILE_HEIGHT as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | TILE_WIDTH as f64 - 2.0, TILE_HEIGHT as f64 - 2.0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:64:53 [INFO] [stderr] | [INFO] [stderr] 64 | TILE_WIDTH as f64 - 2.0, TILE_HEIGHT as f64 - 2.0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/world.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn to_tile_pos(pos: [f64; 2]) -> [u32; 2] { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:71:32 [INFO] [stderr] | [INFO] [stderr] 71 | let tile_x = (pos[0] / TILE_WIDTH as f64).floor() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:72:32 [INFO] [stderr] | [INFO] [stderr] 72 | let tile_y = (pos[1] / TILE_HEIGHT as f64).floor() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:78:36 [INFO] [stderr] | [INFO] [stderr] 78 | let pos_x = (tile_pos[0] * TILE_WIDTH as u32) + (TILE_WIDTH / 2) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(TILE_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:78:57 [INFO] [stderr] | [INFO] [stderr] 78 | let pos_x = (tile_pos[0] * TILE_WIDTH as u32) + (TILE_WIDTH / 2) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(TILE_WIDTH / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:79:36 [INFO] [stderr] | [INFO] [stderr] 79 | let pos_y = (tile_pos[1] * TILE_HEIGHT as u32) + (TILE_HEIGHT / 2) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(TILE_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:79:58 [INFO] [stderr] | [INFO] [stderr] 79 | let pos_y = (tile_pos[1] * TILE_HEIGHT as u32) + (TILE_HEIGHT / 2) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(TILE_HEIGHT / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:81:10 [INFO] [stderr] | [INFO] [stderr] 81 | [pos_x as f64, pos_y as f64] [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(pos_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | [pos_x as f64, pos_y as f64] [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(pos_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | [pos[0] + (offset[0] as f64 * TILE_WIDTH as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(offset[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:85:39 [INFO] [stderr] | [INFO] [stderr] 85 | [pos[0] + (offset[0] as f64 * TILE_WIDTH as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | pos[1] + (offset[1] as f64 * TILE_HEIGHT as f64)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(offset[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/world.rs:86:39 [INFO] [stderr] | [INFO] [stderr] 86 | pos[1] + (offset[1] as f64 * TILE_HEIGHT as f64)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:21:50 [INFO] [stderr] | [INFO] [stderr] 21 | let target_pos = [self.target[0] - 0.5 * super::SCREEN_WIDTH as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(super::SCREEN_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:22:50 [INFO] [stderr] | [INFO] [stderr] 22 | self.target[1] - 0.5 * super::SCREEN_HEIGHT as f64]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(super::SCREEN_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | held_keys.push(key.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | / match key { [INFO] [stderr] 52 | | &Key::W => { [INFO] [stderr] 53 | | move_intention[1] -= 1.0; [INFO] [stderr] 54 | | } [INFO] [stderr] ... | [INFO] [stderr] 64 | | _ => () [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *key { [INFO] [stderr] 52 | Key::W => { [INFO] [stderr] 53 | move_intention[1] -= 1.0; [INFO] [stderr] 54 | } [INFO] [stderr] 55 | Key::S => { [INFO] [stderr] 56 | move_intention[1] += 1.0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> src/main.rs:69:33 [INFO] [stderr] | [INFO] [stderr] 69 | let diag_mult = 0.707106781; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:78:16 [INFO] [stderr] | [INFO] [stderr] 78 | if let Some(_) = e.render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 79 | | window.draw_2d(&e, |c, g| { [INFO] [stderr] 80 | | clear([1.0; 4], g); [INFO] [stderr] 81 | | game.draw(&c, g); [INFO] [stderr] 82 | | }); [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `n3`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9e13e50b0ca150eab14bff5674b4ec180247946ba529e0e7627ac9ee101a8bd0"` [INFO] running `"docker" "rm" "-f" "9e13e50b0ca150eab14bff5674b4ec180247946ba529e0e7627ac9ee101a8bd0"` [INFO] [stdout] 9e13e50b0ca150eab14bff5674b4ec180247946ba529e0e7627ac9ee101a8bd0