[INFO] updating cached repository hanskorg/snowflake-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hanskorg/snowflake-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hanskorg/snowflake-rust" "work/ex/clippy-test-run/sources/stable/gh/hanskorg/snowflake-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hanskorg/snowflake-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hanskorg/snowflake-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hanskorg/snowflake-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hanskorg/snowflake-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9f228f670f8b71299aeaee5b5f38b662c95ed266 [INFO] sha for GitHub repo hanskorg/snowflake-rust: 9f228f670f8b71299aeaee5b5f38b662c95ed266 [INFO] validating manifest of hanskorg/snowflake-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hanskorg/snowflake-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hanskorg/snowflake-rust [INFO] finished frobbing hanskorg/snowflake-rust [INFO] frobbed toml for hanskorg/snowflake-rust written to work/ex/clippy-test-run/sources/stable/gh/hanskorg/snowflake-rust/Cargo.toml [INFO] started frobbing hanskorg/snowflake-rust [INFO] finished frobbing hanskorg/snowflake-rust [INFO] frobbed toml for hanskorg/snowflake-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hanskorg/snowflake-rust/Cargo.toml [INFO] crate hanskorg/snowflake-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hanskorg/snowflake-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hanskorg/snowflake-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd3dd0e2b5303c96f3846ddfb674663d41c3ea1c87d6fcd241a884fd81e564c4 [INFO] running `"docker" "start" "-a" "bd3dd0e2b5303c96f3846ddfb674663d41c3ea1c87d6fcd241a884fd81e564c4"` [INFO] [stderr] Checking snowflake-multi-threaded v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | worker_id : worker_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `worker_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | datacenter_id : datacenter_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `datacenter_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | worker_id : worker_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `worker_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | datacenter_id : datacenter_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `datacenter_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/lib.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | twepoch:1514736000_000i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1_514_736_000_000i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/lib.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | twepoch:1514736000_000i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1_514_736_000_000i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: unused variable: `new_id` [INFO] [stderr] --> src/lib.rs:159:25 [INFO] [stderr] | [INFO] [stderr] 159 | let new_id = t.generate_id().unwrap(); [INFO] [stderr] | ^^^^^^ help: consider using `_new_id` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.25s [INFO] running `"docker" "inspect" "bd3dd0e2b5303c96f3846ddfb674663d41c3ea1c87d6fcd241a884fd81e564c4"` [INFO] running `"docker" "rm" "-f" "bd3dd0e2b5303c96f3846ddfb674663d41c3ea1c87d6fcd241a884fd81e564c4"` [INFO] [stdout] bd3dd0e2b5303c96f3846ddfb674663d41c3ea1c87d6fcd241a884fd81e564c4