[INFO] updating cached repository hannu40k/android_file_transfer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hannu40k/android_file_transfer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hannu40k/android_file_transfer" "work/ex/clippy-test-run/sources/stable/gh/hannu40k/android_file_transfer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hannu40k/android_file_transfer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hannu40k/android_file_transfer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hannu40k/android_file_transfer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hannu40k/android_file_transfer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] af99f67d1edee55cbff71f5fea78d00e128c9439 [INFO] sha for GitHub repo hannu40k/android_file_transfer: af99f67d1edee55cbff71f5fea78d00e128c9439 [INFO] validating manifest of hannu40k/android_file_transfer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hannu40k/android_file_transfer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hannu40k/android_file_transfer [INFO] finished frobbing hannu40k/android_file_transfer [INFO] frobbed toml for hannu40k/android_file_transfer written to work/ex/clippy-test-run/sources/stable/gh/hannu40k/android_file_transfer/Cargo.toml [INFO] started frobbing hannu40k/android_file_transfer [INFO] finished frobbing hannu40k/android_file_transfer [INFO] frobbed toml for hannu40k/android_file_transfer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hannu40k/android_file_transfer/Cargo.toml [INFO] crate hannu40k/android_file_transfer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hannu40k/android_file_transfer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hannu40k/android_file_transfer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b771fecbd3e5c39c31ab7451a2dde8c619dd9823fa9402b816ad42dde928580d [INFO] running `"docker" "start" "-a" "b771fecbd3e5c39c31ab7451a2dde8c619dd9823fa9402b816ad42dde928580d"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking serde_yaml v0.7.5 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking serde_json v1.0.27 [INFO] [stderr] Checking serde-value v0.5.2 [INFO] [stderr] Checking log4rs v0.8.0 [INFO] [stderr] Checking android-file-transfer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:80:56 [INFO] [stderr] | [INFO] [stderr] 80 | fn log_action(log_file: &str, transferred_files_count: &i32) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:166:55 [INFO] [stderr] | [INFO] [stderr] 166 | let output_lines: Vec<&str> = output_string.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:80:56 [INFO] [stderr] | [INFO] [stderr] 80 | fn log_action(log_file: &str, transferred_files_count: &i32) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:166:55 [INFO] [stderr] | [INFO] [stderr] 166 | let output_lines: Vec<&str> = output_string.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.43s [INFO] running `"docker" "inspect" "b771fecbd3e5c39c31ab7451a2dde8c619dd9823fa9402b816ad42dde928580d"` [INFO] running `"docker" "rm" "-f" "b771fecbd3e5c39c31ab7451a2dde8c619dd9823fa9402b816ad42dde928580d"` [INFO] [stdout] b771fecbd3e5c39c31ab7451a2dde8c619dd9823fa9402b816ad42dde928580d