[INFO] updating cached repository hamaluik/rustilox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hamaluik/rustilox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hamaluik/rustilox" "work/ex/clippy-test-run/sources/stable/gh/hamaluik/rustilox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hamaluik/rustilox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hamaluik/rustilox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hamaluik/rustilox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hamaluik/rustilox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 07d03e8233747513a4f0001fa2d30ec6f969705c [INFO] sha for GitHub repo hamaluik/rustilox: 07d03e8233747513a4f0001fa2d30ec6f969705c [INFO] validating manifest of hamaluik/rustilox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hamaluik/rustilox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hamaluik/rustilox [INFO] finished frobbing hamaluik/rustilox [INFO] frobbed toml for hamaluik/rustilox written to work/ex/clippy-test-run/sources/stable/gh/hamaluik/rustilox/Cargo.toml [INFO] started frobbing hamaluik/rustilox [INFO] finished frobbing hamaluik/rustilox [INFO] frobbed toml for hamaluik/rustilox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hamaluik/rustilox/Cargo.toml [INFO] crate hamaluik/rustilox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hamaluik/rustilox against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hamaluik/rustilox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4016f4e23ca21983b8ed105c0632ee18c45a5372f2d5ea70adefbd214cdc1184 [INFO] running `"docker" "start" "-a" "4016f4e23ca21983b8ed105c0632ee18c45a5372f2d5ea70adefbd214cdc1184"` [INFO] [stderr] Checking rprompt v1.0.3 [INFO] [stderr] Compiling backtrace-sys v0.1.17 [INFO] [stderr] Checking criterion-plot v0.2.3 [INFO] [stderr] Checking criterion-stats v0.2.3 [INFO] [stderr] Checking itertools-num v0.1.1 [INFO] [stderr] Checking handlebars v0.31.0 [INFO] [stderr] Checking simplelog v0.5.2 [INFO] [stderr] Checking rustilox v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/compiler/scanner.rs:80:33 [INFO] [stderr] | [INFO] [stderr] 80 | fn match_next(&mut self, c: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compiler/scanner.rs:114:40 [INFO] [stderr] | [INFO] [stderr] 114 | let slice: &str = &self.source[start..end+1]; [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compiler/scanner.rs:151:40 [INFO] [stderr] | [INFO] [stderr] 151 | let slice: &str = &self.source[start..end+1]; [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compiler/scanner.rs:175:40 [INFO] [stderr] | [INFO] [stderr] 175 | let slice: &str = &self.source[start..end+1]; [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compiler/scanner.rs:216:40 [INFO] [stderr] | [INFO] [stderr] 216 | let slice: &str = &self.source[start..end+1]; [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Checking backtrace v0.3.8 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking criterion v0.2.3 [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/compiler/scanner.rs:80:33 [INFO] [stderr] | [INFO] [stderr] 80 | fn match_next(&mut self, c: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compiler/scanner.rs:114:40 [INFO] [stderr] | [INFO] [stderr] 114 | let slice: &str = &self.source[start..end+1]; [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compiler/scanner.rs:151:40 [INFO] [stderr] | [INFO] [stderr] 151 | let slice: &str = &self.source[start..end+1]; [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compiler/scanner.rs:175:40 [INFO] [stderr] | [INFO] [stderr] 175 | let slice: &str = &self.source[start..end+1]; [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compiler/scanner.rs:216:40 [INFO] [stderr] | [INFO] [stderr] 216 | let slice: &str = &self.source[start..end+1]; [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.20s [INFO] running `"docker" "inspect" "4016f4e23ca21983b8ed105c0632ee18c45a5372f2d5ea70adefbd214cdc1184"` [INFO] running `"docker" "rm" "-f" "4016f4e23ca21983b8ed105c0632ee18c45a5372f2d5ea70adefbd214cdc1184"` [INFO] [stdout] 4016f4e23ca21983b8ed105c0632ee18c45a5372f2d5ea70adefbd214cdc1184