[INFO] updating cached repository hamaluik/pathtest1 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hamaluik/pathtest1 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hamaluik/pathtest1" "work/ex/clippy-test-run/sources/stable/gh/hamaluik/pathtest1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hamaluik/pathtest1'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hamaluik/pathtest1" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hamaluik/pathtest1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hamaluik/pathtest1'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 409e2475244783a36794f80f842bffae45aabb21 [INFO] sha for GitHub repo hamaluik/pathtest1: 409e2475244783a36794f80f842bffae45aabb21 [INFO] validating manifest of hamaluik/pathtest1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hamaluik/pathtest1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hamaluik/pathtest1 [INFO] finished frobbing hamaluik/pathtest1 [INFO] frobbed toml for hamaluik/pathtest1 written to work/ex/clippy-test-run/sources/stable/gh/hamaluik/pathtest1/Cargo.toml [INFO] started frobbing hamaluik/pathtest1 [INFO] finished frobbing hamaluik/pathtest1 [INFO] frobbed toml for hamaluik/pathtest1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hamaluik/pathtest1/Cargo.toml [INFO] crate hamaluik/pathtest1 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hamaluik/pathtest1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hamaluik/pathtest1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fae276bd89a933d73551386aef347bf6e3ac5e10caaa115c02fe38691f1a7a9a [INFO] running `"docker" "start" "-a" "fae276bd89a933d73551386aef347bf6e3ac5e10caaa115c02fe38691f1a7a9a"` [INFO] [stderr] Checking pathfinding v1.0.3 [INFO] [stderr] Checking pathtest1 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | None => return Vec::new(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | None => return Vec::new(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | fn transform_raw_graph(g: &MapGraph) -> (HashMap, HashMap>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / if !edges.contains_key(&edge.from) { [INFO] [stderr] 49 | | edges.insert(edge.from, HashMap::new()); [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ help: consider using: `edges.entry(edge.from).or_insert(HashMap::new())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:79:30 [INFO] [stderr] | [INFO] [stderr] 79 | let coords_end = nodes.get(&target_node).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&nodes[&target_node]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | fn transform_raw_graph(g: &MapGraph) -> (HashMap, HashMap>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / if !edges.contains_key(&edge.from) { [INFO] [stderr] 49 | | edges.insert(edge.from, HashMap::new()); [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ help: consider using: `edges.entry(edge.from).or_insert(HashMap::new())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:79:30 [INFO] [stderr] | [INFO] [stderr] 79 | let coords_end = nodes.get(&target_node).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&nodes[&target_node]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.30s [INFO] running `"docker" "inspect" "fae276bd89a933d73551386aef347bf6e3ac5e10caaa115c02fe38691f1a7a9a"` [INFO] running `"docker" "rm" "-f" "fae276bd89a933d73551386aef347bf6e3ac5e10caaa115c02fe38691f1a7a9a"` [INFO] [stdout] fae276bd89a933d73551386aef347bf6e3ac5e10caaa115c02fe38691f1a7a9a