[INFO] updating cached repository halship/tetris-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/halship/tetris-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/halship/tetris-rs" "work/ex/clippy-test-run/sources/stable/gh/halship/tetris-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/halship/tetris-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/halship/tetris-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/halship/tetris-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/halship/tetris-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 367e16fc9ecfe8d6a3870e33a957a6275d9c1f17 [INFO] sha for GitHub repo halship/tetris-rs: 367e16fc9ecfe8d6a3870e33a957a6275d9c1f17 [INFO] validating manifest of halship/tetris-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of halship/tetris-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing halship/tetris-rs [INFO] finished frobbing halship/tetris-rs [INFO] frobbed toml for halship/tetris-rs written to work/ex/clippy-test-run/sources/stable/gh/halship/tetris-rs/Cargo.toml [INFO] started frobbing halship/tetris-rs [INFO] finished frobbing halship/tetris-rs [INFO] frobbed toml for halship/tetris-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/halship/tetris-rs/Cargo.toml [INFO] crate halship/tetris-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting halship/tetris-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/halship/tetris-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5ba7132a8d57d93b46d1de7fc075624fda3dda0dbae670a6c37b923a98629670 [INFO] running `"docker" "start" "-a" "5ba7132a8d57d93b46d1de7fc075624fda3dda0dbae670a6c37b923a98629670"` [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking deflate v0.7.16 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking tempfile v2.1.6 [INFO] [stderr] Checking x11-dl v2.15.0 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking pistoncore-input v0.19.0 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking pistoncore-window v0.28.0 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking pistoncore-event_loop v0.33.0 [INFO] [stderr] Checking piston v0.33.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking glutin v0.9.2 [INFO] [stderr] Checking gfx v0.16.1 [INFO] [stderr] Checking gfx_device_gl v0.14.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.39.0 [INFO] [stderr] Checking piston-gfx_texture v0.26.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.43.0 [INFO] [stderr] Checking piston_window v0.70.0 [INFO] [stderr] Checking tetris v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/view.rs:91:66 [INFO] [stderr] | [INFO] [stderr] 91 | fn render_block(c: &Context, g: &mut G2d, x: f64, y: f64, color: &BlockColor, res: &Resources) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `BlockColor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/models/field.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | for j in 0..SCREEN_WIDTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try replacing the loop by: `self.0[i + 1][..SCREEN_WIDTH].clone_from_slice(&self.0[i][..SCREEN_WIDTH])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if let Some(_) = e.render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 47 | | window.draw_2d(&e, |c, g| { [INFO] [stderr] 48 | | view::render_game(&c, g, &world, &mut resources, &scene); [INFO] [stderr] 49 | | }); [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/view.rs:91:66 [INFO] [stderr] | [INFO] [stderr] 91 | fn render_block(c: &Context, g: &mut G2d, x: f64, y: f64, color: &BlockColor, res: &Resources) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `BlockColor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/models/field.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | for j in 0..SCREEN_WIDTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try replacing the loop by: `self.0[i + 1][..SCREEN_WIDTH].clone_from_slice(&self.0[i][..SCREEN_WIDTH])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if let Some(_) = e.render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 47 | | window.draw_2d(&e, |c, g| { [INFO] [stderr] 48 | | view::render_game(&c, g, &world, &mut resources, &scene); [INFO] [stderr] 49 | | }); [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.60s [INFO] running `"docker" "inspect" "5ba7132a8d57d93b46d1de7fc075624fda3dda0dbae670a6c37b923a98629670"` [INFO] running `"docker" "rm" "-f" "5ba7132a8d57d93b46d1de7fc075624fda3dda0dbae670a6c37b923a98629670"` [INFO] [stdout] 5ba7132a8d57d93b46d1de7fc075624fda3dda0dbae670a6c37b923a98629670