[INFO] updating cached repository hakaboyo/CS410_Rust_Programming_Final_Project [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hakaboyo/CS410_Rust_Programming_Final_Project [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hakaboyo/CS410_Rust_Programming_Final_Project" "work/ex/clippy-test-run/sources/stable/gh/hakaboyo/CS410_Rust_Programming_Final_Project"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hakaboyo/CS410_Rust_Programming_Final_Project'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hakaboyo/CS410_Rust_Programming_Final_Project" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hakaboyo/CS410_Rust_Programming_Final_Project"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hakaboyo/CS410_Rust_Programming_Final_Project'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 64686991df365e680510b3ba80d1d974af465922 [INFO] sha for GitHub repo hakaboyo/CS410_Rust_Programming_Final_Project: 64686991df365e680510b3ba80d1d974af465922 [INFO] validating manifest of hakaboyo/CS410_Rust_Programming_Final_Project on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hakaboyo/CS410_Rust_Programming_Final_Project on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hakaboyo/CS410_Rust_Programming_Final_Project [INFO] finished frobbing hakaboyo/CS410_Rust_Programming_Final_Project [INFO] frobbed toml for hakaboyo/CS410_Rust_Programming_Final_Project written to work/ex/clippy-test-run/sources/stable/gh/hakaboyo/CS410_Rust_Programming_Final_Project/Cargo.toml [INFO] started frobbing hakaboyo/CS410_Rust_Programming_Final_Project [INFO] finished frobbing hakaboyo/CS410_Rust_Programming_Final_Project [INFO] frobbed toml for hakaboyo/CS410_Rust_Programming_Final_Project written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hakaboyo/CS410_Rust_Programming_Final_Project/Cargo.toml [INFO] crate hakaboyo/CS410_Rust_Programming_Final_Project has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hakaboyo/CS410_Rust_Programming_Final_Project against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hakaboyo/CS410_Rust_Programming_Final_Project:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0ecaba6e6c36c061856a195651c59b417b95da5242c203b3a1b73e78477bd164 [INFO] running `"docker" "start" "-a" "0ecaba6e6c36c061856a195651c59b417b95da5242c203b3a1b73e78477bd164"` [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking hyper v0.12.8 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking hyper-staticfile v0.3.0 [INFO] [stderr] Checking persistent v0.3.0 [INFO] [stderr] Checking mount v0.3.0 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking bodyparser v0.5.0 [INFO] [stderr] Checking staticfile v0.4.0 [INFO] [stderr] Checking urlencoded v0.5.0 [INFO] [stderr] Checking webapp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:52:81 [INFO] [stderr] | [INFO] [stderr] 52 | fn spanish_handler(correct: &Arc>>, spanish_word: &Vec<&str>, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | spanglish: &Vec<&str>, _req: &mut Request) -> IronResult { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:75:81 [INFO] [stderr] | [INFO] [stderr] 75 | fn swahili_handler(correct: &Arc>>, swahili_word: &Vec<&str>, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | swanglish: &Vec<&str>, _req: &mut Request) -> IronResult { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:126:33 [INFO] [stderr] | [INFO] [stderr] 126 | fn create_randomly_5pairs(word: &Vec<&str>, meanings: &Vec<&str>) [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:126:55 [INFO] [stderr] | [INFO] [stderr] 126 | fn create_randomly_5pairs(word: &Vec<&str>, meanings: &Vec<&str>) [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:141:12 [INFO] [stderr] | [INFO] [stderr] 141 | if item_tracker.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `item_tracker.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `item_tracker`. [INFO] [stderr] --> src/main.rs:146:26 [INFO] [stderr] | [INFO] [stderr] 146 | for index in 0..item_tracker.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 146 | for in &item_tracker { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:219:23 [INFO] [stderr] | [INFO] [stderr] 219 | let earned_pts = (points as f64 /5.0) * 100.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(points)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:52:81 [INFO] [stderr] | [INFO] [stderr] 52 | fn spanish_handler(correct: &Arc>>, spanish_word: &Vec<&str>, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | spanglish: &Vec<&str>, _req: &mut Request) -> IronResult { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:75:81 [INFO] [stderr] | [INFO] [stderr] 75 | fn swahili_handler(correct: &Arc>>, swahili_word: &Vec<&str>, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | swanglish: &Vec<&str>, _req: &mut Request) -> IronResult { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:126:33 [INFO] [stderr] | [INFO] [stderr] 126 | fn create_randomly_5pairs(word: &Vec<&str>, meanings: &Vec<&str>) [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:126:55 [INFO] [stderr] | [INFO] [stderr] 126 | fn create_randomly_5pairs(word: &Vec<&str>, meanings: &Vec<&str>) [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:141:12 [INFO] [stderr] | [INFO] [stderr] 141 | if item_tracker.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `item_tracker.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `item_tracker`. [INFO] [stderr] --> src/main.rs:146:26 [INFO] [stderr] | [INFO] [stderr] 146 | for index in 0..item_tracker.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 146 | for in &item_tracker { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:219:23 [INFO] [stderr] | [INFO] [stderr] 219 | let earned_pts = (points as f64 /5.0) * 100.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(points)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.75s [INFO] running `"docker" "inspect" "0ecaba6e6c36c061856a195651c59b417b95da5242c203b3a1b73e78477bd164"` [INFO] running `"docker" "rm" "-f" "0ecaba6e6c36c061856a195651c59b417b95da5242c203b3a1b73e78477bd164"` [INFO] [stdout] 0ecaba6e6c36c061856a195651c59b417b95da5242c203b3a1b73e78477bd164