[INFO] updating cached repository hagt/semnet-web
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/hagt/semnet-web
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/hagt/semnet-web" "work/ex/clippy-test-run/sources/stable/gh/hagt/semnet-web"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hagt/semnet-web'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/hagt/semnet-web" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hagt/semnet-web"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hagt/semnet-web'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d0d5a42d27686f83823d147a7b96a63da0d73fd5
[INFO] sha for GitHub repo hagt/semnet-web: d0d5a42d27686f83823d147a7b96a63da0d73fd5
[INFO] validating manifest of hagt/semnet-web on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hagt/semnet-web on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hagt/semnet-web
[INFO] finished frobbing hagt/semnet-web
[INFO] frobbed toml for hagt/semnet-web written to work/ex/clippy-test-run/sources/stable/gh/hagt/semnet-web/Cargo.toml
[INFO] started frobbing hagt/semnet-web
[INFO] finished frobbing hagt/semnet-web
[INFO] frobbed toml for hagt/semnet-web written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hagt/semnet-web/Cargo.toml
[INFO] crate hagt/semnet-web has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hagt/semnet-web against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hagt/semnet-web:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f8f4388d16635ab000ad255761cd95400ef2a551098407cbd9e9beefd9ac4675
[INFO] running `"docker" "start" "-a" "f8f4388d16635ab000ad255761cd95400ef2a551098407cbd9e9beefd9ac4675"`
[INFO] [stderr]    Compiling libsqlite3-sys v0.9.1
[INFO] [stderr]     Checking nickel v0.10.1
[INFO] [stderr]     Checking rusqlite v0.13.0
[INFO] [stderr]     Checking semnet-web v0.5.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 |                 name: name,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:119:17
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 info: info,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `info`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:175:13
[INFO] [stderr]     |
[INFO] [stderr] 175 |             semcons: semcons,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `semcons`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:176:13
[INFO] [stderr]     |
[INFO] [stderr] 176 |             pages: pages,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `pages`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 |                 name: name,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:119:17
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 info: info,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `info`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:175:13
[INFO] [stderr]     |
[INFO] [stderr] 175 |             semcons: semcons,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `semcons`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:176:13
[INFO] [stderr]     |
[INFO] [stderr] 176 |             pages: pages,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `pages`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:131:61
[INFO] [stderr]     |
[INFO] [stderr] 131 | fn execute_query(db: &Connection, terms: &[String], offset: &u32) -> Result<Pagination, String> {
[INFO] [stderr]     |                                                             ^^^^ help: consider passing by value instead: `u32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/main.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |      if terms.len() < 1 || terms.len() > 2 {
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `terms.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/main.rs:167:18
[INFO] [stderr]     |
[INFO] [stderr] 167 |         for i in 0..row_count / 50 + 1 {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=row_count / 50`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:131:61
[INFO] [stderr]     |
[INFO] [stderr] 131 | fn execute_query(db: &Connection, terms: &[String], offset: &u32) -> Result<Pagination, String> {
[INFO] [stderr]     |                                                             ^^^^ help: consider passing by value instead: `u32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/main.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |      if terms.len() < 1 || terms.len() > 2 {
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `terms.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/main.rs:167:18
[INFO] [stderr]     |
[INFO] [stderr] 167 |         for i in 0..row_count / 50 + 1 {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=row_count / 50`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.24s
[INFO] running `"docker" "inspect" "f8f4388d16635ab000ad255761cd95400ef2a551098407cbd9e9beefd9ac4675"`
[INFO] running `"docker" "rm" "-f" "f8f4388d16635ab000ad255761cd95400ef2a551098407cbd9e9beefd9ac4675"`
[INFO] [stdout] f8f4388d16635ab000ad255761cd95400ef2a551098407cbd9e9beefd9ac4675