[INFO] updating cached repository ha-shine/rustagram [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ha-shine/rustagram [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ha-shine/rustagram" "work/ex/clippy-test-run/sources/stable/gh/ha-shine/rustagram"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ha-shine/rustagram'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ha-shine/rustagram" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ha-shine/rustagram"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ha-shine/rustagram'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 37d54cbb1f2ca26f8b1c4e1e3e6c226ae0241297 [INFO] sha for GitHub repo ha-shine/rustagram: 37d54cbb1f2ca26f8b1c4e1e3e6c226ae0241297 [INFO] validating manifest of ha-shine/rustagram on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ha-shine/rustagram on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ha-shine/rustagram [INFO] finished frobbing ha-shine/rustagram [INFO] frobbed toml for ha-shine/rustagram written to work/ex/clippy-test-run/sources/stable/gh/ha-shine/rustagram/Cargo.toml [INFO] started frobbing ha-shine/rustagram [INFO] finished frobbing ha-shine/rustagram [INFO] frobbed toml for ha-shine/rustagram written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ha-shine/rustagram/Cargo.toml [INFO] crate ha-shine/rustagram has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ha-shine/rustagram against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ha-shine/rustagram:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4061bb0bce5717637f80d9cfaeb4ed6944e5d8cc74eebd7c209846c8d26558f0 [INFO] running `"docker" "start" "-a" "4061bb0bce5717637f80d9cfaeb4ed6944e5d8cc74eebd7c209846c8d26558f0"` [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking rayon v1.0.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking rustagram v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:74:15 [INFO] [stderr] | [INFO] [stderr] 74 | let out = rustaops::blend_screen(&saturated, &foreground); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:83:15 [INFO] [stderr] | [INFO] [stderr] 83 | let out = rustaops::restore_transparency(&brightened); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:92:15 [INFO] [stderr] | [INFO] [stderr] 92 | let out = rustaops::blend_lighten(&foreground, &contrasted); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:102:15 [INFO] [stderr] | [INFO] [stderr] 102 | let out = rustaops::blend_overlay(&foreground, &background); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:111:15 [INFO] [stderr] | [INFO] [stderr] 111 | let out = rustaops::blend_overlay(&foreground, &saturated); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:121:15 [INFO] [stderr] | [INFO] [stderr] 121 | let out = rustaops::restore_transparency(&out); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:130:15 [INFO] [stderr] | [INFO] [stderr] 130 | let out = rustaops::blend_soft_light(&foreground, &background); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:141:15 [INFO] [stderr] | [INFO] [stderr] 141 | let out = rustaops::restore_transparency(&blended); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:158:15 [INFO] [stderr] | [INFO] [stderr] 158 | let out = rustaops::blend_overlay(&foreground, &color_dodged); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:168:15 [INFO] [stderr] | [INFO] [stderr] 168 | let out = rustaops::blend_darken(&foreground, &color_dodged); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:174:15 [INFO] [stderr] | [INFO] [stderr] 174 | let out = imageops::contrast(&saturated, 50.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:182:15 [INFO] [stderr] | [INFO] [stderr] 182 | let out = rustaops::saturate(&contrasted, 50.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:191:15 [INFO] [stderr] | [INFO] [stderr] 191 | let out = rustaops::blend_overlay(&foreground, &saturated); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:216:15 [INFO] [stderr] | [INFO] [stderr] 216 | let out = rustaops::blend_lighten(&foreground, &darkened); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:228:5 [INFO] [stderr] | [INFO] [stderr] 228 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:227:15 [INFO] [stderr] | [INFO] [stderr] 227 | let out = rustaops::over(&foreground, &saturated); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:241:15 [INFO] [stderr] | [INFO] [stderr] 241 | let out = rustaops::over(&overlaid, img); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:253:5 [INFO] [stderr] | [INFO] [stderr] 253 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:252:15 [INFO] [stderr] | [INFO] [stderr] 252 | let out = rustaops::blend_soft_light(&foreground, &lightened); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:262:15 [INFO] [stderr] | [INFO] [stderr] 262 | let out = rustaops::blend_soft_light(&foreground, &brightened); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:272:5 [INFO] [stderr] | [INFO] [stderr] 272 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:271:15 [INFO] [stderr] | [INFO] [stderr] 271 | let out = rustaops::blend_screen(&foreground, &brightened); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:281:15 [INFO] [stderr] | [INFO] [stderr] 281 | let out = rustaops::blend_exclusion(&foreground, &sepia); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:292:15 [INFO] [stderr] | [INFO] [stderr] 292 | let out = rustaops::blend_screen(&foreground, &sepia); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/rustaops/blend.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | rhs [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/rustaops/blend.rs:87:15 [INFO] [stderr] | [INFO] [stderr] 87 | let rhs = x1.wrapping_add(x2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustaops/mod.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | return [hue, lumination, saturation] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[hue, lumination, saturation]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustaops/mod.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | return m1 + (m2 - m1) * hue * 6.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `m1 + (m2 - m1) * hue * 6.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustaops/mod.rs:367:9 [INFO] [stderr] | [INFO] [stderr] 367 | return m2 [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustaops/mod.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | return m1 + (m2 - m1) * ((2.0/3.0) - hue) * 6.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `m1 + (m2 - m1) * ((2.0/3.0) - hue) * 6.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustaops/mod.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | return m1 [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:74:15 [INFO] [stderr] | [INFO] [stderr] 74 | let out = rustaops::blend_screen(&saturated, &foreground); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:83:15 [INFO] [stderr] | [INFO] [stderr] 83 | let out = rustaops::restore_transparency(&brightened); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:92:15 [INFO] [stderr] | [INFO] [stderr] 92 | let out = rustaops::blend_lighten(&foreground, &contrasted); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:102:15 [INFO] [stderr] | [INFO] [stderr] 102 | let out = rustaops::blend_overlay(&foreground, &background); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:111:15 [INFO] [stderr] | [INFO] [stderr] 111 | let out = rustaops::blend_overlay(&foreground, &saturated); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:121:15 [INFO] [stderr] | [INFO] [stderr] 121 | let out = rustaops::restore_transparency(&out); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:130:15 [INFO] [stderr] | [INFO] [stderr] 130 | let out = rustaops::blend_soft_light(&foreground, &background); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:141:15 [INFO] [stderr] | [INFO] [stderr] 141 | let out = rustaops::restore_transparency(&blended); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:158:15 [INFO] [stderr] | [INFO] [stderr] 158 | let out = rustaops::blend_overlay(&foreground, &color_dodged); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:168:15 [INFO] [stderr] | [INFO] [stderr] 168 | let out = rustaops::blend_darken(&foreground, &color_dodged); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:174:15 [INFO] [stderr] | [INFO] [stderr] 174 | let out = imageops::contrast(&saturated, 50.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:182:15 [INFO] [stderr] | [INFO] [stderr] 182 | let out = rustaops::saturate(&contrasted, 50.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:191:15 [INFO] [stderr] | [INFO] [stderr] 191 | let out = rustaops::blend_overlay(&foreground, &saturated); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:216:15 [INFO] [stderr] | [INFO] [stderr] 216 | let out = rustaops::blend_lighten(&foreground, &darkened); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:228:5 [INFO] [stderr] | [INFO] [stderr] 228 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:227:15 [INFO] [stderr] | [INFO] [stderr] 227 | let out = rustaops::over(&foreground, &saturated); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:241:15 [INFO] [stderr] | [INFO] [stderr] 241 | let out = rustaops::over(&overlaid, img); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:253:5 [INFO] [stderr] | [INFO] [stderr] 253 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:252:15 [INFO] [stderr] | [INFO] [stderr] 252 | let out = rustaops::blend_soft_light(&foreground, &lightened); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:262:15 [INFO] [stderr] | [INFO] [stderr] 262 | let out = rustaops::blend_soft_light(&foreground, &brightened); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:272:5 [INFO] [stderr] | [INFO] [stderr] 272 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:271:15 [INFO] [stderr] | [INFO] [stderr] 271 | let out = rustaops::blend_screen(&foreground, &brightened); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:281:15 [INFO] [stderr] | [INFO] [stderr] 281 | let out = rustaops::blend_exclusion(&foreground, &sepia); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters.rs:292:15 [INFO] [stderr] | [INFO] [stderr] 292 | let out = rustaops::blend_screen(&foreground, &sepia); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/rustaops/blend.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | rhs [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/rustaops/blend.rs:87:15 [INFO] [stderr] | [INFO] [stderr] 87 | let rhs = x1.wrapping_add(x2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustaops/mod.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | return [hue, lumination, saturation] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[hue, lumination, saturation]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustaops/mod.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | return m1 + (m2 - m1) * hue * 6.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `m1 + (m2 - m1) * hue * 6.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustaops/mod.rs:367:9 [INFO] [stderr] | [INFO] [stderr] 367 | return m2 [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustaops/mod.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | return m1 + (m2 - m1) * ((2.0/3.0) - hue) * 6.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `m1 + (m2 - m1) * ((2.0/3.0) - hue) * 6.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustaops/mod.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | return m1 [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rustaops/blend.rs:4:32 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn compute_final_alpha(fg: &[u8; 4], bg: &[u8; 4]) -> u8 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rustaops/blend.rs:4:46 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn compute_final_alpha(fg: &[u8; 4], bg: &[u8; 4]) -> u8 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | let fg_alpha = fg[3] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(fg[3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:6:20 [INFO] [stderr] | [INFO] [stderr] 6 | let bg_alpha = bg[3] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(bg[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | let x1: u16 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | let x2: u16 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | let x1: u16 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | let x2: u16 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:98:14 [INFO] [stderr] | [INFO] [stderr] 98 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:99:14 [INFO] [stderr] | [INFO] [stderr] 99 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:109:14 [INFO] [stderr] | [INFO] [stderr] 109 | let f2 = x2 as f32; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:110:19 [INFO] [stderr] | [INFO] [stderr] 110 | let shifted = (x1>>1) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(x1>>1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:152:14 [INFO] [stderr] | [INFO] [stderr] 152 | let x1 = x1 as i16; [INFO] [stderr] | ^^^^^^^^^ help: try: `i16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:153:14 [INFO] [stderr] | [INFO] [stderr] 153 | let x2 = x2 as i16; [INFO] [stderr] | ^^^^^^^^^ help: try: `i16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:159:14 [INFO] [stderr] | [INFO] [stderr] 159 | let x1 = x1 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:160:14 [INFO] [stderr] | [INFO] [stderr] 160 | let x2 = x2 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | let max: f32 = max as f32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | let c: f32 = b as f32; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | let mut r = channels[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(channels[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | let mut g = channels[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(channels[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | let mut b = channels[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(channels[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustaops/mod.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | r = r + (depth * 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `r += (depth * 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustaops/mod.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | g = g + depth; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `g += depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | let f = b as f32; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rustaops/mod.rs:74:62 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn fill_with_channels(width: u32, height: u32, channels: &[u8; 4]) -> ImageBuffer, Vec> [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let a = channels[3] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | let r = ((channels[0] as f32) * a / 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | let g = ((channels[1] as f32) * a / 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:79:14 [INFO] [stderr] | [INFO] [stderr] 79 | let b = ((channels[2] as f32) * a / 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | let fg_c = fg_data[i] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(fg_data[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:121:24 [INFO] [stderr] | [INFO] [stderr] 121 | let bg_c = bg_data[i] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(bg_data[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rustaops/mod.rs:272:21 [INFO] [stderr] | [INFO] [stderr] 272 | fn rgb_to_hls(rgba: &[u8; 4]) -> [f32; 3] { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | let r = rgba[0] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(rgba[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | let g = rgba[1] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(rgba[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | let b = rgba[2] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(rgba[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustaops/mod.rs:284:8 [INFO] [stderr] | [INFO] [stderr] 284 | if max == min { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(max - min).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustaops/mod.rs:284:8 [INFO] [stderr] | [INFO] [stderr] 284 | if max == min { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustaops/mod.rs:295:8 [INFO] [stderr] | [INFO] [stderr] 295 | if r == max { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(r - max).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustaops/mod.rs:295:8 [INFO] [stderr] | [INFO] [stderr] 295 | if r == max { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustaops/mod.rs:297:15 [INFO] [stderr] | [INFO] [stderr] 297 | } else if g == max { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(g - max).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustaops/mod.rs:297:15 [INFO] [stderr] | [INFO] [stderr] 297 | } else if g == max { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:8:59 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn validate_filter_type(filter: &str, filter_strings: &Vec<&str>, filter_types: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:8:85 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn validate_filter_type(filter: &str, filter_strings: &Vec<&str>, filter_types: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[FilterType]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustagram`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rustaops/blend.rs:4:32 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn compute_final_alpha(fg: &[u8; 4], bg: &[u8; 4]) -> u8 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rustaops/blend.rs:4:46 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn compute_final_alpha(fg: &[u8; 4], bg: &[u8; 4]) -> u8 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | let fg_alpha = fg[3] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(fg[3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:6:20 [INFO] [stderr] | [INFO] [stderr] 6 | let bg_alpha = bg[3] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(bg[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | let x1: u16 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | let x2: u16 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | let x1: u16 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | let x2: u16 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:98:14 [INFO] [stderr] | [INFO] [stderr] 98 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:99:14 [INFO] [stderr] | [INFO] [stderr] 99 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:109:14 [INFO] [stderr] | [INFO] [stderr] 109 | let f2 = x2 as f32; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:110:19 [INFO] [stderr] | [INFO] [stderr] 110 | let shifted = (x1>>1) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(x1>>1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:152:14 [INFO] [stderr] | [INFO] [stderr] 152 | let x1 = x1 as i16; [INFO] [stderr] | ^^^^^^^^^ help: try: `i16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:153:14 [INFO] [stderr] | [INFO] [stderr] 153 | let x2 = x2 as i16; [INFO] [stderr] | ^^^^^^^^^ help: try: `i16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:159:14 [INFO] [stderr] | [INFO] [stderr] 159 | let x1 = x1 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/blend.rs:160:14 [INFO] [stderr] | [INFO] [stderr] 160 | let x2 = x2 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | let max: f32 = max as f32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | let c: f32 = b as f32; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | let mut r = channels[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(channels[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | let mut g = channels[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(channels[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | let mut b = channels[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(channels[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustaops/mod.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | r = r + (depth * 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `r += (depth * 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustaops/mod.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | g = g + depth; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `g += depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | let f = b as f32; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rustaops/mod.rs:74:62 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn fill_with_channels(width: u32, height: u32, channels: &[u8; 4]) -> ImageBuffer, Vec> [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let a = channels[3] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | let r = ((channels[0] as f32) * a / 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | let g = ((channels[1] as f32) * a / 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:79:14 [INFO] [stderr] | [INFO] [stderr] 79 | let b = ((channels[2] as f32) * a / 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | let fg_c = fg_data[i] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(fg_data[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:121:24 [INFO] [stderr] | [INFO] [stderr] 121 | let bg_c = bg_data[i] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(bg_data[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rustaops/mod.rs:272:21 [INFO] [stderr] | [INFO] [stderr] 272 | fn rgb_to_hls(rgba: &[u8; 4]) -> [f32; 3] { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | let r = rgba[0] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(rgba[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | let g = rgba[1] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(rgba[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rustaops/mod.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | let b = rgba[2] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(rgba[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustaops/mod.rs:284:8 [INFO] [stderr] | [INFO] [stderr] 284 | if max == min { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(max - min).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustaops/mod.rs:284:8 [INFO] [stderr] | [INFO] [stderr] 284 | if max == min { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustaops/mod.rs:295:8 [INFO] [stderr] | [INFO] [stderr] 295 | if r == max { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(r - max).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustaops/mod.rs:295:8 [INFO] [stderr] | [INFO] [stderr] 295 | if r == max { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustaops/mod.rs:297:15 [INFO] [stderr] | [INFO] [stderr] 297 | } else if g == max { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(g - max).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustaops/mod.rs:297:15 [INFO] [stderr] | [INFO] [stderr] 297 | } else if g == max { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:8:59 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn validate_filter_type(filter: &str, filter_strings: &Vec<&str>, filter_types: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:8:85 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn validate_filter_type(filter: &str, filter_strings: &Vec<&str>, filter_types: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[FilterType]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustagram`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4061bb0bce5717637f80d9cfaeb4ed6944e5d8cc74eebd7c209846c8d26558f0"` [INFO] running `"docker" "rm" "-f" "4061bb0bce5717637f80d9cfaeb4ed6944e5d8cc74eebd7c209846c8d26558f0"` [INFO] [stdout] 4061bb0bce5717637f80d9cfaeb4ed6944e5d8cc74eebd7c209846c8d26558f0