[INFO] updating cached repository h3nnn4n/smart-panda [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/h3nnn4n/smart-panda [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/h3nnn4n/smart-panda" "work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/smart-panda"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/smart-panda'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/h3nnn4n/smart-panda" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/smart-panda"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/smart-panda'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3dee3aa06dc3f1f79ac7cdbc6ccacd4e0dc92bd7 [INFO] sha for GitHub repo h3nnn4n/smart-panda: 3dee3aa06dc3f1f79ac7cdbc6ccacd4e0dc92bd7 [INFO] validating manifest of h3nnn4n/smart-panda on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of h3nnn4n/smart-panda on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing h3nnn4n/smart-panda [INFO] finished frobbing h3nnn4n/smart-panda [INFO] frobbed toml for h3nnn4n/smart-panda written to work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/smart-panda/Cargo.toml [INFO] started frobbing h3nnn4n/smart-panda [INFO] finished frobbing h3nnn4n/smart-panda [INFO] frobbed toml for h3nnn4n/smart-panda written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/smart-panda/Cargo.toml [INFO] crate h3nnn4n/smart-panda has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting h3nnn4n/smart-panda against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/smart-panda:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c941e092913ba1ccd70c509bdea6576f27d52477b26cb87fffceb1720c4b7af5 [INFO] running `"docker" "start" "-a" "c941e092913ba1ccd70c509bdea6576f27d52477b26cb87fffceb1720c4b7af5"` [INFO] [stderr] Checking c_vec v1.3.1 [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking smart-panda v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/piece.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/piece.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:118:16 [INFO] [stderr] | [INFO] [stderr] 118 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 119 | | return false; [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:126:16 [INFO] [stderr] | [INFO] [stderr] 126 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 127 | | return false; [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.height` [INFO] [stderr] --> src/board.rs:241:21 [INFO] [stderr] | [INFO] [stderr] 241 | for i in 0..self.height - 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:272:16 [INFO] [stderr] | [INFO] [stderr] 272 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 273 | | return false; [INFO] [stderr] 274 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:296:16 [INFO] [stderr] | [INFO] [stderr] 296 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 297 | | return false; [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:329:16 [INFO] [stderr] | [INFO] [stderr] 329 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 330 | | return false; [INFO] [stderr] 331 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:362:16 [INFO] [stderr] | [INFO] [stderr] 362 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 363 | | return false; [INFO] [stderr] 364 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:416:16 [INFO] [stderr] | [INFO] [stderr] 416 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 417 | | return false; [INFO] [stderr] 418 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `moves` [INFO] [stderr] --> src/board.rs:426:22 [INFO] [stderr] | [INFO] [stderr] 426 | for j in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 426 | for (j, ) in moves.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `moves`. [INFO] [stderr] --> src/board.rs:437:18 [INFO] [stderr] | [INFO] [stderr] 437 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 437 | for in &moves { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:446:16 [INFO] [stderr] | [INFO] [stderr] 446 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 447 | | return false; [INFO] [stderr] 448 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `moves` [INFO] [stderr] --> src/board.rs:456:22 [INFO] [stderr] | [INFO] [stderr] 456 | for j in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 456 | for (j, ) in moves.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `moves`. [INFO] [stderr] --> src/board.rs:467:18 [INFO] [stderr] | [INFO] [stderr] 467 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 467 | for in &moves { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:118:16 [INFO] [stderr] | [INFO] [stderr] 118 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 119 | | return false; [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:126:16 [INFO] [stderr] | [INFO] [stderr] 126 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 127 | | return false; [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.height` [INFO] [stderr] --> src/board.rs:241:21 [INFO] [stderr] | [INFO] [stderr] 241 | for i in 0..self.height - 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:272:16 [INFO] [stderr] | [INFO] [stderr] 272 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 273 | | return false; [INFO] [stderr] 274 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:296:16 [INFO] [stderr] | [INFO] [stderr] 296 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 297 | | return false; [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:329:16 [INFO] [stderr] | [INFO] [stderr] 329 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 330 | | return false; [INFO] [stderr] 331 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:362:16 [INFO] [stderr] | [INFO] [stderr] 362 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 363 | | return false; [INFO] [stderr] 364 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:416:16 [INFO] [stderr] | [INFO] [stderr] 416 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 417 | | return false; [INFO] [stderr] 418 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `moves` [INFO] [stderr] --> src/board.rs:426:22 [INFO] [stderr] | [INFO] [stderr] 426 | for j in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 426 | for (j, ) in moves.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `moves`. [INFO] [stderr] --> src/board.rs:437:18 [INFO] [stderr] | [INFO] [stderr] 437 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 437 | for in &moves { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/board.rs:446:16 [INFO] [stderr] | [INFO] [stderr] 446 | if let None = self.active_piece { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 447 | | return false; [INFO] [stderr] 448 | | } [INFO] [stderr] | |_________- help: try this: `if self.active_piece.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `moves` [INFO] [stderr] --> src/board.rs:456:22 [INFO] [stderr] | [INFO] [stderr] 456 | for j in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 456 | for (j, ) in moves.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `moves`. [INFO] [stderr] --> src/board.rs:467:18 [INFO] [stderr] | [INFO] [stderr] 467 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 467 | for in &moves { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/board.rs:669:17 [INFO] [stderr] | [INFO] [stderr] 669 | assert!(board.has_active_piece() == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!board.has_active_piece()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/board.rs:676:17 [INFO] [stderr] | [INFO] [stderr] 676 | assert!(board.has_active_piece() == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!board.has_active_piece()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.39s [INFO] running `"docker" "inspect" "c941e092913ba1ccd70c509bdea6576f27d52477b26cb87fffceb1720c4b7af5"` [INFO] running `"docker" "rm" "-f" "c941e092913ba1ccd70c509bdea6576f27d52477b26cb87fffceb1720c4b7af5"` [INFO] [stdout] c941e092913ba1ccd70c509bdea6576f27d52477b26cb87fffceb1720c4b7af5