[INFO] updating cached repository h3nnn4n/rusty-rsa [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/h3nnn4n/rusty-rsa [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/h3nnn4n/rusty-rsa" "work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/rusty-rsa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/rusty-rsa'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/h3nnn4n/rusty-rsa" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/rusty-rsa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/rusty-rsa'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ebb9b3c99665836799075a4fe484b8d3fd80960d [INFO] sha for GitHub repo h3nnn4n/rusty-rsa: ebb9b3c99665836799075a4fe484b8d3fd80960d [INFO] validating manifest of h3nnn4n/rusty-rsa on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of h3nnn4n/rusty-rsa on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing h3nnn4n/rusty-rsa [INFO] finished frobbing h3nnn4n/rusty-rsa [INFO] frobbed toml for h3nnn4n/rusty-rsa written to work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/rusty-rsa/Cargo.toml [INFO] started frobbing h3nnn4n/rusty-rsa [INFO] finished frobbing h3nnn4n/rusty-rsa [INFO] frobbed toml for h3nnn4n/rusty-rsa written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/rusty-rsa/Cargo.toml [INFO] crate h3nnn4n/rusty-rsa has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting h3nnn4n/rusty-rsa against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/rusty-rsa:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d31c236ddfa4254dd38e9a3b28bd2a919a722307a22c18c03820ab0b01e02778 [INFO] running `"docker" "start" "-a" "d31c236ddfa4254dd38e9a3b28bd2a919a722307a22c18c03820ab0b01e02778"` [INFO] [stderr] Compiling gmp-mpfr-sys v1.1.5 [INFO] [stderr] Compiling rug v1.1.0 [INFO] [stderr] Checking rsa_lixo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | let (inv, _, g) = modular_inv(denom.clone(), m.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | let z = (Integer::from(num.clone().square() * inv.clone().square()) - p.0.clone() - q.0.clone()) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let mut k = k_.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | let mut p = p_.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut b = Integer::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | let mut p = Integer::from(0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | let mut i = Integer::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | let (p, q) = pollard_rho_step(n.clone(), x); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | let mut y = x.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | let mut d: Integer = Integer::from(1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:317:17 [INFO] [stderr] | [INFO] [stderr] 317 | let (p, q) = pollard_rho_step(n.clone(), x); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:270:17 [INFO] [stderr] | [INFO] [stderr] 270 | let mut y = x.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:271:17 [INFO] [stderr] | [INFO] [stderr] 271 | let mut d: Integer = Integer::from(1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:389:17 [INFO] [stderr] | [INFO] [stderr] 389 | let (p, q) = pollard_rho_step(n.clone(), x); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:353:17 [INFO] [stderr] | [INFO] [stderr] 353 | let mut y = x.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:354:17 [INFO] [stderr] | [INFO] [stderr] 354 | let mut d: Integer; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | let g = |x: Integer| Integer::from(Integer::from(&x * &x) + &k) % n.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | let e: u32 = s.to_u32().unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:491:9 [INFO] [stderr] | [INFO] [stderr] 491 | let p = b.pow(e); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:530:13 [INFO] [stderr] | [INFO] [stderr] 530 | let mut x = power(a, d, n.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:531:13 [INFO] [stderr] | [INFO] [stderr] 531 | let mut y = Integer::from(0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:25:10 [INFO] [stderr] | [INFO] [stderr] 25 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | let (inv, _, g) = modular_inv(denom, m); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | let z = (num * inv * num * inv - p.0 - q.0) % m; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:71:73 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn elliptic_mul(mut k: i64, mut p: (i64, i64, i64), a: i64, b: i64, m: i64) -> (i64, i64, i64) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let mut r = (0, 1, 0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | let mut b = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/primes.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | let mut d: i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/primes.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | let g = |x: i64| (x.pow(2) + k) % n; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/primes.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | let mut x = power(a, d, n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/primes.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | let mut y = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/primes.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | let a = rng.gen_range(2, n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rsa.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | let d = mod_inv(e.clone(), tot.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rsa.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | let d = mod_inv(e.clone(), tot.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | let (inv, _, g) = modular_inv(denom.clone(), m.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | let z = (Integer::from(num.clone().square() * inv.clone().square()) - p.0.clone() - q.0.clone()) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let mut k = k_.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | let mut p = p_.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut b = Integer::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | let mut p = Integer::from(0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/big_lenstra.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | let mut i = Integer::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | let (p, q) = pollard_rho_step(n.clone(), x); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | let mut y = x.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | let mut d: Integer = Integer::from(1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:317:17 [INFO] [stderr] | [INFO] [stderr] 317 | let (p, q) = pollard_rho_step(n.clone(), x); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:270:17 [INFO] [stderr] | [INFO] [stderr] 270 | let mut y = x.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:271:17 [INFO] [stderr] | [INFO] [stderr] 271 | let mut d: Integer = Integer::from(1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:389:17 [INFO] [stderr] | [INFO] [stderr] 389 | let (p, q) = pollard_rho_step(n.clone(), x); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:353:17 [INFO] [stderr] | [INFO] [stderr] 353 | let mut y = x.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:354:17 [INFO] [stderr] | [INFO] [stderr] 354 | let mut d: Integer; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | let g = |x: Integer| Integer::from(Integer::from(&x * &x) + &k) % n.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | let e: u32 = s.to_u32().unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:491:9 [INFO] [stderr] | [INFO] [stderr] 491 | let p = b.pow(e); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:530:13 [INFO] [stderr] | [INFO] [stderr] 530 | let mut x = power(a, d, n.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_primes.rs:531:13 [INFO] [stderr] | [INFO] [stderr] 531 | let mut y = Integer::from(0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:25:10 [INFO] [stderr] | [INFO] [stderr] 25 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | let (x, y, g) = modular_inv(b, r); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | let (inv, _, g) = modular_inv(denom, m); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | let z = (num * inv * num * inv - p.0 - q.0) % m; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:71:73 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn elliptic_mul(mut k: i64, mut p: (i64, i64, i64), a: i64, b: i64, m: i64) -> (i64, i64, i64) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let mut r = (0, 1, 0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lenstra.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | let mut b = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/primes.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | let mut d: i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/primes.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | let g = |x: i64| (x.pow(2) + k) % n; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/primes.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | let mut x = power(a, d, n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/primes.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | let mut y = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/primes.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | let a = rng.gen_range(2, n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rsa.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | let d = mod_inv(e.clone(), tot.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rsa.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | let d = mod_inv(e.clone(), tot.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::gmp_mpfr_sys::gmp` [INFO] [stderr] --> src/big_lenstra.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use self::gmp_mpfr_sys::gmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Rng`, `thread_rng` [INFO] [stderr] --> src/big_lenstra.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | use self::rand::{thread_rng, Rng}; [INFO] [stderr] | ^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::rug::rand::RandState` [INFO] [stderr] --> src/big_lenstra.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use self::rug::rand::RandState; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/big_lenstra.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/big_primes.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | / if gmp::mpz_cmp_ui(a_, 0) == 0 { [INFO] [stderr] 42 | | if !factors.contains(&p) { [INFO] [stderr] 43 | | factors.push(p.clone()); [INFO] [stderr] 44 | | factors.push(x.clone() / p.clone()); [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | if gmp::mpz_cmp_ui(a_, 0) == 0 && !factors.contains(&p) { [INFO] [stderr] 42 | factors.push(p.clone()); [INFO] [stderr] 43 | factors.push(x.clone() / p.clone()); [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | return (one, n.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(one, n.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | return (d.clone(), n.clone() / d.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(d.clone(), n.clone() / d.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | return (one, n.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(one, n.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | return (d.clone(), n.clone() / d.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(d.clone(), n.clone() / d.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:375:13 [INFO] [stderr] | [INFO] [stderr] 375 | return (one, n.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(one, n.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | return (d.clone(), n.clone() / d.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(d.clone(), n.clone() / d.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:543:5 [INFO] [stderr] | [INFO] [stderr] 543 | return if y == 1 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if y == 1 { true } else { false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:569:5 [INFO] [stderr] | [INFO] [stderr] 569 | return is_prime(nn, k); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `is_prime(nn, k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/primes.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | return (1, n); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(1, n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/primes.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | return (d, n / d); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(d, n / d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/primes.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | return if y == 1 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if y == 1 { true } else { false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rsa.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | return private; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `private` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::gmp_mpfr_sys::gmp` [INFO] [stderr] --> src/big_lenstra.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use self::gmp_mpfr_sys::gmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Rng`, `thread_rng` [INFO] [stderr] --> src/big_lenstra.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | use self::rand::{thread_rng, Rng}; [INFO] [stderr] | ^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::rug::rand::RandState` [INFO] [stderr] --> src/big_lenstra.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use self::rug::rand::RandState; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/big_lenstra.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/big_primes.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | / if gmp::mpz_cmp_ui(a_, 0) == 0 { [INFO] [stderr] 42 | | if !factors.contains(&p) { [INFO] [stderr] 43 | | factors.push(p.clone()); [INFO] [stderr] 44 | | factors.push(x.clone() / p.clone()); [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | if gmp::mpz_cmp_ui(a_, 0) == 0 && !factors.contains(&p) { [INFO] [stderr] 42 | factors.push(p.clone()); [INFO] [stderr] 43 | factors.push(x.clone() / p.clone()); [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | return (one, n.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(one, n.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | return (d.clone(), n.clone() / d.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(d.clone(), n.clone() / d.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | return (one, n.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(one, n.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | return (d.clone(), n.clone() / d.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(d.clone(), n.clone() / d.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:375:13 [INFO] [stderr] | [INFO] [stderr] 375 | return (one, n.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(one, n.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | return (d.clone(), n.clone() / d.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(d.clone(), n.clone() / d.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:543:5 [INFO] [stderr] | [INFO] [stderr] 543 | return if y == 1 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if y == 1 { true } else { false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:569:5 [INFO] [stderr] | [INFO] [stderr] 569 | return is_prime(nn, k); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `is_prime(nn, k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/primes.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | return (1, n); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(1, n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/primes.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | return (d, n / d); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(d, n / d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/primes.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | return if y == 1 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if y == 1 { true } else { false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rsa.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | return private; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `private` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/tests.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / mod tests { [INFO] [stderr] 14 | | use super::*; [INFO] [stderr] 15 | | [INFO] [stderr] 16 | | #[test] [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rng` [INFO] [stderr] --> src/big_lenstra.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ^^^ help: consider using `_rng` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `pp` is never read [INFO] [stderr] --> src/big_lenstra.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | let mut pp = Integer::from(2); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/big_lenstra.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/big_lenstra.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / let denom; [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | if p.0 == q.0 { [INFO] [stderr] 45 | | if (p.1.clone() + q.1) % m.clone() == 0 { [INFO] [stderr] ... | [INFO] [stderr] 53 | | denom = (q.0.clone() - p.0.clone()) % m.clone(); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let denom = if p.0 == q.0 { ..; (2 * p.1.clone()) % m.clone() } else { ..; (q.0.clone() - p.0.clone()) % m.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_lenstra.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | let z = (Integer::from(num.clone().square() * inv.clone().square()) - p.0.clone() - q.0.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `num.clone().square() * inv.clone().square()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_lenstra.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | g = Integer::from(4 * a.clone().pow(3) + 27 * b.clone().pow(2)).gcd(&n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `4 * a.clone().pow(3) + 27 * b.clone().pow(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | let mut stop = Integer::from(x.clone().sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `x.clone().sqrt()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:86:16 [INFO] [stderr] | [INFO] [stderr] 86 | let stop = Integer::from(x.clone().sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `x.clone().sqrt()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | p = Integer::from(&p + Integer::from(2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `&p + Integer::from(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | let mut b2 = Integer::from(Integer::from(&a * &a) - &n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&a * &a) - &n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:136:18 [INFO] [stderr] | [INFO] [stderr] 136 | factors.push(Integer::from(&a - Integer::from(b2.sqrt_ref()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `&a - Integer::from(b2.sqrt_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:137:18 [INFO] [stderr] | [INFO] [stderr] 137 | factors.push(Integer::from(&a + Integer::from(b2.sqrt_ref()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `&a + Integer::from(b2.sqrt_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:154:18 [INFO] [stderr] | [INFO] [stderr] 154 | let mut b2 = Integer::from(Integer::from(&a * &a) - &n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&a * &a) - &n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:158:14 [INFO] [stderr] | [INFO] [stderr] 158 | b2 = Integer::from(Integer::from(&a * &a) - &n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&a * &a) - &n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:161:18 [INFO] [stderr] | [INFO] [stderr] 161 | factors.push(Integer::from(&a - Integer::from(b2.sqrt_ref()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `&a - Integer::from(b2.sqrt_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | factors.push(Integer::from(&a + Integer::from(b2.sqrt_ref()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `&a + Integer::from(b2.sqrt_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/big_primes.rs:185:44 [INFO] [stderr] | [INFO] [stderr] 185 | let mut x = get_number_with_n_bits(s as i64); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/big_primes.rs:269:44 [INFO] [stderr] | [INFO] [stderr] 269 | let mut x = get_number_with_n_bits(s as i64); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/big_primes.rs:352:44 [INFO] [stderr] | [INFO] [stderr] 352 | let mut x = get_number_with_n_bits(s as i64); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:356:30 [INFO] [stderr] | [INFO] [stderr] 356 | let g = |x: Integer| Integer::from(Integer::from(&x * &x) + &k) % n.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&x * &x) + &k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:366:17 [INFO] [stderr] | [INFO] [stderr] 366 | d = Integer::from(Integer::from(&x - &y).abs()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&x - &y).abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/big_primes.rs:452:12 [INFO] [stderr] | [INFO] [stderr] 452 | if value.significant_bits() as i64 == n_bits { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(value.significant_bits())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:516:22 [INFO] [stderr] | [INFO] [stderr] 516 | result = Integer::from(Integer::from(&result * &power) % &m); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&result * &power) % &m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:519:17 [INFO] [stderr] | [INFO] [stderr] 519 | power = Integer::from(Integer::from(&power * &power) % &m); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&power * &power) % &m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/big_primes.rs:543:12 [INFO] [stderr] | [INFO] [stderr] 543 | return if y == 1 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `y == 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lenstra.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / let denom; [INFO] [stderr] 47 | | [INFO] [stderr] 48 | | if p.0 == q.0 { [INFO] [stderr] 49 | | if (p.1 + q.1) % m == 0 { [INFO] [stderr] ... | [INFO] [stderr] 57 | | denom = (q.0 - p.0) % m; [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let denom = if p.0 == q.0 { ..; (2 * p.1) % m } else { ..; (q.0 - p.0) % m };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lenstra.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | k = k / 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/primes.rs:199:12 [INFO] [stderr] | [INFO] [stderr] 199 | return if y == 1 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `y == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `n_bits / 8` [INFO] [stderr] --> src/rsa.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | let n_bytes = n_bits / 8 - 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/rsa.rs:24:12 [INFO] [stderr] | [INFO] [stderr] 24 | if bytes_read <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using bytes_read == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/rsa.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | out_file.write(&digits).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/rsa.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if bytes_read <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using bytes_read == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/rsa.rs:219:15 [INFO] [stderr] | [INFO] [stderr] 219 | let tot = Integer::from(Integer::from(&p - 1) * Integer::from(&q - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&p - 1) * Integer::from(&q - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/rsa.rs:249:19 [INFO] [stderr] | [INFO] [stderr] 249 | let tot = Integer::from(Integer::from(&p - 1) * Integer::from(&q - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&p - 1) * Integer::from(&q - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/rsa.rs:254:12 [INFO] [stderr] | [INFO] [stderr] 254 | if n.significant_bits() as i64 == n_bits { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(n.significant_bits())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rsa_lixo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `rng` [INFO] [stderr] --> src/big_lenstra.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ^^^ help: consider using `_rng` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `pp` is never read [INFO] [stderr] --> src/big_lenstra.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | let mut pp = Integer::from(2); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `inverse` [INFO] [stderr] --> src/tests.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | Ok(inverse) => true, [INFO] [stderr] | ^^^^^^^ help: consider using `_inverse` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/big_lenstra.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/big_lenstra.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / let denom; [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | if p.0 == q.0 { [INFO] [stderr] 45 | | if (p.1.clone() + q.1) % m.clone() == 0 { [INFO] [stderr] ... | [INFO] [stderr] 53 | | denom = (q.0.clone() - p.0.clone()) % m.clone(); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let denom = if p.0 == q.0 { ..; (2 * p.1.clone()) % m.clone() } else { ..; (q.0.clone() - p.0.clone()) % m.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_lenstra.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | let z = (Integer::from(num.clone().square() * inv.clone().square()) - p.0.clone() - q.0.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `num.clone().square() * inv.clone().square()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_lenstra.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | g = Integer::from(4 * a.clone().pow(3) + 27 * b.clone().pow(2)).gcd(&n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `4 * a.clone().pow(3) + 27 * b.clone().pow(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/big_lenstra.rs:181:29 [INFO] [stderr] | [INFO] [stderr] 181 | let found = match f { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 182 | | Some(_) => true, [INFO] [stderr] 183 | | None => false, [INFO] [stderr] 184 | | }; [INFO] [stderr] | |_________________^ help: try this: `f.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | let mut stop = Integer::from(x.clone().sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `x.clone().sqrt()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:86:16 [INFO] [stderr] | [INFO] [stderr] 86 | let stop = Integer::from(x.clone().sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `x.clone().sqrt()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | p = Integer::from(&p + Integer::from(2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `&p + Integer::from(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | let mut b2 = Integer::from(Integer::from(&a * &a) - &n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&a * &a) - &n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:136:18 [INFO] [stderr] | [INFO] [stderr] 136 | factors.push(Integer::from(&a - Integer::from(b2.sqrt_ref()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `&a - Integer::from(b2.sqrt_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:137:18 [INFO] [stderr] | [INFO] [stderr] 137 | factors.push(Integer::from(&a + Integer::from(b2.sqrt_ref()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `&a + Integer::from(b2.sqrt_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:154:18 [INFO] [stderr] | [INFO] [stderr] 154 | let mut b2 = Integer::from(Integer::from(&a * &a) - &n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&a * &a) - &n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:158:14 [INFO] [stderr] | [INFO] [stderr] 158 | b2 = Integer::from(Integer::from(&a * &a) - &n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&a * &a) - &n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:161:18 [INFO] [stderr] | [INFO] [stderr] 161 | factors.push(Integer::from(&a - Integer::from(b2.sqrt_ref()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `&a - Integer::from(b2.sqrt_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | factors.push(Integer::from(&a + Integer::from(b2.sqrt_ref()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `&a + Integer::from(b2.sqrt_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/big_primes.rs:185:44 [INFO] [stderr] | [INFO] [stderr] 185 | let mut x = get_number_with_n_bits(s as i64); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/big_primes.rs:269:44 [INFO] [stderr] | [INFO] [stderr] 269 | let mut x = get_number_with_n_bits(s as i64); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/big_primes.rs:352:44 [INFO] [stderr] | [INFO] [stderr] 352 | let mut x = get_number_with_n_bits(s as i64); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:356:30 [INFO] [stderr] | [INFO] [stderr] 356 | let g = |x: Integer| Integer::from(Integer::from(&x * &x) + &k) % n.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&x * &x) + &k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:366:17 [INFO] [stderr] | [INFO] [stderr] 366 | d = Integer::from(Integer::from(&x - &y).abs()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&x - &y).abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/big_primes.rs:452:12 [INFO] [stderr] | [INFO] [stderr] 452 | if value.significant_bits() as i64 == n_bits { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(value.significant_bits())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:516:22 [INFO] [stderr] | [INFO] [stderr] 516 | result = Integer::from(Integer::from(&result * &power) % &m); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&result * &power) % &m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/big_primes.rs:519:17 [INFO] [stderr] | [INFO] [stderr] 519 | power = Integer::from(Integer::from(&power * &power) % &m); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&power * &power) % &m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/big_primes.rs:543:12 [INFO] [stderr] | [INFO] [stderr] 543 | return if y == 1 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `y == 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lenstra.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / let denom; [INFO] [stderr] 47 | | [INFO] [stderr] 48 | | if p.0 == q.0 { [INFO] [stderr] 49 | | if (p.1 + q.1) % m == 0 { [INFO] [stderr] ... | [INFO] [stderr] 57 | | denom = (q.0 - p.0) % m; [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let denom = if p.0 == q.0 { ..; (2 * p.1) % m } else { ..; (q.0 - p.0) % m };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lenstra.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | k = k / 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/primes.rs:199:12 [INFO] [stderr] | [INFO] [stderr] 199 | return if y == 1 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `y == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `n_bits / 8` [INFO] [stderr] --> src/rsa.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | let n_bytes = n_bits / 8 - 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/rsa.rs:24:12 [INFO] [stderr] | [INFO] [stderr] 24 | if bytes_read <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using bytes_read == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/rsa.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | out_file.write(&digits).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/rsa.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if bytes_read <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using bytes_read == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/rsa.rs:219:15 [INFO] [stderr] | [INFO] [stderr] 219 | let tot = Integer::from(Integer::from(&p - 1) * Integer::from(&q - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&p - 1) * Integer::from(&q - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/rsa.rs:249:19 [INFO] [stderr] | [INFO] [stderr] 249 | let tot = Integer::from(Integer::from(&p - 1) * Integer::from(&q - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `Integer::from(&p - 1) * Integer::from(&q - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/rsa.rs:254:12 [INFO] [stderr] | [INFO] [stderr] 254 | if n.significant_bits() as i64 == n_bits { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(n.significant_bits())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rsa_lixo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d31c236ddfa4254dd38e9a3b28bd2a919a722307a22c18c03820ab0b01e02778"` [INFO] running `"docker" "rm" "-f" "d31c236ddfa4254dd38e9a3b28bd2a919a722307a22c18c03820ab0b01e02778"` [INFO] [stdout] d31c236ddfa4254dd38e9a3b28bd2a919a722307a22c18c03820ab0b01e02778