[INFO] updating cached repository h3nnn4n/anti-sheep [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/h3nnn4n/anti-sheep [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/h3nnn4n/anti-sheep" "work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/anti-sheep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/anti-sheep'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/h3nnn4n/anti-sheep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/anti-sheep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/anti-sheep'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a858d3b2d235f0d5e0312a8e9508b010abda448b [INFO] sha for GitHub repo h3nnn4n/anti-sheep: a858d3b2d235f0d5e0312a8e9508b010abda448b [INFO] validating manifest of h3nnn4n/anti-sheep on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of h3nnn4n/anti-sheep on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing h3nnn4n/anti-sheep [INFO] finished frobbing h3nnn4n/anti-sheep [INFO] frobbed toml for h3nnn4n/anti-sheep written to work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/anti-sheep/Cargo.toml [INFO] started frobbing h3nnn4n/anti-sheep [INFO] finished frobbing h3nnn4n/anti-sheep [INFO] frobbed toml for h3nnn4n/anti-sheep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h3nnn4n/anti-sheep/Cargo.toml [INFO] crate h3nnn4n/anti-sheep has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting h3nnn4n/anti-sheep against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/h3nnn4n/anti-sheep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 531ab310a565056cd4afa2652ecf1f290d5058c40b6b9cc36c9f900dc34b84c4 [INFO] running `"docker" "start" "-a" "531ab310a565056cd4afa2652ecf1f290d5058c40b6b9cc36c9f900dc34b84c4"` [INFO] [stderr] Checking anti-sheep v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cube.rs:362:33 [INFO] [stderr] | [INFO] [stderr] 362 | let a = *reverse_path.get(&k).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cube.rs:362:33 [INFO] [stderr] | [INFO] [stderr] 362 | let a = *reverse_path.get(&k).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cube.rs:178:28 [INFO] [stderr] | [INFO] [stderr] 178 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 179 | | if !forward_visited.contains(&c2.to_i()) { [INFO] [stderr] 180 | | forward_queue.push_back((c2.to_i(), *m)); [INFO] [stderr] 181 | | forward_path.insert(c2.to_i(), (c.to_i(), *m)); [INFO] [stderr] 182 | | forward_visited.insert(c2.to_i()); [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 178 | } else if !forward_visited.contains(&c2.to_i()) { [INFO] [stderr] 179 | forward_queue.push_back((c2.to_i(), *m)); [INFO] [stderr] 180 | forward_path.insert(c2.to_i(), (c.to_i(), *m)); [INFO] [stderr] 181 | forward_visited.insert(c2.to_i()); [INFO] [stderr] 182 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cube.rs:209:28 [INFO] [stderr] | [INFO] [stderr] 209 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 210 | | if !reverse_visited.contains(&c2.to_i()) { [INFO] [stderr] 211 | | reverse_queue.push_back((c2.to_i(), *m)); [INFO] [stderr] 212 | | reverse_path.insert(c2.to_i(), (c.to_i(), *m)); [INFO] [stderr] 213 | | reverse_visited.insert(c2.to_i()); [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 209 | } else if !reverse_visited.contains(&c2.to_i()) { [INFO] [stderr] 210 | reverse_queue.push_back((c2.to_i(), *m)); [INFO] [stderr] 211 | reverse_path.insert(c2.to_i(), (c.to_i(), *m)); [INFO] [stderr] 212 | reverse_visited.insert(c2.to_i()); [INFO] [stderr] 213 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cube.rs:309:28 [INFO] [stderr] | [INFO] [stderr] 309 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 310 | | if !reverse_visited.contains(&c2.to_i()) { [INFO] [stderr] 311 | | reverse_queue.push_back((c2.to_i(), *m)); [INFO] [stderr] 312 | | reverse_path.insert(c2.to_i(), (c.to_i(), *m)); [INFO] [stderr] 313 | | reverse_visited.insert(c2.to_i()); [INFO] [stderr] 314 | | } [INFO] [stderr] 315 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 309 | } else if !reverse_visited.contains(&c2.to_i()) { [INFO] [stderr] 310 | reverse_queue.push_back((c2.to_i(), *m)); [INFO] [stderr] 311 | reverse_path.insert(c2.to_i(), (c.to_i(), *m)); [INFO] [stderr] 312 | reverse_visited.insert(c2.to_i()); [INFO] [stderr] 313 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cube.rs:371:28 [INFO] [stderr] | [INFO] [stderr] 371 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 372 | | if !visited.contains(&c2.to_i()) { [INFO] [stderr] 373 | | q.push_back((c2.to_i(), *m)); [INFO] [stderr] 374 | | reverse_path.insert(c2.to_i(), (c_i, *m)); [INFO] [stderr] 375 | | visited.insert(c2.to_i()); [INFO] [stderr] 376 | | } [INFO] [stderr] 377 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 371 | } else if !visited.contains(&c2.to_i()) { [INFO] [stderr] 372 | q.push_back((c2.to_i(), *m)); [INFO] [stderr] 373 | reverse_path.insert(c2.to_i(), (c_i, *m)); [INFO] [stderr] 374 | visited.insert(c2.to_i()); [INFO] [stderr] 375 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/defs.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 164 | | if seq[k] != seq[k - 1] { [INFO] [stderr] 165 | | seq2.push(seq[k]); [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 163 | } else if seq[k] != seq[k - 1] { [INFO] [stderr] 164 | seq2.push(seq[k]); [INFO] [stderr] 165 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cube.rs:178:28 [INFO] [stderr] | [INFO] [stderr] 178 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 179 | | if !forward_visited.contains(&c2.to_i()) { [INFO] [stderr] 180 | | forward_queue.push_back((c2.to_i(), *m)); [INFO] [stderr] 181 | | forward_path.insert(c2.to_i(), (c.to_i(), *m)); [INFO] [stderr] 182 | | forward_visited.insert(c2.to_i()); [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 178 | } else if !forward_visited.contains(&c2.to_i()) { [INFO] [stderr] 179 | forward_queue.push_back((c2.to_i(), *m)); [INFO] [stderr] 180 | forward_path.insert(c2.to_i(), (c.to_i(), *m)); [INFO] [stderr] 181 | forward_visited.insert(c2.to_i()); [INFO] [stderr] 182 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cube.rs:209:28 [INFO] [stderr] | [INFO] [stderr] 209 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 210 | | if !reverse_visited.contains(&c2.to_i()) { [INFO] [stderr] 211 | | reverse_queue.push_back((c2.to_i(), *m)); [INFO] [stderr] 212 | | reverse_path.insert(c2.to_i(), (c.to_i(), *m)); [INFO] [stderr] 213 | | reverse_visited.insert(c2.to_i()); [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 209 | } else if !reverse_visited.contains(&c2.to_i()) { [INFO] [stderr] 210 | reverse_queue.push_back((c2.to_i(), *m)); [INFO] [stderr] 211 | reverse_path.insert(c2.to_i(), (c.to_i(), *m)); [INFO] [stderr] 212 | reverse_visited.insert(c2.to_i()); [INFO] [stderr] 213 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cube.rs:309:28 [INFO] [stderr] | [INFO] [stderr] 309 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 310 | | if !reverse_visited.contains(&c2.to_i()) { [INFO] [stderr] 311 | | reverse_queue.push_back((c2.to_i(), *m)); [INFO] [stderr] 312 | | reverse_path.insert(c2.to_i(), (c.to_i(), *m)); [INFO] [stderr] 313 | | reverse_visited.insert(c2.to_i()); [INFO] [stderr] 314 | | } [INFO] [stderr] 315 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 309 | } else if !reverse_visited.contains(&c2.to_i()) { [INFO] [stderr] 310 | reverse_queue.push_back((c2.to_i(), *m)); [INFO] [stderr] 311 | reverse_path.insert(c2.to_i(), (c.to_i(), *m)); [INFO] [stderr] 312 | reverse_visited.insert(c2.to_i()); [INFO] [stderr] 313 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cube.rs:371:28 [INFO] [stderr] | [INFO] [stderr] 371 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 372 | | if !visited.contains(&c2.to_i()) { [INFO] [stderr] 373 | | q.push_back((c2.to_i(), *m)); [INFO] [stderr] 374 | | reverse_path.insert(c2.to_i(), (c_i, *m)); [INFO] [stderr] 375 | | visited.insert(c2.to_i()); [INFO] [stderr] 376 | | } [INFO] [stderr] 377 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 371 | } else if !visited.contains(&c2.to_i()) { [INFO] [stderr] 372 | q.push_back((c2.to_i(), *m)); [INFO] [stderr] 373 | reverse_path.insert(c2.to_i(), (c_i, *m)); [INFO] [stderr] 374 | visited.insert(c2.to_i()); [INFO] [stderr] 375 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/defs.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 164 | | if seq[k] != seq[k - 1] { [INFO] [stderr] 165 | | seq2.push(seq[k]); [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 163 | } else if seq[k] != seq[k - 1] { [INFO] [stderr] 164 | seq2.push(seq[k]); [INFO] [stderr] 165 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/cube.rs:101:19 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn from_i(&mut self, (_p, _o): (i64, i64)) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cube.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | if forward_queue.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `forward_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cube.rs:189:16 [INFO] [stderr] | [INFO] [stderr] 189 | if reverse_queue.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `reverse_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cube.rs:227:22 [INFO] [stderr] | [INFO] [stderr] 227 | let a = *forward_path.get(&k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&forward_path[&k]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cube.rs:243:22 [INFO] [stderr] | [INFO] [stderr] 243 | let a = *reverse_path.get(&k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reverse_path[&k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cube.rs:274:16 [INFO] [stderr] | [INFO] [stderr] 274 | if reverse_queue.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `reverse_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cube.rs:300:38 [INFO] [stderr] | [INFO] [stderr] 300 | let a = *reverse_path.get(&k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reverse_path[&k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cube.rs:337:16 [INFO] [stderr] | [INFO] [stderr] 337 | if q.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `q.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cube.rs:362:38 [INFO] [stderr] | [INFO] [stderr] 362 | let a = *reverse_path.get(&k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reverse_path[&k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cube.rs:528:13 [INFO] [stderr] | [INFO] [stderr] 528 | self.o[i] = self.o[i] % 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.o[i] %= 3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/defs.rs:71:15 [INFO] [stderr] | [INFO] [stderr] 71 | MOVES.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/defs.rs:87:15 [INFO] [stderr] | [INFO] [stderr] 87 | MOVES.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `anti-sheep`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/cube.rs:101:19 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn from_i(&mut self, (_p, _o): (i64, i64)) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cube.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | if forward_queue.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `forward_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cube.rs:189:16 [INFO] [stderr] | [INFO] [stderr] 189 | if reverse_queue.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `reverse_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cube.rs:227:22 [INFO] [stderr] | [INFO] [stderr] 227 | let a = *forward_path.get(&k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&forward_path[&k]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cube.rs:243:22 [INFO] [stderr] | [INFO] [stderr] 243 | let a = *reverse_path.get(&k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reverse_path[&k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cube.rs:274:16 [INFO] [stderr] | [INFO] [stderr] 274 | if reverse_queue.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `reverse_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cube.rs:300:38 [INFO] [stderr] | [INFO] [stderr] 300 | let a = *reverse_path.get(&k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reverse_path[&k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cube.rs:337:16 [INFO] [stderr] | [INFO] [stderr] 337 | if q.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `q.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cube.rs:362:38 [INFO] [stderr] | [INFO] [stderr] 362 | let a = *reverse_path.get(&k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reverse_path[&k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cube.rs:528:13 [INFO] [stderr] | [INFO] [stderr] 528 | self.o[i] = self.o[i] % 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.o[i] %= 3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/defs.rs:71:15 [INFO] [stderr] | [INFO] [stderr] 71 | MOVES.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/defs.rs:87:15 [INFO] [stderr] | [INFO] [stderr] 87 | MOVES.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `anti-sheep`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "531ab310a565056cd4afa2652ecf1f290d5058c40b6b9cc36c9f900dc34b84c4"` [INFO] running `"docker" "rm" "-f" "531ab310a565056cd4afa2652ecf1f290d5058c40b6b9cc36c9f900dc34b84c4"` [INFO] [stdout] 531ab310a565056cd4afa2652ecf1f290d5058c40b6b9cc36c9f900dc34b84c4