[INFO] updating cached repository h1romas4/rust-synth-emulation [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/h1romas4/rust-synth-emulation [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/h1romas4/rust-synth-emulation" "work/ex/clippy-test-run/sources/stable/gh/h1romas4/rust-synth-emulation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/h1romas4/rust-synth-emulation'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/h1romas4/rust-synth-emulation" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h1romas4/rust-synth-emulation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h1romas4/rust-synth-emulation'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7fd94a709684794281927ed6f2c4e2d01c4ab274 [INFO] sha for GitHub repo h1romas4/rust-synth-emulation: 7fd94a709684794281927ed6f2c4e2d01c4ab274 [INFO] validating manifest of h1romas4/rust-synth-emulation on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of h1romas4/rust-synth-emulation on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing h1romas4/rust-synth-emulation [INFO] finished frobbing h1romas4/rust-synth-emulation [INFO] frobbed toml for h1romas4/rust-synth-emulation written to work/ex/clippy-test-run/sources/stable/gh/h1romas4/rust-synth-emulation/Cargo.toml [INFO] started frobbing h1romas4/rust-synth-emulation [INFO] finished frobbing h1romas4/rust-synth-emulation [INFO] frobbed toml for h1romas4/rust-synth-emulation written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/h1romas4/rust-synth-emulation/Cargo.toml [INFO] crate h1romas4/rust-synth-emulation has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting h1romas4/rust-synth-emulation against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/h1romas4/rust-synth-emulation:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6ff8e05c0387a5fae7d1c4761876ce0a9d64b58dd0acfe62cc76ea774875393b [INFO] running `"docker" "start" "-a" "6ff8e05c0387a5fae7d1c4761876ce0a9d64b58dd0acfe62cc76ea774875393b"` [INFO] [stderr] Checking synth v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: All variants have the same prefix: `Fb` [INFO] [stderr] --> src/sn76489/mod.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / enum FeedbackPatterns { [INFO] [stderr] 14 | | // Texas Instruments TMS SN76489N (original) from BBC Micro computer [INFO] [stderr] 15 | | FbBbcmicro = 0x8005, [INFO] [stderr] 16 | | // Texas Instruments TMS SN76489AN (rev. A) from SC-3000H computer [INFO] [stderr] ... | [INFO] [stderr] 19 | | FbSegavdp = 0x0009 [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sn76489/mod.rs:99:43 [INFO] [stderr] | [INFO] [stderr] 99 | self.d_clock = (psg_clock_value & 0x7ffffff) as f32 / 16_f32 / sampling_rate as f32; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x07ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | clock_sn76489 = 3579545; [INFO] [stderr] | ^^^^^^^ help: consider: `3_579_545` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Fb` [INFO] [stderr] --> src/sn76489/mod.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / enum FeedbackPatterns { [INFO] [stderr] 14 | | // Texas Instruments TMS SN76489N (original) from BBC Micro computer [INFO] [stderr] 15 | | FbBbcmicro = 0x8005, [INFO] [stderr] 16 | | // Texas Instruments TMS SN76489AN (rev. A) from SC-3000H computer [INFO] [stderr] ... | [INFO] [stderr] 19 | | FbSegavdp = 0x0009 [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sn76489/mod.rs:99:43 [INFO] [stderr] | [INFO] [stderr] 99 | self.d_clock = (psg_clock_value & 0x7ffffff) as f32 / 16_f32 / sampling_rate as f32; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x07ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | clock_sn76489 = 3579545; [INFO] [stderr] | ^^^^^^^ help: consider: `3_579_545` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/sn76489/mod.rs:134:26 [INFO] [stderr] | [INFO] [stderr] 134 | let data : u16 = data as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(data)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sn76489/mod.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | self.latched_register = ((data >> 4) & 0x07) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((data >> 4) & 0x07)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sn76489/mod.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | | (data & 0xf) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data & 0xf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sn76489/mod.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | | ((data & 0x3f) << 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((data & 0x3f) << 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sn76489/mod.rs:154:66 [INFO] [stderr] | [INFO] [stderr] 154 | self.registers[self.latched_register as usize] = (data & 0x0f) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data & 0x0f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn new(&mut self) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new(&mut self) { [INFO] [stderr] 39 | | // for js [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | self.get_vgm_u8() as u16 + ((self.get_vgm_u8() as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_vgm_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:98:37 [INFO] [stderr] | [INFO] [stderr] 98 | self.get_vgm_u8() as u16 + ((self.get_vgm_u8() as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_vgm_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | self.get_vgm_u8() as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_vgm_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | + ((self.get_vgm_u8() as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_vgm_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:104:16 [INFO] [stderr] | [INFO] [stderr] 104 | + ((self.get_vgm_u8() as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_vgm_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | + ((self.get_vgm_u8() as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_vgm_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/sn76489/mod.rs:134:26 [INFO] [stderr] | [INFO] [stderr] 134 | let data : u16 = data as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(data)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sn76489/mod.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | self.latched_register = ((data >> 4) & 0x07) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((data >> 4) & 0x07)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sn76489/mod.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | | (data & 0xf) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data & 0xf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sn76489/mod.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | | ((data & 0x3f) << 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((data & 0x3f) << 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sn76489/mod.rs:154:66 [INFO] [stderr] | [INFO] [stderr] 154 | self.registers[self.latched_register as usize] = (data & 0x0f) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data & 0x0f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn new(&mut self) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new(&mut self) { [INFO] [stderr] 39 | | // for js [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | self.get_vgm_u8() as u16 + ((self.get_vgm_u8() as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_vgm_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:98:37 [INFO] [stderr] | [INFO] [stderr] 98 | self.get_vgm_u8() as u16 + ((self.get_vgm_u8() as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_vgm_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | self.get_vgm_u8() as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_vgm_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | + ((self.get_vgm_u8() as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_vgm_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:104:16 [INFO] [stderr] | [INFO] [stderr] 104 | + ((self.get_vgm_u8() as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_vgm_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | + ((self.get_vgm_u8() as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_vgm_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.62s [INFO] running `"docker" "inspect" "6ff8e05c0387a5fae7d1c4761876ce0a9d64b58dd0acfe62cc76ea774875393b"` [INFO] running `"docker" "rm" "-f" "6ff8e05c0387a5fae7d1c4761876ce0a9d64b58dd0acfe62cc76ea774875393b"` [INFO] [stdout] 6ff8e05c0387a5fae7d1c4761876ce0a9d64b58dd0acfe62cc76ea774875393b