[INFO] updating cached repository guiqulaxi/life-game-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/guiqulaxi/life-game-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/guiqulaxi/life-game-rust" "work/ex/clippy-test-run/sources/stable/gh/guiqulaxi/life-game-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/guiqulaxi/life-game-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/guiqulaxi/life-game-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guiqulaxi/life-game-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guiqulaxi/life-game-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 18ae7c51882f3926ba2ca33969a1ff0d637b9101 [INFO] sha for GitHub repo guiqulaxi/life-game-rust: 18ae7c51882f3926ba2ca33969a1ff0d637b9101 [INFO] validating manifest of guiqulaxi/life-game-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of guiqulaxi/life-game-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing guiqulaxi/life-game-rust [INFO] finished frobbing guiqulaxi/life-game-rust [INFO] frobbed toml for guiqulaxi/life-game-rust written to work/ex/clippy-test-run/sources/stable/gh/guiqulaxi/life-game-rust/Cargo.toml [INFO] started frobbing guiqulaxi/life-game-rust [INFO] finished frobbing guiqulaxi/life-game-rust [INFO] frobbed toml for guiqulaxi/life-game-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guiqulaxi/life-game-rust/Cargo.toml [INFO] crate guiqulaxi/life-game-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting guiqulaxi/life-game-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/guiqulaxi/life-game-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae472602831658da079248d5e1cc93b0b3a7e6a4ef8bd066580b4539e818d4d1 [INFO] running `"docker" "start" "-a" "ae472602831658da079248d5e1cc93b0b3a7e6a4ef8bd066580b4539e818d4d1"` [INFO] [stderr] Compiling num-traits v0.1.39 [INFO] [stderr] Checking num_cpus v1.5.1 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Checking x11-dl v2.14.0 [INFO] [stderr] Checking gfx_core v0.7.1 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking tempfile v2.1.5 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking rayon v0.8.1 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.8.7 [INFO] [stderr] Checking wayland-client v0.8.7 [INFO] [stderr] Checking wayland-kbd v0.8.0 [INFO] [stderr] Checking wayland-window v0.5.0 [INFO] [stderr] Checking winit v0.6.4 [INFO] [stderr] Checking glutin v0.8.1 [INFO] [stderr] Checking pistoncore-glutin_window v0.37.0 [INFO] [stderr] Checking gfx v0.16.0 [INFO] [stderr] Checking gfx_device_gl v0.14.1 [INFO] [stderr] Checking piston-gfx_texture v0.24.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.40.0 [INFO] [stderr] Checking piston_window v0.66.0 [INFO] [stderr] Checking life_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | height:height, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | width:width, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | world:world, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | height:height, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | width:width, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | world:world, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/game.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | else { [INFO] [stderr] | ______________________^ [INFO] [stderr] 25 | | if self.world[i as usize][j as usize]{ [INFO] [stderr] 26 | | num+=1; [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 24 | else if self.world[i as usize][j as usize]{ [INFO] [stderr] 25 | num+=1; [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `arg` [INFO] [stderr] --> src/main.rs:37:23 [INFO] [stderr] | [INFO] [stderr] 37 | event.update(|arg| { [INFO] [stderr] | ^^^ help: consider using `_arg` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/main.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(Button::Keyboard(key)) = event.press_args() { [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delta_time` [INFO] [stderr] --> src/game.rs:74:31 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn update(&mut self, delta_time: f64) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_delta_time` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `draw_rectange` [INFO] [stderr] --> src/drawing.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn draw_rectange(color: Color, start_x: i32, start_y: i32, width: i32, height: i32, con: &Context, g: &mut G2d) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/game.rs:74:6 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn update(&mut self, delta_time: f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/game.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | else { [INFO] [stderr] | ______________________^ [INFO] [stderr] 25 | | if self.world[i as usize][j as usize]{ [INFO] [stderr] 26 | | num+=1; [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 24 | else if self.world[i as usize][j as usize]{ [INFO] [stderr] 25 | num+=1; [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/drawing.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | (game_coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/drawing.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | BLOCK_SIZE * (width as f64), BLOCK_SIZE * (height as f64)], con.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/drawing.rs:29:55 [INFO] [stderr] | [INFO] [stderr] 29 | BLOCK_SIZE * (width as f64), BLOCK_SIZE * (height as f64)], con.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `arg` [INFO] [stderr] --> src/main.rs:37:23 [INFO] [stderr] | [INFO] [stderr] 37 | event.update(|arg| { [INFO] [stderr] | ^^^ help: consider using `_arg` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/main.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(Button::Keyboard(key)) = event.press_args() { [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delta_time` [INFO] [stderr] --> src/game.rs:74:31 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn update(&mut self, delta_time: f64) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_delta_time` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `draw_rectange` [INFO] [stderr] --> src/drawing.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn draw_rectange(color: Color, start_x: i32, start_y: i32, width: i32, height: i32, con: &Context, g: &mut G2d) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/game.rs:74:6 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn update(&mut self, delta_time: f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/drawing.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | (game_coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/drawing.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | BLOCK_SIZE * (width as f64), BLOCK_SIZE * (height as f64)], con.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/drawing.rs:29:55 [INFO] [stderr] | [INFO] [stderr] 29 | BLOCK_SIZE * (width as f64), BLOCK_SIZE * (height as f64)], con.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 57.92s [INFO] running `"docker" "inspect" "ae472602831658da079248d5e1cc93b0b3a7e6a4ef8bd066580b4539e818d4d1"` [INFO] running `"docker" "rm" "-f" "ae472602831658da079248d5e1cc93b0b3a7e6a4ef8bd066580b4539e818d4d1"` [INFO] [stdout] ae472602831658da079248d5e1cc93b0b3a7e6a4ef8bd066580b4539e818d4d1