[INFO] updating cached repository guillaume-gomez/tilt-shift-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/guillaume-gomez/tilt-shift-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/guillaume-gomez/tilt-shift-rust" "work/ex/clippy-test-run/sources/stable/gh/guillaume-gomez/tilt-shift-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/guillaume-gomez/tilt-shift-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/guillaume-gomez/tilt-shift-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guillaume-gomez/tilt-shift-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guillaume-gomez/tilt-shift-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 98cccafdb805457521ad9b3ab7eac2188ac41ac3 [INFO] sha for GitHub repo guillaume-gomez/tilt-shift-rust: 98cccafdb805457521ad9b3ab7eac2188ac41ac3 [INFO] validating manifest of guillaume-gomez/tilt-shift-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of guillaume-gomez/tilt-shift-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing guillaume-gomez/tilt-shift-rust [INFO] finished frobbing guillaume-gomez/tilt-shift-rust [INFO] frobbed toml for guillaume-gomez/tilt-shift-rust written to work/ex/clippy-test-run/sources/stable/gh/guillaume-gomez/tilt-shift-rust/Cargo.toml [INFO] started frobbing guillaume-gomez/tilt-shift-rust [INFO] finished frobbing guillaume-gomez/tilt-shift-rust [INFO] frobbed toml for guillaume-gomez/tilt-shift-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/guillaume-gomez/tilt-shift-rust/Cargo.toml [INFO] crate guillaume-gomez/tilt-shift-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting guillaume-gomez/tilt-shift-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/guillaume-gomez/tilt-shift-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b3ace28fadb6fd6a0d4ac63f95a2975118f01f473a9a6b80d659b011b933b7d7 [INFO] running `"docker" "start" "-a" "b3ace28fadb6fd6a0d4ac63f95a2975118f01f473a9a6b80d659b011b933b7d7"` [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Checking tilt-shift v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tilt_shift_module.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | img_created [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tilt_shift_module.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | let img_created = ImageBuffer::from_fn(width, height, |x, y| { [INFO] [stderr] | _______________________^ [INFO] [stderr] 15 | | if x >= x_rect && x <= x_rect + width_rect && y >= y_rect && y <= y_rect + height_rect { [INFO] [stderr] 16 | | image::Luma([0u8]) [INFO] [stderr] 17 | | } else { [INFO] [stderr] 18 | | image::Luma([255u8]) [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | }); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tilt_shift_module.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | blended_image [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tilt_shift_module.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | let blended_image = ImageBuffer::from_fn(width, height, |x, y| { [INFO] [stderr] | _________________________^ [INFO] [stderr] 26 | | let pixel_image = original.get_pixel(x, y); [INFO] [stderr] 27 | | let pixel_mask = mask.get_pixel(x, y); [INFO] [stderr] 28 | | image::Rgba([pixel_image.data[0], pixel_image.data[1], pixel_image.data[2], 255 - pixel_mask.data[0]]) [INFO] [stderr] 29 | | }); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tilt_shift_module.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return image::ImageRgba8(final_image_without_saturation_buff).adjust_contrast(contrast); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `image::ImageRgba8(final_image_without_saturation_buff).adjust_contrast(contrast)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:73:65 [INFO] [stderr] | [INFO] [stderr] 73 | tilt_shift_module::create_image(file, &output_file, (current_blur as f32), (current_saturation as f32), y_point_of_interest, height_point_of_interest); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:73:88 [INFO] [stderr] | [INFO] [stderr] 73 | tilt_shift_module::create_image(file, &output_file, (current_blur as f32), (current_saturation as f32), y_point_of_interest, height_point_of_interest); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tilt_shift_module.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | img_created [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tilt_shift_module.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | let img_created = ImageBuffer::from_fn(width, height, |x, y| { [INFO] [stderr] | _______________________^ [INFO] [stderr] 15 | | if x >= x_rect && x <= x_rect + width_rect && y >= y_rect && y <= y_rect + height_rect { [INFO] [stderr] 16 | | image::Luma([0u8]) [INFO] [stderr] 17 | | } else { [INFO] [stderr] 18 | | image::Luma([255u8]) [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | }); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tilt_shift_module.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | blended_image [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tilt_shift_module.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | let blended_image = ImageBuffer::from_fn(width, height, |x, y| { [INFO] [stderr] | _________________________^ [INFO] [stderr] 26 | | let pixel_image = original.get_pixel(x, y); [INFO] [stderr] 27 | | let pixel_mask = mask.get_pixel(x, y); [INFO] [stderr] 28 | | image::Rgba([pixel_image.data[0], pixel_image.data[1], pixel_image.data[2], 255 - pixel_mask.data[0]]) [INFO] [stderr] 29 | | }); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tilt_shift_module.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return image::ImageRgba8(final_image_without_saturation_buff).adjust_contrast(contrast); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `image::ImageRgba8(final_image_without_saturation_buff).adjust_contrast(contrast)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:73:65 [INFO] [stderr] | [INFO] [stderr] 73 | tilt_shift_module::create_image(file, &output_file, (current_blur as f32), (current_saturation as f32), y_point_of_interest, height_point_of_interest); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:73:88 [INFO] [stderr] | [INFO] [stderr] 73 | tilt_shift_module::create_image(file, &output_file, (current_blur as f32), (current_saturation as f32), y_point_of_interest, height_point_of_interest); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | fs::create_dir(output_file_folder); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | fs::create_dir(output_file_folder); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.08s [INFO] running `"docker" "inspect" "b3ace28fadb6fd6a0d4ac63f95a2975118f01f473a9a6b80d659b011b933b7d7"` [INFO] running `"docker" "rm" "-f" "b3ace28fadb6fd6a0d4ac63f95a2975118f01f473a9a6b80d659b011b933b7d7"` [INFO] [stdout] b3ace28fadb6fd6a0d4ac63f95a2975118f01f473a9a6b80d659b011b933b7d7