[INFO] updating cached repository gtestault/primitive-recursive-functions [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gtestault/primitive-recursive-functions [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gtestault/primitive-recursive-functions" "work/ex/clippy-test-run/sources/stable/gh/gtestault/primitive-recursive-functions"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gtestault/primitive-recursive-functions'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gtestault/primitive-recursive-functions" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gtestault/primitive-recursive-functions"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gtestault/primitive-recursive-functions'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2aa361a39e95d45c2ba52a07f0d3326b5211a9fd [INFO] sha for GitHub repo gtestault/primitive-recursive-functions: 2aa361a39e95d45c2ba52a07f0d3326b5211a9fd [INFO] validating manifest of gtestault/primitive-recursive-functions on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gtestault/primitive-recursive-functions on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gtestault/primitive-recursive-functions [INFO] finished frobbing gtestault/primitive-recursive-functions [INFO] frobbed toml for gtestault/primitive-recursive-functions written to work/ex/clippy-test-run/sources/stable/gh/gtestault/primitive-recursive-functions/Cargo.toml [INFO] started frobbing gtestault/primitive-recursive-functions [INFO] finished frobbing gtestault/primitive-recursive-functions [INFO] frobbed toml for gtestault/primitive-recursive-functions written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gtestault/primitive-recursive-functions/Cargo.toml [INFO] crate gtestault/primitive-recursive-functions has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gtestault/primitive-recursive-functions against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gtestault/primitive-recursive-functions:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7b42571171b3d3e12f69c9153c1bb69357681c8e4426964c3bcfe5968e0ee1b6 [INFO] running `"docker" "start" "-a" "7b42571171b3d3e12f69c9153c1bb69357681c8e4426964c3bcfe5968e0ee1b6"` [INFO] [stderr] Checking primitive-recursive-functions v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:690:9 [INFO] [stderr] | [INFO] [stderr] 690 | return String::from(""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:690:9 [INFO] [stderr] | [INFO] [stderr] 690 | return String::from(""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:217:16 [INFO] [stderr] | [INFO] [stderr] 217 | type Out = < as Larger>::Out as If< [INFO] [stderr] | ________________^ [INFO] [stderr] 218 | | Succ<<>>::Out as Div>::Out>, [INFO] [stderr] 219 | | <>>::Out as Div>::Out, [INFO] [stderr] 220 | | >>::Out; [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:250:16 [INFO] [stderr] | [INFO] [stderr] 250 | type Out = << as Div>::Out as Mul>::Out as Sub>>::Out; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:801:9 [INFO] [stderr] | [INFO] [stderr] 801 | format!("") [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:217:16 [INFO] [stderr] | [INFO] [stderr] 217 | type Out = < as Larger>::Out as If< [INFO] [stderr] | ________________^ [INFO] [stderr] 218 | | Succ<<>>::Out as Div>::Out>, [INFO] [stderr] 219 | | <>>::Out as Div>::Out, [INFO] [stderr] 220 | | >>::Out; [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:250:16 [INFO] [stderr] | [INFO] [stderr] 250 | type Out = << as Div>::Out as Mul>::Out as Sub>>::Out; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:801:9 [INFO] [stderr] | [INFO] [stderr] 801 | format!("") [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/main.rs:1175:5 [INFO] [stderr] | [INFO] [stderr] 1175 | / fn arithmetic_works() { [INFO] [stderr] 1176 | | assert_eq!(incr::(), 4); [INFO] [stderr] 1177 | | assert_eq!(decr::(), 0); [INFO] [stderr] 1178 | | assert_eq!(decr::(), 4); [INFO] [stderr] ... | [INFO] [stderr] 1213 | | ); [INFO] [stderr] 1214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 58 [INFO] [stderr] --> src/main.rs:1217:5 [INFO] [stderr] | [INFO] [stderr] 1217 | / fn game_of_life_works() { [INFO] [stderr] 1218 | | assert_eq!(alive_at::>(), 0); [INFO] [stderr] 1219 | | assert_eq!(alive_at::>>(), 1); [INFO] [stderr] 1220 | | //assert_eq!(alive_at::(), 0); [INFO] [stderr] ... | [INFO] [stderr] 1291 | | assert_eq!(fate::(), 0); [INFO] [stderr] 1292 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.52s [INFO] running `"docker" "inspect" "7b42571171b3d3e12f69c9153c1bb69357681c8e4426964c3bcfe5968e0ee1b6"` [INFO] running `"docker" "rm" "-f" "7b42571171b3d3e12f69c9153c1bb69357681c8e4426964c3bcfe5968e0ee1b6"` [INFO] [stdout] 7b42571171b3d3e12f69c9153c1bb69357681c8e4426964c3bcfe5968e0ee1b6