[INFO] updating cached repository gslavin/wisp_rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/gslavin/wisp_rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/gslavin/wisp_rust" "work/ex/clippy-test-run/sources/stable/gh/gslavin/wisp_rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gslavin/wisp_rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/gslavin/wisp_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gslavin/wisp_rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gslavin/wisp_rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 83fa0ecba9ecb660fcbbe7dc6d1f14b5bcd9042a
[INFO] sha for GitHub repo gslavin/wisp_rust: 83fa0ecba9ecb660fcbbe7dc6d1f14b5bcd9042a
[INFO] validating manifest of gslavin/wisp_rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gslavin/wisp_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gslavin/wisp_rust
[INFO] finished frobbing gslavin/wisp_rust
[INFO] frobbed toml for gslavin/wisp_rust written to work/ex/clippy-test-run/sources/stable/gh/gslavin/wisp_rust/Cargo.toml
[INFO] started frobbing gslavin/wisp_rust
[INFO] finished frobbing gslavin/wisp_rust
[INFO] frobbed toml for gslavin/wisp_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gslavin/wisp_rust/Cargo.toml
[INFO] crate gslavin/wisp_rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gslavin/wisp_rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gslavin/wisp_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c712b689983a451b50bcbecc90381e1b734356b020f81b13f54facf68aaf6005
[INFO] running `"docker" "start" "-a" "c712b689983a451b50bcbecc90381e1b734356b020f81b13f54facf68aaf6005"`
[INFO] [stderr]     Checking wisp v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return tokens;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     return AstNode::If(pred, if_path, else_path);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `AstNode::If(pred, if_path, else_path)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:93:5
[INFO] [stderr]    |
[INFO] [stderr] 93 |     return AstNode::Define(identifier, value);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `AstNode::Define(identifier, value)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:109:5
[INFO] [stderr]     |
[INFO] [stderr] 109 |     return AstNode::Expression(expr);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `AstNode::Expression(expr)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eval.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         return Context{defines: vec![BTreeMap::new()]};
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Context{defines: vec![BTreeMap::new()]}`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/eval.rs:20:37
[INFO] [stderr]    |
[INFO] [stderr] 20 |     pub fn add_namespace(&mut self) -> () {
[INFO] [stderr]    |                                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/eval.rs:23:40
[INFO] [stderr]    |
[INFO] [stderr] 23 |     pub fn remove_namespace(&mut self) -> () {
[INFO] [stderr]    |                                        ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eval.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return (*self).defines[end].insert(name, value);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*self).defines[end].insert(name, value)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eval.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eval.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 |     return BUILTINS.contains(&ident.as_str());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BUILTINS.contains(&ident.as_str())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eval.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return AstNode::Number((sum));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `AstNode::Number((sum))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/eval.rs:66:28
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return AstNode::Number((sum));
[INFO] [stderr]    |                            ^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/eval.rs:66:28
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return AstNode::Number((sum));
[INFO] [stderr]    |                            ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/eval.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             return lambda_body;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `lambda_body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/eval.rs:163:5
[INFO] [stderr]     |
[INFO] [stderr] 163 |     return ();
[INFO] [stderr]     |     ^^^^^^^^^^ help: remove `return` as shown: `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/eval.rs:108:55
[INFO] [stderr]     |
[INFO] [stderr] 108 | pub fn eval(ast: &mut AstNode, context: &mut Context) -> () {
[INFO] [stderr]     |                                                       ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]    --> src/eval.rs:163:12
[INFO] [stderr]     |
[INFO] [stderr] 163 |     return ();
[INFO] [stderr]     |            ^^ help: remove the `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:17:2
[INFO] [stderr]    |
[INFO] [stderr] 17 |     return Ok(s);
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return tokens;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     return AstNode::If(pred, if_path, else_path);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `AstNode::If(pred, if_path, else_path)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:93:5
[INFO] [stderr]    |
[INFO] [stderr] 93 |     return AstNode::Define(identifier, value);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `AstNode::Define(identifier, value)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:109:5
[INFO] [stderr]     |
[INFO] [stderr] 109 |     return AstNode::Expression(expr);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `AstNode::Expression(expr)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eval.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         return Context{defines: vec![BTreeMap::new()]};
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Context{defines: vec![BTreeMap::new()]}`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/eval.rs:20:37
[INFO] [stderr]    |
[INFO] [stderr] 20 |     pub fn add_namespace(&mut self) -> () {
[INFO] [stderr]    |                                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/eval.rs:23:40
[INFO] [stderr]    |
[INFO] [stderr] 23 |     pub fn remove_namespace(&mut self) -> () {
[INFO] [stderr]    |                                        ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eval.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return (*self).defines[end].insert(name, value);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*self).defines[end].insert(name, value)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eval.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eval.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 |     return BUILTINS.contains(&ident.as_str());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BUILTINS.contains(&ident.as_str())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eval.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return AstNode::Number((sum));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `AstNode::Number((sum))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/eval.rs:66:28
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return AstNode::Number((sum));
[INFO] [stderr]    |                            ^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/eval.rs:66:28
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return AstNode::Number((sum));
[INFO] [stderr]    |                            ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/eval.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             return lambda_body;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `lambda_body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/eval.rs:163:5
[INFO] [stderr]     |
[INFO] [stderr] 163 |     return ();
[INFO] [stderr]     |     ^^^^^^^^^^ help: remove `return` as shown: `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/eval.rs:108:55
[INFO] [stderr]     |
[INFO] [stderr] 108 | pub fn eval(ast: &mut AstNode, context: &mut Context) -> () {
[INFO] [stderr]     |                                                       ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]    --> src/eval.rs:163:12
[INFO] [stderr]     |
[INFO] [stderr] 163 |     return ();
[INFO] [stderr]     |            ^^ help: remove the `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/eval.rs:271:47
[INFO] [stderr]     |
[INFO] [stderr] 271 |         let expected_result = AstNode::Number((-1.0));
[INFO] [stderr]     |                                               ^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/eval.rs:271:47
[INFO] [stderr]     |
[INFO] [stderr] 271 |         let expected_result = AstNode::Number((-1.0));
[INFO] [stderr]     |                                               ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/eval.rs:293:47
[INFO] [stderr]     |
[INFO] [stderr] 293 |         let expected_result = AstNode::Number((0.75));
[INFO] [stderr]     |                                               ^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/eval.rs:293:47
[INFO] [stderr]     |
[INFO] [stderr] 293 |         let expected_result = AstNode::Number((0.75));
[INFO] [stderr]     |                                               ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/eval.rs:318:47
[INFO] [stderr]     |
[INFO] [stderr] 318 |         let expected_result = AstNode::Number((3.0));
[INFO] [stderr]     |                                               ^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/eval.rs:318:47
[INFO] [stderr]     |
[INFO] [stderr] 318 |         let expected_result = AstNode::Number((3.0));
[INFO] [stderr]     |                                               ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/eval.rs:329:47
[INFO] [stderr]     |
[INFO] [stderr] 329 |         let expected_result = AstNode::Number((4.0));
[INFO] [stderr]     |                                               ^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/eval.rs:329:47
[INFO] [stderr]     |
[INFO] [stderr] 329 |         let expected_result = AstNode::Number((4.0));
[INFO] [stderr]     |                                               ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:17:2
[INFO] [stderr]    |
[INFO] [stderr] 17 |     return Ok(s);
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]   --> src/lexer.rs:26:47
[INFO] [stderr]    |
[INFO] [stderr] 26 |         static ref DEFINE: Regex = Regex::new(r"define").unwrap();
[INFO] [stderr]    |                                               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]    = help: consider using `str::contains`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]   --> src/lexer.rs:27:47
[INFO] [stderr]    |
[INFO] [stderr] 27 |         static ref LAMBDA: Regex = Regex::new(r"lambda").unwrap();
[INFO] [stderr]    |                                               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: consider using `str::contains`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]   --> src/lexer.rs:28:43
[INFO] [stderr]    |
[INFO] [stderr] 28 |         static ref IF: Regex = Regex::new(r"if").unwrap();
[INFO] [stderr]    |                                           ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: consider using `str::contains`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `eval::Context`
[INFO] [stderr]   --> src/eval.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 | /     pub fn new() -> Context {
[INFO] [stderr] 18 | |         return Context{defines: vec![BTreeMap::new()]};
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/eval.rs:24:12
[INFO] [stderr]    |
[INFO] [stderr] 24 |         if (*self).defines.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*self).defines.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/eval.rs:33:32
[INFO] [stderr]    |
[INFO] [stderr] 33 |     fn get_define(&self, name: &String) -> Option<&Box<AstNode>> {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/eval.rs:33:51
[INFO] [stderr]    |
[INFO] [stderr] 33 |     fn get_define(&self, name: &String) -> Option<&Box<AstNode>> {
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^ help: try: `&AstNode`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/eval.rs:44:22
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn is_builtin(ident: &String) -> bool {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]   --> src/lexer.rs:26:47
[INFO] [stderr]    |
[INFO] [stderr] 26 |         static ref DEFINE: Regex = Regex::new(r"define").unwrap();
[INFO] [stderr]    |                                               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]    = help: consider using `str::contains`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]   --> src/lexer.rs:27:47
[INFO] [stderr]    |
[INFO] [stderr] 27 |         static ref LAMBDA: Regex = Regex::new(r"lambda").unwrap();
[INFO] [stderr]    |                                               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: consider using `str::contains`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]   --> src/lexer.rs:28:43
[INFO] [stderr]    |
[INFO] [stderr] 28 |         static ref IF: Regex = Regex::new(r"if").unwrap();
[INFO] [stderr]    |                                           ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: consider using `str::contains`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `eval::Context`
[INFO] [stderr]   --> src/eval.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 | /     pub fn new() -> Context {
[INFO] [stderr] 18 | |         return Context{defines: vec![BTreeMap::new()]};
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/eval.rs:24:12
[INFO] [stderr]    |
[INFO] [stderr] 24 |         if (*self).defines.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*self).defines.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/eval.rs:33:32
[INFO] [stderr]    |
[INFO] [stderr] 33 |     fn get_define(&self, name: &String) -> Option<&Box<AstNode>> {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/eval.rs:33:51
[INFO] [stderr]    |
[INFO] [stderr] 33 |     fn get_define(&self, name: &String) -> Option<&Box<AstNode>> {
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^ help: try: `&AstNode`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/eval.rs:44:22
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn is_builtin(ident: &String) -> bool {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.54s
[INFO] running `"docker" "inspect" "c712b689983a451b50bcbecc90381e1b734356b020f81b13f54facf68aaf6005"`
[INFO] running `"docker" "rm" "-f" "c712b689983a451b50bcbecc90381e1b734356b020f81b13f54facf68aaf6005"`
[INFO] [stdout] c712b689983a451b50bcbecc90381e1b734356b020f81b13f54facf68aaf6005