[INFO] updating cached repository gsfellis/rust-hangman [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gsfellis/rust-hangman [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gsfellis/rust-hangman" "work/ex/clippy-test-run/sources/stable/gh/gsfellis/rust-hangman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gsfellis/rust-hangman'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gsfellis/rust-hangman" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gsfellis/rust-hangman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gsfellis/rust-hangman'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dd0ea30ca54130e7209d887eac2c7cc5d8861416 [INFO] sha for GitHub repo gsfellis/rust-hangman: dd0ea30ca54130e7209d887eac2c7cc5d8861416 [INFO] validating manifest of gsfellis/rust-hangman on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gsfellis/rust-hangman on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gsfellis/rust-hangman [INFO] finished frobbing gsfellis/rust-hangman [INFO] frobbed toml for gsfellis/rust-hangman written to work/ex/clippy-test-run/sources/stable/gh/gsfellis/rust-hangman/Cargo.toml [INFO] started frobbing gsfellis/rust-hangman [INFO] finished frobbing gsfellis/rust-hangman [INFO] frobbed toml for gsfellis/rust-hangman written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gsfellis/rust-hangman/Cargo.toml [INFO] crate gsfellis/rust-hangman has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gsfellis/rust-hangman against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gsfellis/rust-hangman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9d8a5123e29219a4f172566870432d58c0a7bbc2806e9ec114d0ba6fca0551a4 [INFO] running `"docker" "start" "-a" "9d8a5123e29219a4f172566870432d58c0a7bbc2806e9ec114d0ba6fca0551a4"` [INFO] [stderr] Checking rust-hangman v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `word` [INFO] [stderr] --> src/main.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | fn update_word(word: &str, guess: &char) { [INFO] [stderr] | ^^^^ help: consider using `_word` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `guess` [INFO] [stderr] --> src/main.rs:79:28 [INFO] [stderr] | [INFO] [stderr] 79 | fn update_word(word: &str, guess: &char) { [INFO] [stderr] | ^^^^^ help: consider using `_guess` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | let mut gallow = build_gallow(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `update_word` [INFO] [stderr] --> src/main.rs:79:1 [INFO] [stderr] | [INFO] [stderr] 79 | fn update_word(word: &str, guess: &char) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | fn show_gallow(g: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | fn update_word(word: &str, guess: &char) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | guesses = guesses + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `guesses += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `word` [INFO] [stderr] --> src/main.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | fn update_word(word: &str, guess: &char) { [INFO] [stderr] | ^^^^ help: consider using `_word` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `guess` [INFO] [stderr] --> src/main.rs:79:28 [INFO] [stderr] | [INFO] [stderr] 79 | fn update_word(word: &str, guess: &char) { [INFO] [stderr] | ^^^^^ help: consider using `_guess` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | let mut gallow = build_gallow(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `update_word` [INFO] [stderr] --> src/main.rs:79:1 [INFO] [stderr] | [INFO] [stderr] 79 | fn update_word(word: &str, guess: &char) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | fn show_gallow(g: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | fn update_word(word: &str, guess: &char) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | guesses = guesses + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `guesses += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.82s [INFO] running `"docker" "inspect" "9d8a5123e29219a4f172566870432d58c0a7bbc2806e9ec114d0ba6fca0551a4"` [INFO] running `"docker" "rm" "-f" "9d8a5123e29219a4f172566870432d58c0a7bbc2806e9ec114d0ba6fca0551a4"` [INFO] [stdout] 9d8a5123e29219a4f172566870432d58c0a7bbc2806e9ec114d0ba6fca0551a4