[INFO] updating cached repository grubertw/mandelbrot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/grubertw/mandelbrot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/grubertw/mandelbrot" "work/ex/clippy-test-run/sources/stable/gh/grubertw/mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/grubertw/mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/grubertw/mandelbrot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grubertw/mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grubertw/mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 93cdb2ad265d193dcb95bee08817e3dec88f6746 [INFO] sha for GitHub repo grubertw/mandelbrot: 93cdb2ad265d193dcb95bee08817e3dec88f6746 [INFO] validating manifest of grubertw/mandelbrot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grubertw/mandelbrot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grubertw/mandelbrot [INFO] finished frobbing grubertw/mandelbrot [INFO] frobbed toml for grubertw/mandelbrot written to work/ex/clippy-test-run/sources/stable/gh/grubertw/mandelbrot/Cargo.toml [INFO] started frobbing grubertw/mandelbrot [INFO] finished frobbing grubertw/mandelbrot [INFO] frobbed toml for grubertw/mandelbrot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grubertw/mandelbrot/Cargo.toml [INFO] crate grubertw/mandelbrot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grubertw/mandelbrot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/grubertw/mandelbrot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d6ace6eb56ffe28773804a376d36535b8c43882fdd8bf98608112325aa0515a7 [INFO] running `"docker" "start" "-a" "d6ace6eb56ffe28773804a376d36535b8c43882fdd8bf98608112325aa0515a7"` [INFO] [stderr] Compiling serde v0.9.14 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking x11-dl v2.13.0 [INFO] [stderr] Checking backtrace-sys v0.1.10 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Compiling target_build_utils v0.3.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking glium v0.16.0 [INFO] [stderr] Checking mandelbrot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / fn main() { [INFO] [stderr] 18 | | let logger_rc = logger::init(); [INFO] [stderr] 19 | | assert_eq!(logger_rc.is_ok(), true); [INFO] [stderr] 20 | | [INFO] [stderr] ... | [INFO] [stderr] 263 | | } [INFO] [stderr] 264 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:212:21 [INFO] [stderr] | [INFO] [stderr] 212 | / match delta { [INFO] [stderr] 213 | | LineDelta(_, h) => { [INFO] [stderr] 214 | | if h > 0.0 { [INFO] [stderr] 215 | | scale /= scale_interval; [INFO] [stderr] ... | [INFO] [stderr] 223 | | _ => () [INFO] [stderr] 224 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 212 | if let LineDelta(_, h) = delta { [INFO] [stderr] 213 | if h > 0.0 { [INFO] [stderr] 214 | scale /= scale_interval; [INFO] [stderr] 215 | info!("scale decremented to {}", scale); [INFO] [stderr] 216 | } [INFO] [stderr] 217 | else if h < 0.0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:230:21 [INFO] [stderr] | [INFO] [stderr] 230 | / match m_button { [INFO] [stderr] 231 | | MouseButton::Left => { [INFO] [stderr] 232 | | mouse_state = m_state; [INFO] [stderr] 233 | | } [INFO] [stderr] 234 | | _ => () [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 230 | if let MouseButton::Left = m_button { [INFO] [stderr] 231 | mouse_state = m_state; [INFO] [stderr] 232 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:244:45 [INFO] [stderr] | [INFO] [stderr] 244 | offset.0 -= (diff_x as f64) * scale; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(diff_x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:245:45 [INFO] [stderr] | [INFO] [stderr] 245 | offset.1 += (diff_y as f64) * scale; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(diff_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / fn main() { [INFO] [stderr] 18 | | let logger_rc = logger::init(); [INFO] [stderr] 19 | | assert_eq!(logger_rc.is_ok(), true); [INFO] [stderr] 20 | | [INFO] [stderr] ... | [INFO] [stderr] 263 | | } [INFO] [stderr] 264 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:212:21 [INFO] [stderr] | [INFO] [stderr] 212 | / match delta { [INFO] [stderr] 213 | | LineDelta(_, h) => { [INFO] [stderr] 214 | | if h > 0.0 { [INFO] [stderr] 215 | | scale /= scale_interval; [INFO] [stderr] ... | [INFO] [stderr] 223 | | _ => () [INFO] [stderr] 224 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 212 | if let LineDelta(_, h) = delta { [INFO] [stderr] 213 | if h > 0.0 { [INFO] [stderr] 214 | scale /= scale_interval; [INFO] [stderr] 215 | info!("scale decremented to {}", scale); [INFO] [stderr] 216 | } [INFO] [stderr] 217 | else if h < 0.0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:230:21 [INFO] [stderr] | [INFO] [stderr] 230 | / match m_button { [INFO] [stderr] 231 | | MouseButton::Left => { [INFO] [stderr] 232 | | mouse_state = m_state; [INFO] [stderr] 233 | | } [INFO] [stderr] 234 | | _ => () [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 230 | if let MouseButton::Left = m_button { [INFO] [stderr] 231 | mouse_state = m_state; [INFO] [stderr] 232 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:244:45 [INFO] [stderr] | [INFO] [stderr] 244 | offset.0 -= (diff_x as f64) * scale; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(diff_x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:245:45 [INFO] [stderr] | [INFO] [stderr] 245 | offset.1 += (diff_y as f64) * scale; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(diff_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.42s [INFO] running `"docker" "inspect" "d6ace6eb56ffe28773804a376d36535b8c43882fdd8bf98608112325aa0515a7"` [INFO] running `"docker" "rm" "-f" "d6ace6eb56ffe28773804a376d36535b8c43882fdd8bf98608112325aa0515a7"` [INFO] [stdout] d6ace6eb56ffe28773804a376d36535b8c43882fdd8bf98608112325aa0515a7