[INFO] updating cached repository grncdr/mmr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/grncdr/mmr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/grncdr/mmr" "work/ex/clippy-test-run/sources/stable/gh/grncdr/mmr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/grncdr/mmr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/grncdr/mmr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grncdr/mmr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grncdr/mmr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6f5dc7f7682de2c90374d29d7be55096a4045d0c [INFO] sha for GitHub repo grncdr/mmr: 6f5dc7f7682de2c90374d29d7be55096a4045d0c [INFO] validating manifest of grncdr/mmr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grncdr/mmr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grncdr/mmr [INFO] finished frobbing grncdr/mmr [INFO] frobbed toml for grncdr/mmr written to work/ex/clippy-test-run/sources/stable/gh/grncdr/mmr/Cargo.toml [INFO] started frobbing grncdr/mmr [INFO] finished frobbing grncdr/mmr [INFO] frobbed toml for grncdr/mmr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grncdr/mmr/Cargo.toml [INFO] crate grncdr/mmr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grncdr/mmr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/grncdr/mmr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a2efdd780a82d48f687ba5ca581e6a3922d7fe48a4cd772a2838380abd71ccb5 [INFO] running `"docker" "start" "-a" "a2efdd780a82d48f687ba5ca581e6a3922d7fe48a4cd772a2838380abd71ccb5"` [INFO] [stderr] Compiling winapi v0.3.4 [INFO] [stderr] Compiling kernel32-sys v0.1.4 [INFO] [stderr] Checking errno v0.2.3 [INFO] [stderr] Checking exec v0.3.1 [INFO] [stderr] Checking utime v0.1.3 [INFO] [stderr] Checking mmr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | .unwrap_or(vec![]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / match self { [INFO] [stderr] 85 | | &Error::Exec(ref e) => e.description(), [INFO] [stderr] 86 | | &Error::IO(ref e) => e.description(), [INFO] [stderr] 87 | | &Error::Clock(ref e) => e.description(), [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | match *self { [INFO] [stderr] 85 | Error::Exec(ref e) => e.description(), [INFO] [stderr] 86 | Error::IO(ref e) => e.description(), [INFO] [stderr] 87 | Error::Clock(ref e) => e.description(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match self { [INFO] [stderr] 92 | | &Error::Exec(ref e) => e.cause(), [INFO] [stderr] 93 | | &Error::IO(ref e) => e.cause(), [INFO] [stderr] 94 | | &Error::Clock(ref e) => e.cause(), [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | match *self { [INFO] [stderr] 92 | Error::Exec(ref e) => e.cause(), [INFO] [stderr] 93 | Error::IO(ref e) => e.cause(), [INFO] [stderr] 94 | Error::Clock(ref e) => e.cause(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match self { [INFO] [stderr] 102 | | &Error::Exec(ref e) => write!(f, "{}", e), [INFO] [stderr] 103 | | &Error::IO(ref e) => write!(f, "{}", e), [INFO] [stderr] 104 | | &Error::Clock(ref e) => write!(f, "{}", e), [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | match *self { [INFO] [stderr] 102 | Error::Exec(ref e) => write!(f, "{}", e), [INFO] [stderr] 103 | Error::IO(ref e) => write!(f, "{}", e), [INFO] [stderr] 104 | Error::Clock(ref e) => write!(f, "{}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:110:42 [INFO] [stderr] | [INFO] [stderr] 110 | let editor = std::env::var("EDITOR").unwrap_or("vim".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "vim".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:157:27 [INFO] [stderr] | [INFO] [stderr] 157 | reader.read_until('\n' as u8, &mut buf)?; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | io::stdout().write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | .unwrap_or(vec![]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / match self { [INFO] [stderr] 85 | | &Error::Exec(ref e) => e.description(), [INFO] [stderr] 86 | | &Error::IO(ref e) => e.description(), [INFO] [stderr] 87 | | &Error::Clock(ref e) => e.description(), [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | match *self { [INFO] [stderr] 85 | Error::Exec(ref e) => e.description(), [INFO] [stderr] 86 | Error::IO(ref e) => e.description(), [INFO] [stderr] 87 | Error::Clock(ref e) => e.description(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match self { [INFO] [stderr] 92 | | &Error::Exec(ref e) => e.cause(), [INFO] [stderr] 93 | | &Error::IO(ref e) => e.cause(), [INFO] [stderr] 94 | | &Error::Clock(ref e) => e.cause(), [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | match *self { [INFO] [stderr] 92 | Error::Exec(ref e) => e.cause(), [INFO] [stderr] 93 | Error::IO(ref e) => e.cause(), [INFO] [stderr] 94 | Error::Clock(ref e) => e.cause(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match self { [INFO] [stderr] 102 | | &Error::Exec(ref e) => write!(f, "{}", e), [INFO] [stderr] 103 | | &Error::IO(ref e) => write!(f, "{}", e), [INFO] [stderr] 104 | | &Error::Clock(ref e) => write!(f, "{}", e), [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | match *self { [INFO] [stderr] 102 | Error::Exec(ref e) => write!(f, "{}", e), [INFO] [stderr] 103 | Error::IO(ref e) => write!(f, "{}", e), [INFO] [stderr] 104 | Error::Clock(ref e) => write!(f, "{}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:110:42 [INFO] [stderr] | [INFO] [stderr] 110 | let editor = std::env::var("EDITOR").unwrap_or("vim".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "vim".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: Could not compile `mmr`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:157:27 [INFO] [stderr] | [INFO] [stderr] 157 | reader.read_until('\n' as u8, &mut buf)?; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | io::stdout().write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mmr`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a2efdd780a82d48f687ba5ca581e6a3922d7fe48a4cd772a2838380abd71ccb5"` [INFO] running `"docker" "rm" "-f" "a2efdd780a82d48f687ba5ca581e6a3922d7fe48a4cd772a2838380abd71ccb5"` [INFO] [stdout] a2efdd780a82d48f687ba5ca581e6a3922d7fe48a4cd772a2838380abd71ccb5