[INFO] updating cached repository grissiom/elfvars [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/grissiom/elfvars [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/grissiom/elfvars" "work/ex/clippy-test-run/sources/stable/gh/grissiom/elfvars"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/grissiom/elfvars'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/grissiom/elfvars" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grissiom/elfvars"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grissiom/elfvars'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 12a72cecbb683bb8a379cbd63869dd715b179964 [INFO] sha for GitHub repo grissiom/elfvars: 12a72cecbb683bb8a379cbd63869dd715b179964 [INFO] validating manifest of grissiom/elfvars on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grissiom/elfvars on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grissiom/elfvars [INFO] finished frobbing grissiom/elfvars [INFO] frobbed toml for grissiom/elfvars written to work/ex/clippy-test-run/sources/stable/gh/grissiom/elfvars/Cargo.toml [INFO] started frobbing grissiom/elfvars [INFO] finished frobbing grissiom/elfvars [INFO] frobbed toml for grissiom/elfvars written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grissiom/elfvars/Cargo.toml [INFO] crate grissiom/elfvars has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grissiom/elfvars against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/grissiom/elfvars:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d53bfdeb60b3e2c6f8de1770d1a35ab844c96efdff3b5c49859dc34ef3ef484 [INFO] running `"docker" "start" "-a" "1d53bfdeb60b3e2c6f8de1770d1a35ab844c96efdff3b5c49859dc34ef3ef484"` [INFO] [stderr] Checking leb128 v0.2.1 [INFO] [stderr] Checking zero v0.1.2 [INFO] [stderr] Compiling serde_derive v0.9.7 [INFO] [stderr] Checking env_logger v0.4.0 [INFO] [stderr] Checking xmas-elf v0.3.0 [INFO] [stderr] Checking gimli v0.11.0 [INFO] [stderr] Checking elfvars v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:266:30 [INFO] [stderr] | [INFO] [stderr] 266 | let mut var = Variable { cu_name: cu_name, ..Default::default() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cu_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:266:30 [INFO] [stderr] | [INFO] [stderr] 266 | let mut var = Variable { cu_name: cu_name, ..Default::default() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cu_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Debug` [INFO] [stderr] --> src/main.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | use std::fmt::{self, Debug}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | return Err("Unknown endianity".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Unknown endianity".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Debug` [INFO] [stderr] --> src/main.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | use std::fmt::{self, Debug}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | return Err("Unknown endianity".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Unknown endianity".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `offset` [INFO] [stderr] --> src/main.rs:279:55 [INFO] [stderr] | [INFO] [stderr] 279 | if let gimli::AttributeValue::UnitRef(offset) = attr.value() { [INFO] [stderr] | ^^^^^^ help: consider using `_offset` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:127:1 [INFO] [stderr] | [INFO] [stderr] 127 | / pub fn parse_data<'input>(buffer: &'input [u8]) -> Result> { [INFO] [stderr] 128 | | let elf = xmas_elf::ElfFile::new(buffer); [INFO] [stderr] 129 | | [INFO] [stderr] 130 | | match elf.header.pt1.data { [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:298:42 [INFO] [stderr] | [INFO] [stderr] 298 | 4 => Endian::read_u32(elements) as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(Endian::read_u32(elements))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `offset` [INFO] [stderr] --> src/main.rs:279:55 [INFO] [stderr] | [INFO] [stderr] 279 | if let gimli::AttributeValue::UnitRef(offset) = attr.value() { [INFO] [stderr] | ^^^^^^ help: consider using `_offset` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:127:1 [INFO] [stderr] | [INFO] [stderr] 127 | / pub fn parse_data<'input>(buffer: &'input [u8]) -> Result> { [INFO] [stderr] 128 | | let elf = xmas_elf::ElfFile::new(buffer); [INFO] [stderr] 129 | | [INFO] [stderr] 130 | | match elf.header.pt1.data { [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:298:42 [INFO] [stderr] | [INFO] [stderr] 298 | 4 => Endian::read_u32(elements) as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(Endian::read_u32(elements))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.42s [INFO] running `"docker" "inspect" "1d53bfdeb60b3e2c6f8de1770d1a35ab844c96efdff3b5c49859dc34ef3ef484"` [INFO] running `"docker" "rm" "-f" "1d53bfdeb60b3e2c6f8de1770d1a35ab844c96efdff3b5c49859dc34ef3ef484"` [INFO] [stdout] 1d53bfdeb60b3e2c6f8de1770d1a35ab844c96efdff3b5c49859dc34ef3ef484