[INFO] updating cached repository greyblake/hail [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/greyblake/hail [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/greyblake/hail" "work/ex/clippy-test-run/sources/stable/gh/greyblake/hail"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/greyblake/hail'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/greyblake/hail" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/greyblake/hail"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/greyblake/hail'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fbad22f6af6d7bdcebe1144851769e3186ca8fec [INFO] sha for GitHub repo greyblake/hail: fbad22f6af6d7bdcebe1144851769e3186ca8fec [INFO] validating manifest of greyblake/hail on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of greyblake/hail on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing greyblake/hail [INFO] finished frobbing greyblake/hail [INFO] frobbed toml for greyblake/hail written to work/ex/clippy-test-run/sources/stable/gh/greyblake/hail/Cargo.toml [INFO] started frobbing greyblake/hail [INFO] finished frobbing greyblake/hail [INFO] frobbed toml for greyblake/hail written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/greyblake/hail/Cargo.toml [INFO] crate greyblake/hail has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting greyblake/hail against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/greyblake/hail:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 21b1f3b8b6f3b91ac57edd6c3065405f950a0ceb07eecf22eb1376cb17540088 [INFO] running `"docker" "start" "-a" "21b1f3b8b6f3b91ac57edd6c3065405f950a0ceb07eecf22eb1376cb17540088"` [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking hail v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/attack.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | client [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/attack.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | let client = ::hyper::Client::configure() [INFO] [stderr] | __________________^ [INFO] [stderr] 85 | | .connector(::hyper_tls::HttpsConnector::new(4, handle).unwrap()) [INFO] [stderr] 86 | | .build(handle); [INFO] [stderr] | |______________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/attack.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | client [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/attack.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | let client = ::hyper::Client::configure() [INFO] [stderr] | __________________^ [INFO] [stderr] 85 | | .connector(::hyper_tls::HttpsConnector::new(4, handle).unwrap()) [INFO] [stderr] 86 | | .build(handle); [INFO] [stderr] | |______________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.17s [INFO] running `"docker" "inspect" "21b1f3b8b6f3b91ac57edd6c3065405f950a0ceb07eecf22eb1376cb17540088"` [INFO] running `"docker" "rm" "-f" "21b1f3b8b6f3b91ac57edd6c3065405f950a0ceb07eecf22eb1376cb17540088"` [INFO] [stdout] 21b1f3b8b6f3b91ac57edd6c3065405f950a0ceb07eecf22eb1376cb17540088