[INFO] updating cached repository greyblake/conway-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/greyblake/conway-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/greyblake/conway-rs" "work/ex/clippy-test-run/sources/stable/gh/greyblake/conway-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/greyblake/conway-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/greyblake/conway-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/greyblake/conway-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/greyblake/conway-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8bcb89286883d6137db97dd5a55ac4a320adca31 [INFO] sha for GitHub repo greyblake/conway-rs: 8bcb89286883d6137db97dd5a55ac4a320adca31 [INFO] validating manifest of greyblake/conway-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of greyblake/conway-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing greyblake/conway-rs [INFO] finished frobbing greyblake/conway-rs [INFO] frobbed toml for greyblake/conway-rs written to work/ex/clippy-test-run/sources/stable/gh/greyblake/conway-rs/Cargo.toml [INFO] started frobbing greyblake/conway-rs [INFO] finished frobbing greyblake/conway-rs [INFO] frobbed toml for greyblake/conway-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/greyblake/conway-rs/Cargo.toml [INFO] crate greyblake/conway-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting greyblake/conway-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/greyblake/conway-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 06295759b191f04046a5e33c1a3310e35da93fd54c185b41286518487a32f552 [INFO] running `"docker" "start" "-a" "06295759b191f04046a5e33c1a3310e35da93fd54c185b41286518487a32f552"` [INFO] [stderr] Checking libc v0.2.15 [INFO] [stderr] Checking ansi_term v0.8.0 [INFO] [stderr] Checking term_size v0.1.1 [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking termion v1.1.1 [INFO] [stderr] Checking clap v2.11.0 [INFO] [stderr] Checking conway v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | Board { width: width, height: height, matrix: matrix } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | Board { width: width, height: height, matrix: matrix } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:20:47 [INFO] [stderr] | [INFO] [stderr] 20 | Board { width: width, height: height, matrix: matrix } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `matrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | Board { width: width, height: height, matrix: matrix } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | Board { width: width, height: height, matrix: matrix } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:20:47 [INFO] [stderr] | [INFO] [stderr] 20 | Board { width: width, height: height, matrix: matrix } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `matrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | let ch = match *cell { [INFO] [stderr] | ______________________^ [INFO] [stderr] 66 | | true => alive, [INFO] [stderr] 67 | | false => dead, [INFO] [stderr] 68 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if *cell { alive } else { dead }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | let ch = match *cell { [INFO] [stderr] | ______________________^ [INFO] [stderr] 66 | | true => alive, [INFO] [stderr] 67 | | false => dead, [INFO] [stderr] 68 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if *cell { alive } else { dead }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.26s [INFO] running `"docker" "inspect" "06295759b191f04046a5e33c1a3310e35da93fd54c185b41286518487a32f552"` [INFO] running `"docker" "rm" "-f" "06295759b191f04046a5e33c1a3310e35da93fd54c185b41286518487a32f552"` [INFO] [stdout] 06295759b191f04046a5e33c1a3310e35da93fd54c185b41286518487a32f552