[INFO] updating cached repository gretchenfrage/mv5t [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gretchenfrage/mv5t [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gretchenfrage/mv5t" "work/ex/clippy-test-run/sources/stable/gh/gretchenfrage/mv5t"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gretchenfrage/mv5t'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gretchenfrage/mv5t" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gretchenfrage/mv5t"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gretchenfrage/mv5t'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3a6917d335065774090693f79660de99d25ec0b6 [INFO] sha for GitHub repo gretchenfrage/mv5t: 3a6917d335065774090693f79660de99d25ec0b6 [INFO] validating manifest of gretchenfrage/mv5t on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gretchenfrage/mv5t on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gretchenfrage/mv5t [INFO] finished frobbing gretchenfrage/mv5t [INFO] frobbed toml for gretchenfrage/mv5t written to work/ex/clippy-test-run/sources/stable/gh/gretchenfrage/mv5t/Cargo.toml [INFO] started frobbing gretchenfrage/mv5t [INFO] finished frobbing gretchenfrage/mv5t [INFO] frobbed toml for gretchenfrage/mv5t written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gretchenfrage/mv5t/Cargo.toml [INFO] crate gretchenfrage/mv5t has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gretchenfrage/mv5t against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gretchenfrage/mv5t:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd02016fceef7fbc08029a4d9d5697616e9d28c86f199eabfa4ef47f81bf296e [INFO] running `"docker" "start" "-a" "bd02016fceef7fbc08029a4d9d5697616e9d28c86f199eabfa4ef47f81bf296e"` [INFO] [stderr] Checking file v1.1.1 [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Checking serde_json v1.0.13 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking serde_urlencoded v0.4.3 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking reqwest v0.5.2 [INFO] [stderr] Checking yandex_translate v2.1.0 [INFO] [stderr] Checking oauth-client v0.3.2 [INFO] [stderr] Checking mv5t v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:28:40 [INFO] [stderr] | [INFO] [stderr] 28 | let mut lines = text.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:39:40 [INFO] [stderr] | [INFO] [stderr] 39 | let mut lines = text.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:98:33 [INFO] [stderr] | [INFO] [stderr] 98 | / if let &JsonValue::Object(ref obj) = post { [INFO] [stderr] 99 | | match obj["type"].as_str().unwrap() { [INFO] [stderr] 100 | | "photo" => { [INFO] [stderr] 101 | | let blog_name = String::from(obj["blog_name"].as_str() [INFO] [stderr] ... | [INFO] [stderr] 137 | | panic!("post as object fail") [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | if let JsonValue::Object(ref obj) = *post { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | / match self { [INFO] [stderr] 189 | | &Post::Photo { .. } => "photo", [INFO] [stderr] 190 | | &Post::Other(..) => panic!("post type of other") [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 188 | match *self { [INFO] [stderr] 189 | Post::Photo { .. } => "photo", [INFO] [stderr] 190 | Post::Other(..) => panic!("post type of other") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | / match self { [INFO] [stderr] 196 | | &Post::Photo { [INFO] [stderr] 197 | | id, [INFO] [stderr] 198 | | .. [INFO] [stderr] 199 | | } => id, [INFO] [stderr] 200 | | &Post::Other(..) => panic!("post if of other") [INFO] [stderr] 201 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 195 | match *self { [INFO] [stderr] 196 | Post::Photo { [INFO] [stderr] 197 | id, [INFO] [stderr] 198 | .. [INFO] [stderr] 199 | } => id, [INFO] [stderr] 200 | Post::Other(..) => panic!("post if of other") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | / match self { [INFO] [stderr] 206 | | &Post::Photo { [INFO] [stderr] 207 | | ref reblog_key, [INFO] [stderr] 208 | | .. [INFO] [stderr] 209 | | } => reblog_key.clone(), [INFO] [stderr] 210 | | &Post::Other(..) => panic!("reblog_key if of other") [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 205 | match *self { [INFO] [stderr] 206 | Post::Photo { [INFO] [stderr] 207 | ref reblog_key, [INFO] [stderr] 208 | .. [INFO] [stderr] 209 | } => reblog_key.clone(), [INFO] [stderr] 210 | Post::Other(..) => panic!("reblog_key if of other") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | / match self { [INFO] [stderr] 216 | | &Post::Photo { [INFO] [stderr] 217 | | ref caption, [INFO] [stderr] 218 | | .. [INFO] [stderr] 219 | | } => caption.clone(), [INFO] [stderr] 220 | | &Post::Other(..) => panic!("caption if of other") [INFO] [stderr] 221 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 215 | match *self { [INFO] [stderr] 216 | Post::Photo { [INFO] [stderr] 217 | ref caption, [INFO] [stderr] 218 | .. [INFO] [stderr] 219 | } => caption.clone(), [INFO] [stderr] 220 | Post::Other(..) => panic!("caption if of other") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:28:40 [INFO] [stderr] | [INFO] [stderr] 28 | let mut lines = text.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:39:40 [INFO] [stderr] | [INFO] [stderr] 39 | let mut lines = text.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:98:33 [INFO] [stderr] | [INFO] [stderr] 98 | / if let &JsonValue::Object(ref obj) = post { [INFO] [stderr] 99 | | match obj["type"].as_str().unwrap() { [INFO] [stderr] 100 | | "photo" => { [INFO] [stderr] 101 | | let blog_name = String::from(obj["blog_name"].as_str() [INFO] [stderr] ... | [INFO] [stderr] 137 | | panic!("post as object fail") [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | if let JsonValue::Object(ref obj) = *post { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | / match self { [INFO] [stderr] 189 | | &Post::Photo { .. } => "photo", [INFO] [stderr] 190 | | &Post::Other(..) => panic!("post type of other") [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 188 | match *self { [INFO] [stderr] 189 | Post::Photo { .. } => "photo", [INFO] [stderr] 190 | Post::Other(..) => panic!("post type of other") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | / match self { [INFO] [stderr] 196 | | &Post::Photo { [INFO] [stderr] 197 | | id, [INFO] [stderr] 198 | | .. [INFO] [stderr] 199 | | } => id, [INFO] [stderr] 200 | | &Post::Other(..) => panic!("post if of other") [INFO] [stderr] 201 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 195 | match *self { [INFO] [stderr] 196 | Post::Photo { [INFO] [stderr] 197 | id, [INFO] [stderr] 198 | .. [INFO] [stderr] 199 | } => id, [INFO] [stderr] 200 | Post::Other(..) => panic!("post if of other") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | / match self { [INFO] [stderr] 206 | | &Post::Photo { [INFO] [stderr] 207 | | ref reblog_key, [INFO] [stderr] 208 | | .. [INFO] [stderr] 209 | | } => reblog_key.clone(), [INFO] [stderr] 210 | | &Post::Other(..) => panic!("reblog_key if of other") [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 205 | match *self { [INFO] [stderr] 206 | Post::Photo { [INFO] [stderr] 207 | ref reblog_key, [INFO] [stderr] 208 | .. [INFO] [stderr] 209 | } => reblog_key.clone(), [INFO] [stderr] 210 | Post::Other(..) => panic!("reblog_key if of other") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | / match self { [INFO] [stderr] 216 | | &Post::Photo { [INFO] [stderr] 217 | | ref caption, [INFO] [stderr] 218 | | .. [INFO] [stderr] 219 | | } => caption.clone(), [INFO] [stderr] 220 | | &Post::Other(..) => panic!("caption if of other") [INFO] [stderr] 221 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 215 | match *self { [INFO] [stderr] 216 | Post::Photo { [INFO] [stderr] 217 | ref caption, [INFO] [stderr] 218 | .. [INFO] [stderr] 219 | } => caption.clone(), [INFO] [stderr] 220 | Post::Other(..) => panic!("caption if of other") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.77s [INFO] running `"docker" "inspect" "bd02016fceef7fbc08029a4d9d5697616e9d28c86f199eabfa4ef47f81bf296e"` [INFO] running `"docker" "rm" "-f" "bd02016fceef7fbc08029a4d9d5697616e9d28c86f199eabfa4ef47f81bf296e"` [INFO] [stdout] bd02016fceef7fbc08029a4d9d5697616e9d28c86f199eabfa4ef47f81bf296e