[INFO] updating cached repository grenewode/lintool [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/grenewode/lintool [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/grenewode/lintool" "work/ex/clippy-test-run/sources/stable/gh/grenewode/lintool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/grenewode/lintool'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/grenewode/lintool" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grenewode/lintool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grenewode/lintool'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 691645b26daaeee3c9c579fec2964a6f566bcf92 [INFO] sha for GitHub repo grenewode/lintool: 691645b26daaeee3c9c579fec2964a6f566bcf92 [INFO] validating manifest of grenewode/lintool on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grenewode/lintool on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grenewode/lintool [INFO] finished frobbing grenewode/lintool [INFO] frobbed toml for grenewode/lintool written to work/ex/clippy-test-run/sources/stable/gh/grenewode/lintool/Cargo.toml [INFO] started frobbing grenewode/lintool [INFO] finished frobbing grenewode/lintool [INFO] frobbed toml for grenewode/lintool written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grenewode/lintool/Cargo.toml [INFO] crate grenewode/lintool has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grenewode/lintool against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/grenewode/lintool:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 86e589affdb7e58f25f4e7a14584cc6de4f642c2d4f1e56bfe33b831a3477a34 [INFO] running `"docker" "start" "-a" "86e589affdb7e58f25f4e7a14584cc6de4f642c2d4f1e56bfe33b831a3477a34"` [INFO] [stderr] Checking lintool v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `Error`, `Result` [INFO] [stderr] --> src/types.rs:2:13 [INFO] [stderr] | [INFO] [stderr] 2 | use error::{Error, Result}; [INFO] [stderr] | ^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Sym` [INFO] [stderr] --> src/main.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | use lang::{Expr, Model, Seg, Sym}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `types::Typed` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use types::Typed; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Error`, `Result` [INFO] [stderr] --> src/types.rs:2:13 [INFO] [stderr] | [INFO] [stderr] 2 | use error::{Error, Result}; [INFO] [stderr] | ^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Sym` [INFO] [stderr] --> src/main.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | use lang::{Expr, Model, Seg, Sym}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `types::Typed` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use types::Typed; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `EntityLit` [INFO] [stderr] --> src/lang.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | EntityLit(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `entity` [INFO] [stderr] --> src/lang.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn entity>(name: S) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `append_truth` [INFO] [stderr] --> src/lang.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn append_truth>>(self, truth: T) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lang.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | / if let &Type::Func(ref input, ref output) = &a_type { [INFO] [stderr] 201 | | if **input == b_type { [INFO] [stderr] 202 | | return Ok(*output.clone()); [INFO] [stderr] 203 | | } [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 200 | if let Type::Func(ref input, ref output) = a_type { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lang.rs:269:21 [INFO] [stderr] | [INFO] [stderr] 269 | a @ _ => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lang.rs:321:21 [INFO] [stderr] | [INFO] [stderr] 321 | a @ _ => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `EntityLit` [INFO] [stderr] --> src/lang.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | EntityLit(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `entity` [INFO] [stderr] --> src/lang.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn entity>(name: S) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `append_truth` [INFO] [stderr] --> src/lang.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn append_truth>>(self, truth: T) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lang.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | / if let &Type::Func(ref input, ref output) = &a_type { [INFO] [stderr] 201 | | if **input == b_type { [INFO] [stderr] 202 | | return Ok(*output.clone()); [INFO] [stderr] 203 | | } [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 200 | if let Type::Func(ref input, ref output) = a_type { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lang.rs:269:21 [INFO] [stderr] | [INFO] [stderr] 269 | a @ _ => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lang.rs:321:21 [INFO] [stderr] | [INFO] [stderr] 321 | a @ _ => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.29s [INFO] running `"docker" "inspect" "86e589affdb7e58f25f4e7a14584cc6de4f642c2d4f1e56bfe33b831a3477a34"` [INFO] running `"docker" "rm" "-f" "86e589affdb7e58f25f4e7a14584cc6de4f642c2d4f1e56bfe33b831a3477a34"` [INFO] [stdout] 86e589affdb7e58f25f4e7a14584cc6de4f642c2d4f1e56bfe33b831a3477a34