[INFO] updating cached repository gregcline/advent_of_code_2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gregcline/advent_of_code_2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gregcline/advent_of_code_2018" "work/ex/clippy-test-run/sources/stable/gh/gregcline/advent_of_code_2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gregcline/advent_of_code_2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gregcline/advent_of_code_2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gregcline/advent_of_code_2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gregcline/advent_of_code_2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7e4d3e3259d2fe1a58af1ee64ba0b64c562abea9 [INFO] sha for GitHub repo gregcline/advent_of_code_2018: 7e4d3e3259d2fe1a58af1ee64ba0b64c562abea9 [INFO] validating manifest of gregcline/advent_of_code_2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gregcline/advent_of_code_2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gregcline/advent_of_code_2018 [INFO] finished frobbing gregcline/advent_of_code_2018 [INFO] frobbed toml for gregcline/advent_of_code_2018 written to work/ex/clippy-test-run/sources/stable/gh/gregcline/advent_of_code_2018/Cargo.toml [INFO] started frobbing gregcline/advent_of_code_2018 [INFO] finished frobbing gregcline/advent_of_code_2018 [INFO] frobbed toml for gregcline/advent_of_code_2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gregcline/advent_of_code_2018/Cargo.toml [INFO] crate gregcline/advent_of_code_2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gregcline/advent_of_code_2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gregcline/advent_of_code_2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b21620e22b94a71286de1415e0fa7166843df68e390ff51c1666fe893b3f67b0 [INFO] running `"docker" "start" "-a" "b21620e22b94a71286de1415e0fa7166843df68e390ff51c1666fe893b3f67b0"` [INFO] [stderr] Checking tap v0.3.0 [INFO] [stderr] Checking term v0.2.14 [INFO] [stderr] Checking spinner v0.4.0 [INFO] [stderr] Checking spinners v1.0.0 [INFO] [stderr] Checking rust_2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_3/point.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_3/point.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_3/point.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_3/point.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | point: Point { x: x, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_3/point.rs:34:34 [INFO] [stderr] | [INFO] [stderr] 34 | point: Point { x: x, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | solver: solver, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `solver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_3/point.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_3/point.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_3/point.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_3/point.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | point: Point { x: x, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_3/point.rs:34:34 [INFO] [stderr] | [INFO] [stderr] 34 | point: Point { x: x, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | solver: solver, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `solver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/day_3.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `tap::TapOps` [INFO] [stderr] --> src/day_3.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use tap::TapOps; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/solver.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Day` [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / enum Days { [INFO] [stderr] 18 | | #[structopt(name = "day_1")] [INFO] [stderr] 19 | | Day1 { [INFO] [stderr] 20 | | /// The name of the puzzle input file [INFO] [stderr] ... | [INFO] [stderr] 32 | | }, [INFO] [stderr] 33 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/day_3.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `tap::TapOps` [INFO] [stderr] --> src/day_3.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use tap::TapOps; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/solver.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Day` [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / enum Days { [INFO] [stderr] 18 | | #[structopt(name = "day_1")] [INFO] [stderr] 19 | | Day1 { [INFO] [stderr] 20 | | /// The name of the puzzle input file [INFO] [stderr] ... | [INFO] [stderr] 32 | | }, [INFO] [stderr] 33 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `puzzle` [INFO] [stderr] --> src/day_3.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | fn part_2(&self, puzzle: &str) -> io::Result { [INFO] [stderr] | ^^^^^^ help: consider using `_puzzle` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/day_1.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / if seen_freqs.contains_key(&next_freq) { [INFO] [stderr] 29 | | return Ok(Solution::I32(next_freq)); [INFO] [stderr] 30 | | } else { [INFO] [stderr] 31 | | seen_freqs.insert(next_freq, 0); [INFO] [stderr] 32 | | prev = next_freq; [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________________^ help: consider using: `seen_freqs.entry(next_freq)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/day_3/point.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Debug, Hash, Eq, Clone)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/day_3/point.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10| / impl PartialEq for Point { [INFO] [stderr] 11| | fn eq(&self, other: &Point) -> bool { [INFO] [stderr] 12| | self.x == other.x && self.y == other.y [INFO] [stderr] 13| | } [INFO] [stderr] 14| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_2018`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `puzzle` [INFO] [stderr] --> src/day_3.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | fn part_2(&self, puzzle: &str) -> io::Result { [INFO] [stderr] | ^^^^^^ help: consider using `_puzzle` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/day_1.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / if seen_freqs.contains_key(&next_freq) { [INFO] [stderr] 29 | | return Ok(Solution::I32(next_freq)); [INFO] [stderr] 30 | | } else { [INFO] [stderr] 31 | | seen_freqs.insert(next_freq, 0); [INFO] [stderr] 32 | | prev = next_freq; [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________________^ help: consider using: `seen_freqs.entry(next_freq)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/day_3/point.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Debug, Hash, Eq, Clone)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/day_3/point.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10| / impl PartialEq for Point { [INFO] [stderr] 11| | fn eq(&self, other: &Point) -> bool { [INFO] [stderr] 12| | self.x == other.x && self.y == other.y [INFO] [stderr] 13| | } [INFO] [stderr] 14| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_2018`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b21620e22b94a71286de1415e0fa7166843df68e390ff51c1666fe893b3f67b0"` [INFO] running `"docker" "rm" "-f" "b21620e22b94a71286de1415e0fa7166843df68e390ff51c1666fe893b3f67b0"` [INFO] [stdout] b21620e22b94a71286de1415e0fa7166843df68e390ff51c1666fe893b3f67b0