[INFO] updating cached repository granite-zero/lsnap [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/granite-zero/lsnap [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/granite-zero/lsnap" "work/ex/clippy-test-run/sources/stable/gh/granite-zero/lsnap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/granite-zero/lsnap'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/granite-zero/lsnap" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/granite-zero/lsnap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/granite-zero/lsnap'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d8182438219545b1a1a6f54b92a5671fc1f6d07b [INFO] sha for GitHub repo granite-zero/lsnap: d8182438219545b1a1a6f54b92a5671fc1f6d07b [INFO] validating manifest of granite-zero/lsnap on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of granite-zero/lsnap on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing granite-zero/lsnap [INFO] finished frobbing granite-zero/lsnap [INFO] frobbed toml for granite-zero/lsnap written to work/ex/clippy-test-run/sources/stable/gh/granite-zero/lsnap/Cargo.toml [INFO] started frobbing granite-zero/lsnap [INFO] finished frobbing granite-zero/lsnap [INFO] frobbed toml for granite-zero/lsnap written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/granite-zero/lsnap/Cargo.toml [INFO] crate granite-zero/lsnap has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting granite-zero/lsnap against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/granite-zero/lsnap:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 090726ed2bd2302371d516289d1fd60f75b651bfb91ab1f07e25108deccf73e2 [INFO] running `"docker" "start" "-a" "090726ed2bd2302371d516289d1fd60f75b651bfb91ab1f07e25108deccf73e2"` [INFO] [stderr] Checking linked-hash-map v0.2.1 [INFO] [stderr] Checking seahash v3.0.5 [INFO] [stderr] Compiling libsqlite3-sys v0.6.2 [INFO] [stderr] Checking docopt v0.7.0 [INFO] [stderr] Checking lru-cache v0.1.0 [INFO] [stderr] warning: redundant linker flag specified for library `sqlite3` [INFO] [stderr] [INFO] [stderr] Checking rusqlite v0.9.5 [INFO] [stderr] Checking lsnap v0.1.22 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decompress.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compress.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/backup.rs:294:5 [INFO] [stderr] | [INFO] [stderr] 294 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decompress.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compress.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/backup.rs:294:5 [INFO] [stderr] | [INFO] [stderr] 294 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/compress.rs:96:49 [INFO] [stderr] | [INFO] [stderr] 96 | self.get_batch_at_cursor().wrapping_mul(134775813).wrapping_add(1) as usize % [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_775_813` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/backup.rs:203:70 [INFO] [stderr] | [INFO] [stderr] 203 | block_counter as usize * block_size / 1048576, [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/backup.rs:204:78 [INFO] [stderr] | [INFO] [stderr] 204 | (duplicate_blocks_found * block_size as u32 / 1048576) as f32); [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/backup.rs:293:58 [INFO] [stderr] | [INFO] [stderr] 293 | (duplicate_blocks_found * block_size as u32 / 1048576) as f32); [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:63:35 [INFO] [stderr] | [INFO] [stderr] 63 | let block_size = block_size * 1048576; //convert MiB to bytes [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/compress.rs:96:49 [INFO] [stderr] | [INFO] [stderr] 96 | self.get_batch_at_cursor().wrapping_mul(134775813).wrapping_add(1) as usize % [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_775_813` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/backup.rs:203:70 [INFO] [stderr] | [INFO] [stderr] 203 | block_counter as usize * block_size / 1048576, [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/backup.rs:204:78 [INFO] [stderr] | [INFO] [stderr] 204 | (duplicate_blocks_found * block_size as u32 / 1048576) as f32); [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/backup.rs:293:58 [INFO] [stderr] | [INFO] [stderr] 293 | (duplicate_blocks_found * block_size as u32 / 1048576) as f32); [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:63:35 [INFO] [stderr] | [INFO] [stderr] 63 | let block_size = block_size * 1048576; //convert MiB to bytes [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/backup.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | compression_type: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backup.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match rusqlite::Connection::open(&filepath) {//try opening each file in the directory as an sqlite file [INFO] [stderr] 66 | | [INFO] [stderr] 67 | | Ok(other_file_connection) => { [INFO] [stderr] 68 | | match other_file_connection.query_row("SELECT seed,block_size FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] ... | [INFO] [stderr] 86 | | Err(_) => {} [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Ok(other_file_connection) = rusqlite::Connection::open(&filepath) { [INFO] [stderr] 66 | match other_file_connection.query_row("SELECT seed,block_size FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] 67 | &[], [INFO] [stderr] 68 | |row|{ (row.get::<_, String>(0), row.get::<_, String>(1))}) { [INFO] [stderr] 69 | [INFO] [stderr] 70 | Ok(file_info_result) => { //Found the other backup compatible sqlite database here. Verify its parameters meet the current program version and block size settings [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backup.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / match other_file_connection.query_row("SELECT seed,block_size FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] 69 | | &[], [INFO] [stderr] 70 | | |row|{ (row.get::<_, String>(0), row.get::<_, String>(1))}) { [INFO] [stderr] 71 | | [INFO] [stderr] ... | [INFO] [stderr] 81 | | [INFO] [stderr] 82 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | if let Ok(file_info_result) = other_file_connection.query_row("SELECT seed,block_size FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] 69 | &[], [INFO] [stderr] 70 | |row|{ (row.get::<_, String>(0), row.get::<_, String>(1))}) { //Found the other backup compatible sqlite database here. Verify its parameters meet the current program version and block size settings [INFO] [stderr] 71 | if (SEED == file_info_result.0) && (block_size.to_string() == file_info_result.1) { [INFO] [stderr] 72 | [INFO] [stderr] 73 | collection_of_other_suitable_backup_files.push(filepath); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/backup.rs:264:44 [INFO] [stderr] | [INFO] [stderr] 264 | compression_type: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/backup.rs:263:38 [INFO] [stderr] | [INFO] [stderr] 263 | block_size: &usize, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/backup.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | compression_type: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backup.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match rusqlite::Connection::open(&filepath) {//try opening each file in the directory as an sqlite file [INFO] [stderr] 66 | | [INFO] [stderr] 67 | | Ok(other_file_connection) => { [INFO] [stderr] 68 | | match other_file_connection.query_row("SELECT seed,block_size FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] ... | [INFO] [stderr] 86 | | Err(_) => {} [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Ok(other_file_connection) = rusqlite::Connection::open(&filepath) { [INFO] [stderr] 66 | match other_file_connection.query_row("SELECT seed,block_size FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] 67 | &[], [INFO] [stderr] 68 | |row|{ (row.get::<_, String>(0), row.get::<_, String>(1))}) { [INFO] [stderr] 69 | [INFO] [stderr] 70 | Ok(file_info_result) => { //Found the other backup compatible sqlite database here. Verify its parameters meet the current program version and block size settings [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/restore.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match rusqlite::Connection::open(&filepath) {//try opening each file in the directory as an sqlite file [INFO] [stderr] 90 | | [INFO] [stderr] 91 | | Ok(other_file_connection) => { [INFO] [stderr] 92 | | match other_file_connection.query_row("SELECT seed,block_size, compression_type FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] ... | [INFO] [stderr] 109 | | Err(_) => {} [INFO] [stderr] 110 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 89 | if let Ok(other_file_connection) = rusqlite::Connection::open(&filepath) { [INFO] [stderr] 90 | match other_file_connection.query_row("SELECT seed,block_size, compression_type FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] 91 | &[], [INFO] [stderr] 92 | |row|{ (row.get::<_, String>(0), row.get::<_, String>(1), row.get::<_,String>(2))}) { [INFO] [stderr] 93 | [INFO] [stderr] 94 | Ok(file_info_result) => { //Found the other backup compatible sqlite database here. Verify its parameters meet the current program version and block size settings [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/restore.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | / match other_file_connection.query_row("SELECT seed,block_size, compression_type FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] 93 | | &[], [INFO] [stderr] 94 | | |row|{ (row.get::<_, String>(0), row.get::<_, String>(1), row.get::<_,String>(2))}) { [INFO] [stderr] 95 | | [INFO] [stderr] ... | [INFO] [stderr] 104 | | [INFO] [stderr] 105 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backup.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / match other_file_connection.query_row("SELECT seed,block_size FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] 69 | | &[], [INFO] [stderr] 70 | | |row|{ (row.get::<_, String>(0), row.get::<_, String>(1))}) { [INFO] [stderr] 71 | | [INFO] [stderr] ... | [INFO] [stderr] 81 | | [INFO] [stderr] 82 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Ok(file_info_result) = other_file_connection.query_row("SELECT seed,block_size, compression_type FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] 93 | &[], [INFO] [stderr] 94 | |row|{ (row.get::<_, String>(0), row.get::<_, String>(1), row.get::<_,String>(2))}) { //Found the other backup compatible sqlite database here. Verify its parameters meet the current program version and block size settings [INFO] [stderr] 95 | if (SEED == file_info_result.0) && (block_size.to_string() == file_info_result.1) { [INFO] [stderr] 96 | [INFO] [stderr] 97 | collection_of_other_suitable_restore_files.push(filepath); [INFO] [stderr] ... [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | if let Ok(file_info_result) = other_file_connection.query_row("SELECT seed,block_size FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] 69 | &[], [INFO] [stderr] 70 | |row|{ (row.get::<_, String>(0), row.get::<_, String>(1))}) { //Found the other backup compatible sqlite database here. Verify its parameters meet the current program version and block size settings [INFO] [stderr] 71 | if (SEED == file_info_result.0) && (block_size.to_string() == file_info_result.1) { [INFO] [stderr] 72 | [INFO] [stderr] 73 | collection_of_other_suitable_backup_files.push(filepath); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/backup.rs:264:44 [INFO] [stderr] | [INFO] [stderr] 264 | compression_type: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/backup.rs:263:38 [INFO] [stderr] | [INFO] [stderr] 263 | block_size: &usize, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/restore.rs:212:48 [INFO] [stderr] | [INFO] [stderr] 212 | if source_file_compression_type == "LZ4".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"LZ4"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/restore.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | / io::stdout() [INFO] [stderr] 216 | | .write(&decompress(&blob_restore_vector) [INFO] [stderr] 217 | | .expect("Failed when decompressing foreign file stream, error code 509")) [INFO] [stderr] 218 | | .expect("Failed when writing decompressed foreign file stream to stdout, \ [INFO] [stderr] 219 | | error code 510"); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/restore.rs:221:55 [INFO] [stderr] | [INFO] [stderr] 221 | } else if source_file_compression_type == "none".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"none"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/restore.rs:224:17 [INFO] [stderr] | [INFO] [stderr] 224 | / io::stdout() [INFO] [stderr] 225 | | .write(&blob_restore_vector) [INFO] [stderr] 226 | | .expect("Failed when writing main file stream to stdout, error code 511"); [INFO] [stderr] | |_____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/restore.rs:257:32 [INFO] [stderr] | [INFO] [stderr] 257 | hash: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/restore.rs:334:38 [INFO] [stderr] | [INFO] [stderr] 334 | if this_file_compression_type == "LZ4".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"LZ4"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/restore.rs:337:9 [INFO] [stderr] | [INFO] [stderr] 337 | / io::stdout() [INFO] [stderr] 338 | | .write(&decompress(&blob_restore_vector) [INFO] [stderr] 339 | | .expect("Failed when decompressing foreign file stream, error code 517")) [INFO] [stderr] 340 | | .expect("Failed when writing decompressed foreign file stream to stdout, error code \ [INFO] [stderr] 341 | | 518"); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/restore.rs:343:45 [INFO] [stderr] | [INFO] [stderr] 343 | } else if this_file_compression_type == "none".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"none"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/restore.rs:346:9 [INFO] [stderr] | [INFO] [stderr] 346 | / io::stdout() [INFO] [stderr] 347 | | .write(&blob_restore_vector) [INFO] [stderr] 348 | | .expect("Failed to write restored block to stdout, error code 519"); [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/restore.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match rusqlite::Connection::open(&filepath) {//try opening each file in the directory as an sqlite file [INFO] [stderr] 90 | | [INFO] [stderr] 91 | | Ok(other_file_connection) => { [INFO] [stderr] 92 | | match other_file_connection.query_row("SELECT seed,block_size, compression_type FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] ... | [INFO] [stderr] 109 | | Err(_) => {} [INFO] [stderr] 110 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] | [INFO] [stderr] help: try this [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] | [INFO] [stderr] 89 | if let Ok(other_file_connection) = rusqlite::Connection::open(&filepath) { [INFO] [stderr] 90 | match other_file_connection.query_row("SELECT seed,block_size, compression_type FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] 91 | &[], [INFO] [stderr] 92 | |row|{ (row.get::<_, String>(0), row.get::<_, String>(1), row.get::<_,String>(2))}) { [INFO] [stderr] 93 | [INFO] [stderr] 94 | Ok(file_info_result) => { //Found the other backup compatible sqlite database here. Verify its parameters meet the current program version and block size settings [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/restore.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | / match other_file_connection.query_row("SELECT seed,block_size, compression_type FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] 93 | | &[], [INFO] [stderr] 94 | | |row|{ (row.get::<_, String>(0), row.get::<_, String>(1), row.get::<_,String>(2))}) { [INFO] [stderr] 95 | | [INFO] [stderr] ... | [INFO] [stderr] 104 | | [INFO] [stderr] 105 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Ok(file_info_result) = other_file_connection.query_row("SELECT seed,block_size, compression_type FROM file_info;", //Connection successful, but is it the correct format of the file? Atteempt get seed and block size [INFO] [stderr] 93 | &[], [INFO] [stderr] 94 | |row|{ (row.get::<_, String>(0), row.get::<_, String>(1), row.get::<_,String>(2))}) { //Found the other backup compatible sqlite database here. Verify its parameters meet the current program version and block size settings [INFO] [stderr] 95 | if (SEED == file_info_result.0) && (block_size.to_string() == file_info_result.1) { [INFO] [stderr] 96 | [INFO] [stderr] 97 | collection_of_other_suitable_restore_files.push(filepath); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:65:28 [INFO] [stderr] | [INFO] [stderr] 65 | if compression_type != "LZ4".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"LZ4"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:77:8 [INFO] [stderr] | [INFO] [stderr] 77 | if backup_destination_file_path.is_file() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `backup_destination_file_path.is_file()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/restore.rs:212:48 [INFO] [stderr] | [INFO] [stderr] 212 | if source_file_compression_type == "LZ4".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"LZ4"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/restore.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | / io::stdout() [INFO] [stderr] 216 | | .write(&decompress(&blob_restore_vector) [INFO] [stderr] 217 | | .expect("Failed when decompressing foreign file stream, error code 509")) [INFO] [stderr] 218 | | .expect("Failed when writing decompressed foreign file stream to stdout, \ [INFO] [stderr] 219 | | error code 510"); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/restore.rs:221:55 [INFO] [stderr] | [INFO] [stderr] 221 | } else if source_file_compression_type == "none".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"none"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/restore.rs:224:17 [INFO] [stderr] | [INFO] [stderr] 224 | / io::stdout() [INFO] [stderr] 225 | | .write(&blob_restore_vector) [INFO] [stderr] 226 | | .expect("Failed when writing main file stream to stdout, error code 511"); [INFO] [stderr] | |_____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/restore.rs:257:32 [INFO] [stderr] | [INFO] [stderr] 257 | hash: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/restore.rs:334:38 [INFO] [stderr] | [INFO] [stderr] 334 | if this_file_compression_type == "LZ4".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"LZ4"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/restore.rs:337:9 [INFO] [stderr] | [INFO] [stderr] 337 | / io::stdout() [INFO] [stderr] 338 | | .write(&decompress(&blob_restore_vector) [INFO] [stderr] 339 | | .expect("Failed when decompressing foreign file stream, error code 517")) [INFO] [stderr] 340 | | .expect("Failed when writing decompressed foreign file stream to stdout, error code \ [INFO] [stderr] 341 | | 518"); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/restore.rs:343:45 [INFO] [stderr] | [INFO] [stderr] 343 | } else if this_file_compression_type == "none".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"none"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/restore.rs:346:9 [INFO] [stderr] | [INFO] [stderr] 346 | / io::stdout() [INFO] [stderr] 347 | | .write(&blob_restore_vector) [INFO] [stderr] 348 | | .expect("Failed to write restored block to stdout, error code 519"); [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: Could not compile `lsnap`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:65:28 [INFO] [stderr] | [INFO] [stderr] 65 | if compression_type != "LZ4".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"LZ4"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:77:8 [INFO] [stderr] | [INFO] [stderr] 77 | if backup_destination_file_path.is_file() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `backup_destination_file_path.is_file()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lsnap`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "090726ed2bd2302371d516289d1fd60f75b651bfb91ab1f07e25108deccf73e2"` [INFO] running `"docker" "rm" "-f" "090726ed2bd2302371d516289d1fd60f75b651bfb91ab1f07e25108deccf73e2"` [INFO] [stdout] 090726ed2bd2302371d516289d1fd60f75b651bfb91ab1f07e25108deccf73e2