[INFO] updating cached repository grahame/dividebatur2 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/grahame/dividebatur2 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/grahame/dividebatur2" "work/ex/clippy-test-run/sources/stable/gh/grahame/dividebatur2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/grahame/dividebatur2'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/grahame/dividebatur2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grahame/dividebatur2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grahame/dividebatur2'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f52f658ff168ef1070b659fe57fcdf283318bc92 [INFO] sha for GitHub repo grahame/dividebatur2: f52f658ff168ef1070b659fe57fcdf283318bc92 [INFO] validating manifest of grahame/dividebatur2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grahame/dividebatur2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grahame/dividebatur2 [INFO] finished frobbing grahame/dividebatur2 [INFO] frobbed toml for grahame/dividebatur2 written to work/ex/clippy-test-run/sources/stable/gh/grahame/dividebatur2/Cargo.toml [INFO] started frobbing grahame/dividebatur2 [INFO] finished frobbing grahame/dividebatur2 [INFO] frobbed toml for grahame/dividebatur2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grahame/dividebatur2/Cargo.toml [INFO] crate grahame/dividebatur2 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grahame/dividebatur2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/grahame/dividebatur2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8fb46bdb8b78a91944fda08dee7fa00b92106e1d8984e9b8830159178d74d2e1 [INFO] running `"docker" "start" "-a" "8fb46bdb8b78a91944fda08dee7fa00b92106e1d8984e9b8830159178d74d2e1"` [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking num-complex v0.1.42 [INFO] [stderr] Checking num-bigint v0.1.43 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking rayon v1.0.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking dividebatur v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | ballot_states: ballot_states, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ballot_states` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | papers: papers, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `papers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/senate2015.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/senate2015.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | parties: parties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `parties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/senate2015.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | tickets: tickets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tickets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | ballot_states: ballot_states, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ballot_states` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | papers: papers, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `papers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/senate2015.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/senate2015.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | parties: parties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `parties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/senate2015.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | tickets: tickets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tickets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/aec/data/candidates.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | Ok((rows)) [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/aec/data/candidates.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | Ok((rows)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aec/data/formalpreferences.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | return form_buf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `form_buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/engine.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/engine.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | let out = ToPrimitive::to_u32(&vr).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:465:9 [INFO] [stderr] | [INFO] [stderr] 465 | return CountOutcome::CountContinues(self.count_states.len(), count_state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CountOutcome::CountContinues(self.count_states.len(), count_state)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/defs.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | return self.names[idx.0 as usize].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.names[idx.0 as usize].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/defs.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return self.parties[idx.0 as usize].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parties[idx.0 as usize].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/aec/data/candidates.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | Ok((rows)) [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/aec/data/candidates.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | Ok((rows)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aec/data/formalpreferences.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | return form_buf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `form_buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/engine.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/engine.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | let out = ToPrimitive::to_u32(&vr).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:465:9 [INFO] [stderr] | [INFO] [stderr] 465 | return CountOutcome::CountContinues(self.count_states.len(), count_state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CountOutcome::CountContinues(self.count_states.len(), count_state)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/defs.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | return self.names[idx.0 as usize].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.names[idx.0 as usize].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/defs.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return self.parties[idx.0 as usize].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parties[idx.0 as usize].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/aec/data/formalpreferences.rs:29:39 [INFO] [stderr] | [INFO] [stderr] 29 | fn parse_preferences(raw_preferences: &String, candidates: &CandidateData) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/aec/data/formalpreferences.rs:37:55 [INFO] [stderr] | [INFO] [stderr] 37 | for (pref_idx, pref_str) in raw_preferences.split(",").enumerate() { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/aec/data/formalpreferences.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | assert!(form_buf.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!form_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:86:54 [INFO] [stderr] | [INFO] [stderr] 86 | let v = by_candidate.entry(candidate_id).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | .or_insert(CandidateBundleTransactions::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(CandidateBundleTransactions::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:207:22 [INFO] [stderr] | [INFO] [stderr] 207 | .or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:239:32 [INFO] [stderr] | [INFO] [stderr] 239 | let candidate_votes = *state.votes_per_candidate.get(&candidate).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state.votes_per_candidate[&candidate]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:240:33 [INFO] [stderr] | [INFO] [stderr] 240 | let candidate_papers = *state.papers_per_candidate.get(&candidate).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state.papers_per_candidate[&candidate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:297:12 [INFO] [stderr] | [INFO] [stderr] 297 | if bundles_to_hold.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bundles_to_hold.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/engine.rs:304:44 [INFO] [stderr] | [INFO] [stderr] 304 | fn find_tie_breaker(&self, candidates: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[CandidateIndex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:311:29 [INFO] [stderr] | [INFO] [stderr] 311 | let votes = count_state.votes_per_candidate.get(candidate).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[candidate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/engine.rs:330:44 [INFO] [stderr] | [INFO] [stderr] 330 | votes_eligible_candidate.push((candidate.clone(), votes.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*candidate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/engine.rs:330:63 [INFO] [stderr] | [INFO] [stderr] 330 | votes_eligible_candidate.push((candidate.clone(), votes.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*votes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | assert!(votes_eligible_candidate.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!votes_eligible_candidate.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:367:40 [INFO] [stderr] | [INFO] [stderr] 367 | let bundle_transactions = &self.candidate_bundle_transactions [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 368 | | .get(&to_exclude) [INFO] [stderr] 369 | | .unwrap() [INFO] [stderr] | |_________________________^ help: try this: `&self.candidate_bundle_transactions[&to_exclude]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/aec/data/formalpreferences.rs:29:39 [INFO] [stderr] | [INFO] [stderr] 29 | fn parse_preferences(raw_preferences: &String, candidates: &CandidateData) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:427:12 [INFO] [stderr] | [INFO] [stderr] 427 | if self.actions_pending.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.actions_pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/engine.rs:428:66 [INFO] [stderr] | [INFO] [stderr] 428 | let mut continuing_candidates: Vec = count_state [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 429 | | .votes_per_candidate [INFO] [stderr] 430 | | .keys() [INFO] [stderr] 431 | | .filter(|c| !self.results.candidate_is_inactive(c)) [INFO] [stderr] 432 | | .map(|c| *c) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 428 | let mut continuing_candidates: Vec = count_state [INFO] [stderr] 429 | .votes_per_candidate [INFO] [stderr] 430 | .keys() [INFO] [stderr] 431 | .filter(|c| !self.results.candidate_is_inactive(c)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:434:51 [INFO] [stderr] | [INFO] [stderr] 434 | continuing_candidates.sort_by_key(|c| count_state.votes_per_candidate.get(c).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[c]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:448:20 [INFO] [stderr] | [INFO] [stderr] 448 | if count_state.votes_per_candidate.get(&a).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[&a]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:449:24 [INFO] [stderr] | [INFO] [stderr] 449 | == count_state.votes_per_candidate.get(&b).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[&b]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:461:12 [INFO] [stderr] | [INFO] [stderr] 461 | if self.actions_pending.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.actions_pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/aec/data/formalpreferences.rs:37:55 [INFO] [stderr] | [INFO] [stderr] 37 | for (pref_idx, pref_str) in raw_preferences.split(",").enumerate() { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/aec/data/formalpreferences.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | assert!(form_buf.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!form_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `defs::CountResults` [INFO] [stderr] --> src/defs.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> CountResults { [INFO] [stderr] 36 | | CountResults { [INFO] [stderr] 37 | | elected: Vec::new(), [INFO] [stderr] 38 | | excluded: Vec::new(), [INFO] [stderr] 39 | | inactive: HashSet::new(), [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/defs.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn candidate_is_inactive(&self, candidate: &CandidateIndex) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CandidateIndex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/defs.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn to_next_preference(&mut self, results: &CountResults) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/defs.rs:120:41 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn vec_names(&self, candidates: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[CandidateIndex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:86:54 [INFO] [stderr] | [INFO] [stderr] 86 | let v = by_candidate.entry(candidate_id).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | .or_insert(CandidateBundleTransactions::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(CandidateBundleTransactions::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:207:22 [INFO] [stderr] | [INFO] [stderr] 207 | .or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:239:32 [INFO] [stderr] | [INFO] [stderr] 239 | let candidate_votes = *state.votes_per_candidate.get(&candidate).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state.votes_per_candidate[&candidate]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:240:33 [INFO] [stderr] | [INFO] [stderr] 240 | let candidate_papers = *state.papers_per_candidate.get(&candidate).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state.papers_per_candidate[&candidate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:297:12 [INFO] [stderr] | [INFO] [stderr] 297 | if bundles_to_hold.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bundles_to_hold.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/engine.rs:304:44 [INFO] [stderr] | [INFO] [stderr] 304 | fn find_tie_breaker(&self, candidates: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[CandidateIndex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:311:29 [INFO] [stderr] | [INFO] [stderr] 311 | let votes = count_state.votes_per_candidate.get(candidate).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[candidate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/engine.rs:330:44 [INFO] [stderr] | [INFO] [stderr] 330 | votes_eligible_candidate.push((candidate.clone(), votes.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*candidate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/engine.rs:330:63 [INFO] [stderr] | [INFO] [stderr] 330 | votes_eligible_candidate.push((candidate.clone(), votes.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*votes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | assert!(votes_eligible_candidate.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!votes_eligible_candidate.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:367:40 [INFO] [stderr] | [INFO] [stderr] 367 | let bundle_transactions = &self.candidate_bundle_transactions [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 368 | | .get(&to_exclude) [INFO] [stderr] 369 | | .unwrap() [INFO] [stderr] | |_________________________^ help: try this: `&self.candidate_bundle_transactions[&to_exclude]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:427:12 [INFO] [stderr] | [INFO] [stderr] 427 | if self.actions_pending.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.actions_pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/engine.rs:428:66 [INFO] [stderr] | [INFO] [stderr] 428 | let mut continuing_candidates: Vec = count_state [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 429 | | .votes_per_candidate [INFO] [stderr] 430 | | .keys() [INFO] [stderr] 431 | | .filter(|c| !self.results.candidate_is_inactive(c)) [INFO] [stderr] 432 | | .map(|c| *c) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 428 | let mut continuing_candidates: Vec = count_state [INFO] [stderr] 429 | .votes_per_candidate [INFO] [stderr] 430 | .keys() [INFO] [stderr] 431 | .filter(|c| !self.results.candidate_is_inactive(c)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:434:51 [INFO] [stderr] | [INFO] [stderr] 434 | continuing_candidates.sort_by_key(|c| count_state.votes_per_candidate.get(c).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[c]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:448:20 [INFO] [stderr] | [INFO] [stderr] 448 | if count_state.votes_per_candidate.get(&a).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[&a]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:449:24 [INFO] [stderr] | [INFO] [stderr] 449 | == count_state.votes_per_candidate.get(&b).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[&b]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:461:12 [INFO] [stderr] | [INFO] [stderr] 461 | if self.actions_pending.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.actions_pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `defs::CountResults` [INFO] [stderr] --> src/defs.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> CountResults { [INFO] [stderr] 36 | | CountResults { [INFO] [stderr] 37 | | elected: Vec::new(), [INFO] [stderr] 38 | | excluded: Vec::new(), [INFO] [stderr] 39 | | inactive: HashSet::new(), [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/defs.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn candidate_is_inactive(&self, candidate: &CandidateIndex) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CandidateIndex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/defs.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn to_next_preference(&mut self, results: &CountResults) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/defs.rs:120:41 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn vec_names(&self, candidates: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[CandidateIndex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | ballot_states: ballot_states, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ballot_states` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | papers: papers, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `papers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/senate2015.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/senate2015.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | parties: parties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `parties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/senate2015.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | tickets: tickets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tickets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | ballot_states: ballot_states, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ballot_states` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | papers: papers, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `papers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/senate2015.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/senate2015.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | parties: parties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `parties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/senate2015.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | tickets: tickets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tickets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/aec/data/candidates.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | Ok((rows)) [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/aec/data/candidates.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | Ok((rows)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aec/data/formalpreferences.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | return form_buf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `form_buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/engine.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/engine.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | let out = ToPrimitive::to_u32(&vr).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:465:9 [INFO] [stderr] | [INFO] [stderr] 465 | return CountOutcome::CountContinues(self.count_states.len(), count_state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CountOutcome::CountContinues(self.count_states.len(), count_state)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/defs.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | return self.names[idx.0 as usize].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.names[idx.0 as usize].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/defs.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return self.parties[idx.0 as usize].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parties[idx.0 as usize].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/aec/data/candidates.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | Ok((rows)) [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/aec/data/candidates.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | Ok((rows)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aec/data/formalpreferences.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | return form_buf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `form_buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/engine.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/engine.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | let out = ToPrimitive::to_u32(&vr).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:465:9 [INFO] [stderr] | [INFO] [stderr] 465 | return CountOutcome::CountContinues(self.count_states.len(), count_state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CountOutcome::CountContinues(self.count_states.len(), count_state)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/defs.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | return self.names[idx.0 as usize].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.names[idx.0 as usize].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/defs.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return self.parties[idx.0 as usize].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parties[idx.0 as usize].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/aec/data/formalpreferences.rs:29:39 [INFO] [stderr] | [INFO] [stderr] 29 | fn parse_preferences(raw_preferences: &String, candidates: &CandidateData) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/aec/data/formalpreferences.rs:37:55 [INFO] [stderr] | [INFO] [stderr] 37 | for (pref_idx, pref_str) in raw_preferences.split(",").enumerate() { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/aec/data/formalpreferences.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | assert!(form_buf.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!form_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:86:54 [INFO] [stderr] | [INFO] [stderr] 86 | let v = by_candidate.entry(candidate_id).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | .or_insert(CandidateBundleTransactions::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(CandidateBundleTransactions::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:207:22 [INFO] [stderr] | [INFO] [stderr] 207 | .or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:239:32 [INFO] [stderr] | [INFO] [stderr] 239 | let candidate_votes = *state.votes_per_candidate.get(&candidate).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state.votes_per_candidate[&candidate]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:240:33 [INFO] [stderr] | [INFO] [stderr] 240 | let candidate_papers = *state.papers_per_candidate.get(&candidate).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state.papers_per_candidate[&candidate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:297:12 [INFO] [stderr] | [INFO] [stderr] 297 | if bundles_to_hold.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bundles_to_hold.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/engine.rs:304:44 [INFO] [stderr] | [INFO] [stderr] 304 | fn find_tie_breaker(&self, candidates: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[CandidateIndex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:311:29 [INFO] [stderr] | [INFO] [stderr] 311 | let votes = count_state.votes_per_candidate.get(candidate).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[candidate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/engine.rs:330:44 [INFO] [stderr] | [INFO] [stderr] 330 | votes_eligible_candidate.push((candidate.clone(), votes.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*candidate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/engine.rs:330:63 [INFO] [stderr] | [INFO] [stderr] 330 | votes_eligible_candidate.push((candidate.clone(), votes.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*votes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | assert!(votes_eligible_candidate.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!votes_eligible_candidate.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:367:40 [INFO] [stderr] | [INFO] [stderr] 367 | let bundle_transactions = &self.candidate_bundle_transactions [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 368 | | .get(&to_exclude) [INFO] [stderr] 369 | | .unwrap() [INFO] [stderr] | |_________________________^ help: try this: `&self.candidate_bundle_transactions[&to_exclude]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/aec/data/formalpreferences.rs:29:39 [INFO] [stderr] | [INFO] [stderr] 29 | fn parse_preferences(raw_preferences: &String, candidates: &CandidateData) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/aec/data/formalpreferences.rs:37:55 [INFO] [stderr] | [INFO] [stderr] 37 | for (pref_idx, pref_str) in raw_preferences.split(",").enumerate() { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:427:12 [INFO] [stderr] | [INFO] [stderr] 427 | if self.actions_pending.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.actions_pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/engine.rs:428:66 [INFO] [stderr] | [INFO] [stderr] 428 | let mut continuing_candidates: Vec = count_state [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 429 | | .votes_per_candidate [INFO] [stderr] 430 | | .keys() [INFO] [stderr] 431 | | .filter(|c| !self.results.candidate_is_inactive(c)) [INFO] [stderr] 432 | | .map(|c| *c) [INFO] [stderr] | |____________________________^ [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/aec/data/formalpreferences.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | assert!(form_buf.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!form_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 428 | let mut continuing_candidates: Vec = count_state [INFO] [stderr] 429 | .votes_per_candidate [INFO] [stderr] 430 | .keys() [INFO] [stderr] 431 | .filter(|c| !self.results.candidate_is_inactive(c)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:434:51 [INFO] [stderr] | [INFO] [stderr] 434 | continuing_candidates.sort_by_key(|c| count_state.votes_per_candidate.get(c).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[c]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:448:20 [INFO] [stderr] | [INFO] [stderr] 448 | if count_state.votes_per_candidate.get(&a).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[&a]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:449:24 [INFO] [stderr] | [INFO] [stderr] 449 | == count_state.votes_per_candidate.get(&b).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[&b]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:461:12 [INFO] [stderr] | [INFO] [stderr] 461 | if self.actions_pending.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.actions_pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/defs.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn candidate_is_inactive(&self, candidate: &CandidateIndex) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CandidateIndex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/defs.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn to_next_preference(&mut self, results: &CountResults) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/defs.rs:120:41 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn vec_names(&self, candidates: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[CandidateIndex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:86:54 [INFO] [stderr] | [INFO] [stderr] 86 | let v = by_candidate.entry(candidate_id).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | .or_insert(CandidateBundleTransactions::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(CandidateBundleTransactions::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:207:22 [INFO] [stderr] | [INFO] [stderr] 207 | .or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:239:32 [INFO] [stderr] | [INFO] [stderr] 239 | let candidate_votes = *state.votes_per_candidate.get(&candidate).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state.votes_per_candidate[&candidate]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:240:33 [INFO] [stderr] | [INFO] [stderr] 240 | let candidate_papers = *state.papers_per_candidate.get(&candidate).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state.papers_per_candidate[&candidate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:297:12 [INFO] [stderr] | [INFO] [stderr] 297 | if bundles_to_hold.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bundles_to_hold.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/engine.rs:304:44 [INFO] [stderr] | [INFO] [stderr] 304 | fn find_tie_breaker(&self, candidates: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[CandidateIndex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:311:29 [INFO] [stderr] | [INFO] [stderr] 311 | let votes = count_state.votes_per_candidate.get(candidate).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[candidate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/engine.rs:330:44 [INFO] [stderr] | [INFO] [stderr] 330 | votes_eligible_candidate.push((candidate.clone(), votes.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*candidate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/engine.rs:330:63 [INFO] [stderr] | [INFO] [stderr] 330 | votes_eligible_candidate.push((candidate.clone(), votes.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*votes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | assert!(votes_eligible_candidate.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!votes_eligible_candidate.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:367:40 [INFO] [stderr] | [INFO] [stderr] 367 | let bundle_transactions = &self.candidate_bundle_transactions [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 368 | | .get(&to_exclude) [INFO] [stderr] 369 | | .unwrap() [INFO] [stderr] | |_________________________^ help: try this: `&self.candidate_bundle_transactions[&to_exclude]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:427:12 [INFO] [stderr] | [INFO] [stderr] 427 | if self.actions_pending.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.actions_pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/engine.rs:428:66 [INFO] [stderr] | [INFO] [stderr] 428 | let mut continuing_candidates: Vec = count_state [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 429 | | .votes_per_candidate [INFO] [stderr] 430 | | .keys() [INFO] [stderr] 431 | | .filter(|c| !self.results.candidate_is_inactive(c)) [INFO] [stderr] 432 | | .map(|c| *c) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 428 | let mut continuing_candidates: Vec = count_state [INFO] [stderr] 429 | .votes_per_candidate [INFO] [stderr] 430 | .keys() [INFO] [stderr] 431 | .filter(|c| !self.results.candidate_is_inactive(c)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:434:51 [INFO] [stderr] | [INFO] [stderr] 434 | continuing_candidates.sort_by_key(|c| count_state.votes_per_candidate.get(c).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[c]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:448:20 [INFO] [stderr] | [INFO] [stderr] 448 | if count_state.votes_per_candidate.get(&a).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[&a]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/engine.rs:449:24 [INFO] [stderr] | [INFO] [stderr] 449 | == count_state.votes_per_candidate.get(&b).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count_state.votes_per_candidate[&b]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:461:12 [INFO] [stderr] | [INFO] [stderr] 461 | if self.actions_pending.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.actions_pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/defs.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn candidate_is_inactive(&self, candidate: &CandidateIndex) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CandidateIndex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/defs.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn to_next_preference(&mut self, results: &CountResults) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/defs.rs:120:41 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn vec_names(&self, candidates: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[CandidateIndex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.52s [INFO] running `"docker" "inspect" "8fb46bdb8b78a91944fda08dee7fa00b92106e1d8984e9b8830159178d74d2e1"` [INFO] running `"docker" "rm" "-f" "8fb46bdb8b78a91944fda08dee7fa00b92106e1d8984e9b8830159178d74d2e1"` [INFO] [stdout] 8fb46bdb8b78a91944fda08dee7fa00b92106e1d8984e9b8830159178d74d2e1